From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1pkq-0006mM-9f for guix-patches@gnu.org; Tue, 10 Oct 2017 04:19:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1pkk-0003vM-9y for guix-patches@gnu.org; Tue, 10 Oct 2017 04:19:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50447) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1pkk-0003vB-62 for guix-patches@gnu.org; Tue, 10 Oct 2017 04:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e1pkj-0006mJ-To for guix-patches@gnu.org; Tue, 10 Oct 2017 04:19:01 -0400 Subject: [bug#28723] Add HDF-Java. [PATCH 1/2] gnu: Add java-slf4-simple. Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 10 Oct 2017 10:18:44 +0200 From: julien lepiller In-Reply-To: <20171009192509.GA21287@jasmine.lan> References: <20171006.180153.688490172361889589.post@thomasdanckaert.be> <20171009192509.GA21287@jasmine.lan> Message-ID: <184aac76e16750f0d225cde722a20115@inria.fr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 28723@debbugs.gnu.org Le 2017-10-09 21:25, Leo Famulari a écrit : > On Fri, Oct 06, 2017 at 06:01:53PM +0200, Thomas Danckaert wrote: >> Hi Guix, >> >> this patch adds the “Simple” implementation of the SLF4J interface, >> used by >> HDF-Java's tests. >> >> About this patch: the tests of slf4j-simple require some of >> slf4j-api's test >> code, which are therefore compiled in a somewhat ad-hoc fashion, but >> it >> works... >> >> Thomas > >> From d034b46040d51b7e82fb95df3601dc9925fa1502 Mon Sep 17 00:00:00 2001 >> From: Thomas Danckaert >> Date: Fri, 6 Oct 2017 12:38:34 +0200 >> Subject: [PATCH 1/2] gnu: Add java-slf4-simple. >> >> * gnu/packages/java.scm (java-slf4j-simple): New variable. > > Okay, looks good to me! I don't know whether it's better, but I had to build slf4j-simple for maven. Here is what I have: (define java-slf4j-api-tests (package (inherit java-slf4j-api) (name "java-slf4j-api-tests") (arguments `(#:jar-name "slf4j-api-tests.jar" #:source-dir "slf4j-api/src/test/java" #:tests? #f)) (inputs `(("slf4j" ,java-slf4j-api) ,@(package-inputs java-slf4j-api) ,@(package-native-inputs java-slf4j-api))) (native-inputs '()))) (define-public java-slf4j-simple (package (inherit java-slf4j-api) (name "java-slf4j-simple") (arguments `(#:jar-name "slf4j-simple.jar" #:source-dir "slf4j-simple/src/main/java" #:test-dir "slf4j-simple/src/test")) (inputs `(("slf4j" ,java-slf4j-api) ,@(package-inputs java-slf4j-api))) (native-inputs `(("tests" ,java-slf4j-api-tests) ,@(package-native-inputs java-slf4j-api))))) The idea is that maybe other packages in the slf4j archive will need these tests, so I built a package for them. Otherwise your version LGTM too. Why do you need to build in the current directory and not in build/test-classes? If you build in build/test-classes, I think you don't need to set CLASSPATH in the build-slf4j-api-test-helpers phase.