unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#70483] [PATCH 1/1] gnu: Add python-robotframework-requests.
@ 2024-04-20  8:41 Markku Korkeala
  2024-04-20 17:22 ` Sharlatan Hellseher
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Markku Korkeala @ 2024-04-20  8:41 UTC (permalink / raw)
  To: 70483
  Cc: Markku Korkeala, Lars-Dominik Braun, Marius Bakke,
	Munyoki Kilyungi, Sharlatan Hellseher, Tanguy Le Carrour, jgart

* gnu/packages/python-xyz.scm (python-robotframework-requests): New variable.

Change-Id: I01d814d1a9e20d26e9bfa4a0a77ba91577da2bd8
---
 gnu/packages/python-xyz.scm | 38 +++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index bac90b1e07..ff85b3f2bf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -152,6 +152,7 @@
 ;;; Copyright © 2024 Adriel Dumas--Jondeau <leirda@disroot.org>
 ;;; Copyright © 2024 Navid Afkhami <navid.afkhami@mdc-berlin.de>
 ;;; Copyright © 2024 TakeV <takev@disroot.org>
+;;; Copyright © 2024 Markku Korkeala <markku.korkeala@iki.fi>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -7417,6 +7418,43 @@ (define-public python-robotframework-seleniumscreenshots
 or for visual regression testing purposes.")
     (license license:bsd-3)))
 
+(define-public python-robotframework-requests
+  (package
+    (name "python-robotframework-requests")
+    (version "0.9.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/MarketSquare/robotframework-requests")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "077j8p5k41v53slyv8h32fcmqfi7m6z3r4gmyqqaawm5szfmy61m"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (replace 'check
+                    (lambda* (#:key tests? inputs outputs #:allow-other-keys)
+                      (when tests?
+                        (invoke "pytest" "-v" "utests/")))))))
+    (propagated-inputs (list python-requests python-robotframework))
+    (native-inputs (list python-flask
+                         python-flask
+                         python-coverage
+                         python-flake8
+                         python-mock
+                         python-flake8
+                         python-pytest
+                         python-pytest-cov))
+    (home-page "https://github.com/MarketSquare/robotframework-requests")
+    (synopsis "Robot Framework keyword library wrapper around requests")
+    (description
+     "RequestsLibrary is a Robot Framework library aimed to provide HTTP
+     api testing functionalities by wrapping the well known Python
+     Requests Library.")
+    (license license:expat)))
+
 (define-public python-rstr
   (package
    (name "python-rstr")

base-commit: ee9cf4f00bcb8966fa125787e8534580b270bb99
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#70483] [PATCH 1/1] gnu: Add python-robotframework-requests.
  2024-04-20  8:41 [bug#70483] [PATCH 1/1] gnu: Add python-robotframework-requests Markku Korkeala
@ 2024-04-20 17:22 ` Sharlatan Hellseher
  2024-04-23  8:54 ` [bug#70483] [PATCH v2 " Markku Korkeala
  2024-04-24  9:36 ` bug#70483: [PATCH " Sharlatan Hellseher
  2 siblings, 0 replies; 4+ messages in thread
From: Sharlatan Hellseher @ 2024-04-20 17:22 UTC (permalink / raw)
  To: 70483

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]


Hi!

Thank you for the patch.

There are some modification which need to be applied in v2.

The package is more suitable for python-web.

- [source]: 
- [build-system]: Swap to pyprject-build-system to simplify the package.
- [arguments]: Relay on default check phase.
- [native-inputs]: Remove duplicates, remove python-flake8, remove-coverage.
- [description]: Fix indentation.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#70483] [PATCH v2 1/1] gnu: Add python-robotframework-requests.
  2024-04-20  8:41 [bug#70483] [PATCH 1/1] gnu: Add python-robotframework-requests Markku Korkeala
  2024-04-20 17:22 ` Sharlatan Hellseher
@ 2024-04-23  8:54 ` Markku Korkeala
  2024-04-24  9:36 ` bug#70483: [PATCH " Sharlatan Hellseher
  2 siblings, 0 replies; 4+ messages in thread
From: Markku Korkeala @ 2024-04-23  8:54 UTC (permalink / raw)
  To: 70483
  Cc: Markku Korkeala, Lars-Dominik Braun, Marius Bakke,
	Munyoki Kilyungi, Sharlatan Hellseher, Tanguy Le Carrour, jgart

* gnu/packages/python-web.scm (python-robotframework-requests): New variable.

Change-Id: I01d814d1a9e20d26e9bfa4a0a77ba91577da2bd8
---
Improved the patch according to feedback:

Moved package to gnu/packages/python-web.scm
Switched to pyproject-build-system
Simplified the test phase
Removed duplicate and unnecessary dependencies
Fixed description identation

 gnu/packages/python-web.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 5a532f8460..2d0695d5a4 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -64,6 +64,7 @@
 ;;; Copyright © 2024 Troy Figiel <troy@troyfigiel.com>
 ;;; Copyright © 2024 Sharlatan Hellseher <sharlatanus@gmail.com>
 ;;; Copyright © 2024 normally_js <normally_js@posteo.net>
+;;; Copyright © 2024 Markku Korkeala <markku.korkeala@iki.fi>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3763,6 +3764,33 @@ (define-public python-requests-ftp
 adapter for use with the Requests library.")
     (license license:asl2.0)))
 
+(define-public python-robotframework-requests
+  (package
+    (name "python-robotframework-requests")
+    (version "0.9.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/MarketSquare/robotframework-requests")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "077j8p5k41v53slyv8h32fcmqfi7m6z3r4gmyqqaawm5szfmy61m"))))
+    (build-system pyproject-build-system)
+    (arguments
+     '(#:test-flags '("-v" "utests/")))
+    (propagated-inputs (list python-requests python-robotframework))
+    (native-inputs (list python-flask python-mock python-pytest
+                         python-pytest-cov))
+    (home-page "https://github.com/MarketSquare/robotframework-requests")
+    (synopsis "Robot Framework keyword library wrapper around requests")
+    (description
+     "RequestsLibrary is a Robot Framework library aimed to provide HTTP
+api testing functionalities by wrapping the well known Python Requests
+Library.")
+    (license license:expat)))
+
 (define-public python-aioftp
   (package
     (name "python-aioftp")

base-commit: ee9cf4f00bcb8966fa125787e8534580b270bb99
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#70483: [PATCH 1/1] gnu: Add python-robotframework-requests.
  2024-04-20  8:41 [bug#70483] [PATCH 1/1] gnu: Add python-robotframework-requests Markku Korkeala
  2024-04-20 17:22 ` Sharlatan Hellseher
  2024-04-23  8:54 ` [bug#70483] [PATCH v2 " Markku Korkeala
@ 2024-04-24  9:36 ` Sharlatan Hellseher
  2 siblings, 0 replies; 4+ messages in thread
From: Sharlatan Hellseher @ 2024-04-24  9:36 UTC (permalink / raw)
  To: 70483-done

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]


Pushed as 22d11dab8b09d8aed780d5c1086c9e8e5589bc70 to master with minor
modifications.

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-24  9:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-20  8:41 [bug#70483] [PATCH 1/1] gnu: Add python-robotframework-requests Markku Korkeala
2024-04-20 17:22 ` Sharlatan Hellseher
2024-04-23  8:54 ` [bug#70483] [PATCH v2 " Markku Korkeala
2024-04-24  9:36 ` bug#70483: [PATCH " Sharlatan Hellseher

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).