unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#69842] [PATCH] gnu: Add go-github-com-multiformats-go-varint.
@ 2024-03-17 12:10 Artyom V. Poptsov
  2024-03-17 13:42 ` Sharlatan Hellseher
  2024-03-21 23:57 ` bug#69842: " Sharlatan Hellseher
  0 siblings, 2 replies; 5+ messages in thread
From: Artyom V. Poptsov @ 2024-03-17 12:10 UTC (permalink / raw)
  To: 69842; +Cc: Artyom V. Poptsov, cox.katherine.e+guix, sharlatanus

* gnu/packages/golang.scm (go-github-com-multiformats-go-varint): New
  variable.

Change-Id: Ib2f82fff0fbed00010c2aa7993134d5a855f0d7d
---
 gnu/packages/golang.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index c386421bec..e78eb23a7a 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -5256,6 +5256,28 @@ (define-public go-github-com-multiformats-go-multiaddr-net
 as conversion to and from @command{net.Addr}.")
       (license license:expat))))
 
+(define-public go-github-com-multiformats-go-varint
+  (package
+    (name "go-github-com-multiformats-go-varint")
+    (version "0.0.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/multiformats/go-varint")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0l4s0z3rc3d350zp6qximl1jjhic6l8w74wkmx244jgfzsxd93af"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/mreiferson/go-options"))
+    (home-page "https://github.com/mreiferson/go-options")
+    (synopsis "Varint helpers that enforce minimal encoding")
+    (description
+     "Varint helpers that enforce minimal encoding.")
+    (license license:expat)))
+
 (define-public go-github-com-whyrusleeping-tar-utils
   (let ((commit "8c6c8ba81d5c71fd69c0f48dbde4b2fb422b6dfc")
         (revision "0"))

base-commit: c5a8b46ffc535b7c3acc3dfa4af9ee275676dceb
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#69842] [PATCH] gnu: Add go-github-com-multiformats-go-varint.
  2024-03-17 12:10 [bug#69842] [PATCH] gnu: Add go-github-com-multiformats-go-varint Artyom V. Poptsov
@ 2024-03-17 13:42 ` Sharlatan Hellseher
  2024-03-17 14:36   ` Artyom V. Poptsov
  2024-03-21 23:57 ` bug#69842: " Sharlatan Hellseher
  1 sibling, 1 reply; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-03-17 13:42 UTC (permalink / raw)
  To: 69842; +Cc: Artyom V. Poptsov

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

Hi,

Thank you for the patch.

Please avoid adding new packages into golang.scm, It is in a
 proces of redistribution among submodules.

Pick up any of golang-*.scm modules.

--
Oleg

[-- Attachment #2: Type: text/html, Size: 433 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#69842] [PATCH] gnu: Add go-github-com-multiformats-go-varint.
  2024-03-17 13:42 ` Sharlatan Hellseher
@ 2024-03-17 14:36   ` Artyom V. Poptsov
  2024-03-17 16:23     ` Sharlatan Hellseher
  0 siblings, 1 reply; 5+ messages in thread
From: Artyom V. Poptsov @ 2024-03-17 14:36 UTC (permalink / raw)
  To: Sharlatan Hellseher; +Cc: 69842

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

Hello!

> Please avoid adding new packages into golang.scm, It is in a
>  proces of redistribution among submodules.

I know that you're working on splitting Go packages between more
specific modules.

I placed the new package into "golang.scm" only because other
"go-github-com-multiformats-*" packages are placed here.

Maybe it's reasonable to move all "go-github-com-multiformats-*" to
"golang-xyz.scm" first and then place the new packages from this group
here.  What do you think?

Could you merge "go-github-com-multiformats-go-varint" after the review
process (and maybe with corrections to the package from my side) and
then move all "go-github-com-multiformats-*" to "golang-xyz.scm"?

Thanks!
- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#69842] [PATCH] gnu: Add go-github-com-multiformats-go-varint.
  2024-03-17 14:36   ` Artyom V. Poptsov
@ 2024-03-17 16:23     ` Sharlatan Hellseher
  0 siblings, 0 replies; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-03-17 16:23 UTC (permalink / raw)
  To: Artyom V. Poptsov; +Cc: 69842

Hi,

> Could you merge "go-github-com-multiformats-go-varint" after the review
> process (and maybe with corrections to the package from my side) and
> then move all "go-github-com-multiformats-*" to "golang-xyz.scm"?

Sounds like a plan!
Let's wait until QA picking  it up and I'll move mentioned to golang-xyz.scm

-- 
VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/
GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#69842: [PATCH] gnu: Add go-github-com-multiformats-go-varint.
  2024-03-17 12:10 [bug#69842] [PATCH] gnu: Add go-github-com-multiformats-go-varint Artyom V. Poptsov
  2024-03-17 13:42 ` Sharlatan Hellseher
@ 2024-03-21 23:57 ` Sharlatan Hellseher
  1 sibling, 0 replies; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-03-21 23:57 UTC (permalink / raw)
  To: 69842-done

[-- Attachment #1: Type: text/plain, Size: 63 bytes --]


Pushed as 791578befb7e129f682f38bfe903c23baa46fb91 to master.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-03-22  0:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-17 12:10 [bug#69842] [PATCH] gnu: Add go-github-com-multiformats-go-varint Artyom V. Poptsov
2024-03-17 13:42 ` Sharlatan Hellseher
2024-03-17 14:36   ` Artyom V. Poptsov
2024-03-17 16:23     ` Sharlatan Hellseher
2024-03-21 23:57 ` bug#69842: " Sharlatan Hellseher

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).