unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40782] new package; hexer
@ 2020-04-22 20:38 Tom via Guix-patches via
  2020-05-01 17:05 ` [bug#40782] patch#40782 " Brice Waegeneire
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Tom via Guix-patches via @ 2020-04-22 20:38 UTC (permalink / raw)
  To: 40782

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]

This is a text editor for binary files, please let me know if you are Ok with 
the file I picked for it.

[-- Attachment #2: 0001-gnu-Add-hexer.patch --]
[-- Type: text/x-patch, Size: 2029 bytes --]

From 2c0ba963679e37f444094ec4b5f21160d27ab361 Mon Sep 17 00:00:00 2001
From: TomZ <tomz@freedommail.ch>
Date: Wed, 22 Apr 2020 22:31:03 +0200
Subject: [PATCH] gnu: Add hexer

* gnu/packages/text-editors.scm (hexer): New Variable
---
 gnu/packages/text-editors.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 36571e7846..9af3b15f8d 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -967,3 +967,35 @@ keybindings, autocomplete and unlimited undo.  It can pipe a marked block
 of text through any command line filter.  It can also open very large binary
 files.  It was originally developed on the Amiga 3000T.")
     (license license:gpl3+)))
+
+(define-public hexer
+  (package
+    (name "hexer")
+    (version "1.0.5")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://devel.ringlet.net/files/editors/hexer/"
+                            "hexer-" version ".tar.xz"))
+        (sha256
+          (base32 "14ap9zmwya9m8v896jdvjkbv234yl8w9wfa4apyfh14vcgjkb8rr"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f
+       #:make-flags
+       (list "CC=gcc"
+             (string-append "PREFIX=" (assoc-ref %outputs "out"))
+             (string-append "LTERMCAP=-lncurses")
+             (string-append "LDFLAGS=-L" (assoc-ref %build-inputs "ncurses")
+                            "/lib"))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))))            ;no configure script
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (home-page "https://devel.ringlet.net/editors/hexer/")
+    (synopsis "Multi buffer editor for binary files with vi-like interface")
+    (description "Hexer is a multi-buffer editor for binary files for Unix-like systems
+that displays its buffer(s) as a hex dump.  The user interface is kept
+similar to vi/ex.")
+    (license license:bsd-3)))
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#40782] patch#40782 new package; hexer
  2020-04-22 20:38 [bug#40782] new package; hexer Tom via Guix-patches via
@ 2020-05-01 17:05 ` Brice Waegeneire
  2020-05-01 22:55   ` Kyle Meyer
  2020-05-02 10:37 ` [bug#40782] Update Tom via Guix-patches via
  2020-05-06  9:14 ` bug#40782: patch#40782 new package; hexer Brice Waegeneire
  2 siblings, 1 reply; 5+ messages in thread
From: Brice Waegeneire @ 2020-05-01 17:05 UTC (permalink / raw)
  To: tomz; +Cc: 40782

Hello Tom,

Thank you for the patch!

There a few minor thing to adjust from your patch:
1. Add your copyright at the top of the file.
2. End your git title and message lines with a colon.
2. Use the latest version of the package, 1.0.6.
3. Keep the description line under 80 character.
4. Add a comment about why the tests are disabled, in our case
    there is no test suite.

  Cheers,
  - Brice




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#40782] patch#40782 new package; hexer
  2020-05-01 17:05 ` [bug#40782] patch#40782 " Brice Waegeneire
@ 2020-05-01 22:55   ` Kyle Meyer
  0 siblings, 0 replies; 5+ messages in thread
From: Kyle Meyer @ 2020-05-01 22:55 UTC (permalink / raw)
  To: Brice Waegeneire, tomz; +Cc: 40782

Brice Waegeneire writes:

> 2. End your git title and message lines with a colon.

s/colon/period/ :)




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#40782] Update
  2020-04-22 20:38 [bug#40782] new package; hexer Tom via Guix-patches via
  2020-05-01 17:05 ` [bug#40782] patch#40782 " Brice Waegeneire
@ 2020-05-02 10:37 ` Tom via Guix-patches via
  2020-05-06  9:14 ` bug#40782: patch#40782 new package; hexer Brice Waegeneire
  2 siblings, 0 replies; 5+ messages in thread
From: Tom via Guix-patches via @ 2020-05-02 10:37 UTC (permalink / raw)
  To: 40782

[-- Attachment #1: Type: text/plain, Size: 42 bytes --]

Updated patch with the suggested changes.

[-- Attachment #2: 0001-gnu-Add-hexer.patch --]
[-- Type: text/x-patch, Size: 2436 bytes --]

From ab228533702e3a99b6495350699cefb2cfcabb6f Mon Sep 17 00:00:00 2001
From: TomZ <tomz@freedommail.ch>
Date: Wed, 22 Apr 2020 22:31:03 +0200
Subject: [PATCH 1/2] gnu: Add hexer.

* gnu/packages/text-editors.scm (hexer): New Variable.
---
 gnu/packages/text-editors.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 072760ee10..886babf3fa 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2019 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2019, 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2020 Marius Bakke <mbakke@fastmail.com>
+;;; Copyright © 2020 Tom Zander <tomz@freedommail.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -967,3 +968,35 @@ keybindings, autocomplete and unlimited undo.  It can pipe a marked block
 of text through any command line filter.  It can also open very large binary
 files.  It was originally developed on the Amiga 3000T.")
     (license license:gpl3+)))
+
+(define-public hexer
+  (package
+    (name "hexer")
+    (version "1.0.6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://devel.ringlet.net/files/editors/hexer/"
+                            "hexer-" version ".tar.xz"))
+        (sha256
+          (base32 "157z17z8qivdin2km2wp86x1bv1nx15frrwcz11mk0l3ab74mf76"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                      ;no upstream tests
+       #:make-flags
+       (list "CC=gcc"
+             (string-append "PREFIX=" (assoc-ref %outputs "out"))
+             (string-append "LTERMCAP=-lncurses")
+             (string-append "LDFLAGS=-L" (assoc-ref %build-inputs "ncurses")
+                            "/lib"))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))))         ;no configure script
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (home-page "https://devel.ringlet.net/editors/hexer/")
+    (synopsis "Multi buffer editor for binary files with vi-like interface")
+    (description "Hexer is a multi-buffer editor for binary files for Unix-like
+systems that displays its buffer(s) as a hex dump.  The user interface is kept
+similar to vi/ex.")
+    (license license:bsd-3)))
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#40782: patch#40782 new package; hexer
  2020-04-22 20:38 [bug#40782] new package; hexer Tom via Guix-patches via
  2020-05-01 17:05 ` [bug#40782] patch#40782 " Brice Waegeneire
  2020-05-02 10:37 ` [bug#40782] Update Tom via Guix-patches via
@ 2020-05-06  9:14 ` Brice Waegeneire
  2 siblings, 0 replies; 5+ messages in thread
From: Brice Waegeneire @ 2020-05-06  9:14 UTC (permalink / raw)
  To: 40782-done

Pushed as 8b95f741353248c19a5d70dc19e311ed059143f3.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-06  9:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 20:38 [bug#40782] new package; hexer Tom via Guix-patches via
2020-05-01 17:05 ` [bug#40782] patch#40782 " Brice Waegeneire
2020-05-01 22:55   ` Kyle Meyer
2020-05-02 10:37 ` [bug#40782] Update Tom via Guix-patches via
2020-05-06  9:14 ` bug#40782: patch#40782 new package; hexer Brice Waegeneire

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).