* [bug#34592] [PATCH] gnu: python-fenics-dijitso: Fix build.
@ 2019-02-20 12:16 Paul Garlick
2019-02-20 20:40 ` bug#34592: " Ricardo Wurmus
0 siblings, 1 reply; 2+ messages in thread
From: Paul Garlick @ 2019-02-20 12:16 UTC (permalink / raw)
To: 34592; +Cc: Paul Garlick
* gnu/packages/simulation.scm (python-fenics-dijitso)[arguments]: Skip
parallel tests.
---
gnu/packages/simulation.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
index 20b62f3..3637cc3 100644
--- a/gnu/packages/simulation.scm
+++ b/gnu/packages/simulation.scm
@@ -268,6 +268,11 @@ problems for efficient solution on parallel systems.")
(setenv "PYTHONPATH"
(string-append (getcwd) ":" (getenv "PYTHONPATH")))
(with-directory-excursion "test"
+ ;; Disable parallel tests to avoid race condition. See
+ ;; https://github.com/pytest-dev/pytest-cov/issues/237.
+ (substitute* "runtests.sh"
+ (("for p in 1 4 8 16; do")
+ "for p in 1; do"))
(invoke "./runtests.sh"))
#t)))))
(home-page "https://bitbucket.org/fenics-project/dijitso/")
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#34592: [PATCH] gnu: python-fenics-dijitso: Fix build.
2019-02-20 12:16 [bug#34592] [PATCH] gnu: python-fenics-dijitso: Fix build Paul Garlick
@ 2019-02-20 20:40 ` Ricardo Wurmus
0 siblings, 0 replies; 2+ messages in thread
From: Ricardo Wurmus @ 2019-02-20 20:40 UTC (permalink / raw)
To: Paul Garlick; +Cc: 34592-done
Paul Garlick <pgarlick@tourbillion-technology.com> writes:
> * gnu/packages/simulation.scm (python-fenics-dijitso)[arguments]: Skip
> parallel tests.
> ---
> gnu/packages/simulation.scm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> index 20b62f3..3637cc3 100644
> --- a/gnu/packages/simulation.scm
> +++ b/gnu/packages/simulation.scm
> @@ -268,6 +268,11 @@ problems for efficient solution on parallel systems.")
> (setenv "PYTHONPATH"
> (string-append (getcwd) ":" (getenv "PYTHONPATH")))
> (with-directory-excursion "test"
> + ;; Disable parallel tests to avoid race condition. See
> + ;; https://github.com/pytest-dev/pytest-cov/issues/237.
> + (substitute* "runtests.sh"
> + (("for p in 1 4 8 16; do")
> + "for p in 1; do"))
> (invoke "./runtests.sh"))
> #t)))))
> (home-page "https://bitbucket.org/fenics-project/dijitso/")
I wondered if we could use the #:parallel-tests? argument instead, but
the python-build-system does not support it. This approach looks fine
to me.
Thanks!
I pushed it to the master branch with commit 7a82074ca6.
--
Ricardo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-20 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-20 12:16 [bug#34592] [PATCH] gnu: python-fenics-dijitso: Fix build Paul Garlick
2019-02-20 20:40 ` bug#34592: " Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).