From: Mark Meyer <mark@ofosos.org>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>, 30266@debbugs.gnu.org
Subject: [bug#30266] Add FANN
Date: Thu, 01 Feb 2018 16:32:51 +0100 [thread overview]
Message-ID: <1517499171.1017760.1256044528.7C0C62C3@webmail.messagingengine.com> (raw)
In-Reply-To: <ffeda75e-e2f8-eaf3-8f06-18fc70b1bf85@uq.edu.au>
[-- Attachment #1.1: Type: text/plain, Size: 2980 bytes --]
Thanks for the good feedback. Please consider the attached patch.
Best, Mark
On Sun, Jan 28, 2018, at 03:13, Ben Woodcroft wrote:
> Hi Mark,
> Thanks for the patch.
>> +(define-module (gnu packages ai) + #:use-module ((guix licenses)
>> #:prefix license:) + #:use-module (guix utils) + #:use-module (guix
>> download) + #:use-module (guix packages) + #:use-module (guix build-
>> system cmake) + #:use-module (guix git-download) + #:use-module
>> (gnu packages))> I think machine-learning.scm would be a good home for this package, so
> a new file wouldn't be needed.>
>
>
>> + +(define-public libfann + (package + (name "libfann") +
>> (version "d71d54788b")>
> The last release is 129 commits behind and it has been some time, so I
> think you are right - we should package from a git commit.> Usually we package from git using this style though (i.e. reason for
> not using the release, use of 'file-name', and a version that includes
> the last release followed by '-1.<commit>').> ;; There are no recent releases so we package from git.
> (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87"))
> (package
> (name "newick-utils")
> (version (string-append "1.6-1." (string-take commit 8)))
> (source (origin
> (method git-fetch)
> (uri (git-reference
> (url "
> https://github.com/tjunier/newick_utils.git")> (commit commit)))
> (file-name (string-append name "-" version "-
> checkout"))> (sha256
> (base32
> "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268p-
> xnb"))))>
>
>> + (source (origin + (method git-fetch) +
>> (uri (git-reference + (url "
>> https://github.com/libfann/fann.git") +
>> (commit version))) + (sha256 +
>> (base32 + "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2sk-
>> i4r6215g5jjhg3x")))) + (build-system cmake-build-system) +
>> (arguments + `(#:tests? #f))> I see from the website:
>
>
>> Once you have installed the library you can test it out by going to
>> the examples directory and type make runtest, which will compile the
>> examples and run a few of them to test that everything is working.> Is that possible? Ideally, since there are tests it would be good to
> run them.>
>
>> + (home-page "http://leenissen.dk/fann/wp/") + (synopsis "Fast
>> Artificial Neural Network") + (description + "FANN is a
>> free open source neural network library, which implements
>> +multilayer artificial neural networks in C with support for
>> both fully +connected and sparsely connected networks.") +
>> (license license:lgpl2.1)))> Otherwise LGTM. Can you send an updated patch please?
>
> Thanks, ben
--
Mark Meyer
mark@ofosos.org
[-- Attachment #1.2: Type: text/html, Size: 4884 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-fann.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-fann.patch", Size: 2595 bytes --]
From 7c6eaae56bc9ef57b60ceacf49a33cdd5966b361 Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Thu, 1 Feb 2018 15:07:58 +0100
Subject: [PATCH] gnu: Add fann.
* gnu/packages/machine-learning.scm (fann): New variable.
---
gnu/packages/machine-learning.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index bd13cedcb..faa4bdf7f 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -4,6 +4,7 @@
;;; Copyright © 2016, 2017 Marius Bakke <mbakke@fastmail.com>
;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Mark Meyer <mark@ofosos.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -31,6 +32,7 @@
#:use-module (guix build-system ocaml)
#:use-module (guix build-system python)
#:use-module (guix build-system r)
+ #:use-module (guix git-download)
#:use-module (gnu packages)
#:use-module (gnu packages autotools)
#:use-module (gnu packages boost)
@@ -50,6 +52,35 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg))
+(define-public fann
+ (let ((commit "d71d54788bee56ba4cf7522801270152da5209d7"))
+ (package
+ (name "fann")
+ (version (string-append "2.2.0-1." (string-take commit 8)))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/libfann/fann.git")
+ (commit version)))
+ (sha256
+ (base32
+ "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases (modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out")))
+ (with-directory-excursion (string-append (getcwd) "/tests")
+ (invoke "./fann_tests"))))))))
+ (home-page "http://leenissen.dk/fann/wp/")
+ (synopsis "Fast Artificial Neural Network")
+ (description
+ "FANN is a free open source neural network library, which implements
+multilayer artificial neural networks in C with support for both fully
+connected and sparsely connected networks.")
+ (license license:lgpl2.1))))
+
(define-public libsvm
(package
(name "libsvm")
--
2.15.1
next prev parent reply other threads:[~2018-02-01 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 12:55 [bug#30266] Add FANN Mark Meyer
2018-01-28 2:13 ` Ben Woodcroft
2018-02-01 15:32 ` Mark Meyer [this message]
2018-02-02 13:12 ` bug#30266: " Ben Woodcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517499171.1017760.1256044528.7C0C62C3@webmail.messagingengine.com \
--to=mark@ofosos.org \
--cc=30266@debbugs.gnu.org \
--cc=b.woodcroft@uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).