From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehGrN-0000sn-ID for guix-patches@gnu.org; Thu, 01 Feb 2018 10:33:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehGrH-000257-5s for guix-patches@gnu.org; Thu, 01 Feb 2018 10:33:09 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:44677) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehGrG-00024G-U4 for guix-patches@gnu.org; Thu, 01 Feb 2018 10:33:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ehGrG-0007Ng-HO for guix-patches@gnu.org; Thu, 01 Feb 2018 10:33:02 -0500 Subject: [bug#30266] Add FANN Resent-Message-ID: Message-Id: <1517499171.1017760.1256044528.7C0C62C3@webmail.messagingengine.com> From: Mark Meyer MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_151749917110177601" Date: Thu, 01 Feb 2018 16:32:51 +0100 In-Reply-To: References: <1517057739.331219.1250048536.75FA3BFA@webmail.messagingengine.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ben Woodcroft , 30266@debbugs.gnu.org This is a multi-part message in MIME format. --_----------=_151749917110177601 Content-Transfer-Encoding: 7bit Content-Type: multipart/alternative; boundary="_----------=_151749917110177600" This is a multi-part message in MIME format. --_----------=_151749917110177600 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" Thanks for the good feedback. Please consider the attached patch. Best, Mark On Sun, Jan 28, 2018, at 03:13, Ben Woodcroft wrote: > Hi Mark, > Thanks for the patch. >> +(define-module (gnu packages ai) + #:use-module ((guix licenses) >> #:prefix license:) + #:use-module (guix utils) + #:use-module (guix >> download) + #:use-module (guix packages) + #:use-module (guix build- >> system cmake) + #:use-module (guix git-download) + #:use-module >> (gnu packages))> I think machine-learning.scm would be a good home for this package, so > a new file wouldn't be needed.> > > >> + +(define-public libfann + (package + (name "libfann") + >> (version "d71d54788b")> > The last release is 129 commits behind and it has been some time, so I > think you are right - we should package from a git commit.> Usually we package from git using this style though (i.e. reason for > not using the release, use of 'file-name', and a version that includes > the last release followed by '-1.').> ;; There are no recent releases so we package from git. > (let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87")) > (package > (name "newick-utils") > (version (string-append "1.6-1." (string-take commit 8))) > (source (origin > (method git-fetch) > (uri (git-reference > (url " > https://github.com/tjunier/newick_utils.git")> (commit commit))) > (file-name (string-append name "-" version "- > checkout"))> (sha256 > (base32 > "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268p- > xnb"))))> > >> + (source (origin + (method git-fetch) + >> (uri (git-reference + (url " >> https://github.com/libfann/fann.git") + >> (commit version))) + (sha256 + >> (base32 + "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2sk- >> i4r6215g5jjhg3x")))) + (build-system cmake-build-system) + >> (arguments + `(#:tests? #f))> I see from the website: > > >> Once you have installed the library you can test it out by going to >> the examples directory and type make runtest, which will compile the >> examples and run a few of them to test that everything is working.> Is that possible? Ideally, since there are tests it would be good to > run them.> > >> + (home-page "http://leenissen.dk/fann/wp/") + (synopsis "Fast >> Artificial Neural Network") + (description + "FANN is a >> free open source neural network library, which implements >> +multilayer artificial neural networks in C with support for >> both fully +connected and sparsely connected networks.") + >> (license license:lgpl2.1)))> Otherwise LGTM. Can you send an updated patch please? > > Thanks, ben -- Mark Meyer mark@ofosos.org --_----------=_151749917110177600 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset="utf-8"

Thanks for the good feedback. Please consider the attached patch.

Best, Mark

On Sun, Jan 28, 2018, at 03:13, Ben Woodcroft wrote:

Hi Mark,
Thanks for the patch.
+(define-module (gnu packages ai)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix utils)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix build-system cmake)
+  #:use-module (guix git-download)
+  #:use-module (gnu packages))
I think machine-learning.scm would be a good home for this package, so a new file wouldn't be needed.
+
+(define-public libfann
+  (package
+    (name "libfann")
+    (version "d71d54788b")
The last release is 129 commits behind and it has been some time, so I think you are right - we should package from a git commit.
Usually we package from git using this style though (i.e. reason for not using the release, use of 'file-name', and a version that includes the last release followed by '-1.<commit>').
;; There are no recent releases so we package from git.

(let ((commit "da121155a977197cab9fbb15953ca1b40b11eb87"))

    (package

      (name "newick-utils")

      (version (string-append "1.6-1." (string-take commit 8)))

      (source (origin

                (method git-fetch)

                (uri (git-reference

                      (url "https://github.com/tjunier/newick_utils.git")

                      (commit commit)))

                (file-name (string-append name "-" version "-checkout"))

                (sha256

                 (base32

                  "1hkw21rq1mwf7xp0rmbb2gqc0i6p11108m69i7mr7xcjl268pxnb"))))
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/libfann/fann.git")
+                    (commit version)))
+              (sha256
+               (base32
+                "0ibwpfrjs6q2lijs8slxjgzb2llcl6rk3v2ski4r6215g5jjhg3x"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f))
I see from the website:

Once you have installed the library you can test it out by going to the examples directory and type make runtest, which will compile the examples and run a few of them to test that everything is working.
Is that possible? Ideally, since there are tests it would be good to run them.
+    (home-page "http://leenissen.dk/fann/wp/")
+    (synopsis "Fast Artificial Neural Network")
+    (description
+     "FANN is a free open source neural network library, which implements
+multilayer artificial neural networks in C with support for both fully
+connected and sparsely connected networks.")
+    (license license:lgpl2.1)))
Otherwise LGTM. Can you send an updated patch please?

Thanks, ben

Mark Meyer

mark@ofosos.org

--_----------=_151749917110177600-- --_----------=_151749917110177601 Content-Disposition: attachment; filename="0001-gnu-Add-fann.patch" Content-Id: <1517499166.1017758.f9e0aaefd23e9e8835b45c843b7f9ce7cb6972b1.64165099@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-fann.patch" RnJvbSA3YzZlYWFlNTZiYzllZjU3YjYwY2VhY2Y0OWEzM2NkZDU5NjZiMzYx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIE1leWVyIDxt YXJrQG9mb3Nvcy5vcmc+CkRhdGU6IFRodSwgMSBGZWIgMjAxOCAxNTowNzo1 OCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGdudTogQWRkIGZhbm4uCgoqIGdu dS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNjbSAoZmFubik6IE5ldyB2 YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvbWFjaGluZS1sZWFybmluZy5z Y20gfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZp bGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNjbSBiL2dudS9wYWNrYWdl cy9tYWNoaW5lLWxlYXJuaW5nLnNjbQppbmRleCBiZDEzY2VkY2IuLmZhYTRi ZGY3ZiAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL21hY2hpbmUtbGVhcm5p bmcuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9tYWNoaW5lLWxlYXJuaW5nLnNj bQpAQCAtNCw2ICs0LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiwgMjAx NyBNYXJpdXMgQmFra2UgPG1iYWtrZUBmYXN0bWFpbC5jb20+CiA7OzsgQ29w eXJpZ2h0IMKpIDIwMTYgSGFydG11dCBHb2ViZWwgPGguZ29lYmVsQGNyYXp5 LWNvbXBpbGVycy5jb20+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggVG9iaWFz IEdlZXJpbmNreC1SaWNlIDxtZUB0b2JpYXMuZ3I+Cis7OzsgQ29weXJpZ2h0 IMKpIDIwMTggTWFyayBNZXllciA8bWFya0BvZm9zb3Mub3JnPgogOzs7CiA7 OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTMx LDYgKzMyLDcgQEAKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3Rl bSBvY2FtbCkKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBw eXRob24pCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gcikK KyAgIzp1c2UtbW9kdWxlIChndWl4IGdpdC1kb3dubG9hZCkKICAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIGF1dG90b29scykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgYm9vc3QpCkBAIC01MCw2ICs1MiwzNSBAQAogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyB4bWwpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHhvcmcpKQogCisoZGVmaW5lLXB1YmxpYyBmYW5uCisgIChsZXQgKChj b21taXQgImQ3MWQ1NDc4OGJlZTU2YmE0Y2Y3NTIyODAxMjcwMTUyZGE1MjA5 ZDciKSkKKyAgICAocGFja2FnZQorICAgICAgKG5hbWUgImZhbm4iKQorICAg ICAgKHZlcnNpb24gKHN0cmluZy1hcHBlbmQgIjIuMi4wLTEuIiAoc3RyaW5n LXRha2UgY29tbWl0IDgpKSkKKyAgICAgIChzb3VyY2UgKG9yaWdpbgorICAg ICAgICAgICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAgICAg ICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAgICAgICAg ICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vbGliZmFubi9mYW5uLmdpdCIp CisgICAgICAgICAgICAgICAgICAgICAgKGNvbW1pdCB2ZXJzaW9uKSkpCisg ICAgICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAgICAgICAgICAoYmFz ZTMyCisgICAgICAgICAgICAgICAgICAiMGlid3BmcmpzNnEybGlqczhzbHhq Z3piMmxsY2w2cmszdjJza2k0cjYyMTVnNWpqaGczeCIpKSkpCisgICAgICAo YnVpbGQtc3lzdGVtIGNtYWtlLWJ1aWxkLXN5c3RlbSkKKyAgICAgIChhcmd1 bWVudHMKKyAgICAgICBgKCM6cGhhc2VzIChtb2RpZnktcGhhc2VzICVzdGFu ZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2No ZWNrCisgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91 dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgICAgICAg ICAgICAgKGxldCogKChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICh3aXRoLWRpcmVjdG9yeS1l eGN1cnNpb24gKHN0cmluZy1hcHBlbmQgKGdldGN3ZCkgIi90ZXN0cyIpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi9mYW5uX3Rl c3RzIikpKSkpKSkpCisgICAgICAoaG9tZS1wYWdlICJodHRwOi8vbGVlbmlz c2VuLmRrL2Zhbm4vd3AvIikKKyAgICAgIChzeW5vcHNpcyAiRmFzdCBBcnRp ZmljaWFsIE5ldXJhbCBOZXR3b3JrIikKKyAgICAgIChkZXNjcmlwdGlvbgor ICAgICAgICJGQU5OIGlzIGEgZnJlZSBvcGVuIHNvdXJjZSBuZXVyYWwgbmV0 d29yayBsaWJyYXJ5LCB3aGljaCBpbXBsZW1lbnRzCittdWx0aWxheWVyIGFy dGlmaWNpYWwgbmV1cmFsIG5ldHdvcmtzIGluIEMgd2l0aCBzdXBwb3J0IGZv ciBib3RoIGZ1bGx5Citjb25uZWN0ZWQgYW5kIHNwYXJzZWx5IGNvbm5lY3Rl ZCBuZXR3b3Jrcy4iKQorICAgICAgKGxpY2Vuc2UgbGljZW5zZTpsZ3BsMi4x KSkpKQorCiAoZGVmaW5lLXB1YmxpYyBsaWJzdm0KICAgKHBhY2thZ2UKICAg ICAobmFtZSAibGlic3ZtIikKLS0gCjIuMTUuMQoK --_----------=_151749917110177601--