* [bug#51623] [PATCH] gnu: Add python-ta-lib.
@ 2021-11-06 4:30 Foo Chuan Wei
2021-11-11 6:07 ` Vinicius Monego
0 siblings, 1 reply; 4+ messages in thread
From: Foo Chuan Wei @ 2021-11-06 4:30 UTC (permalink / raw)
To: 51623
* gnu/packages/python-xyz.scm (python-ta-lib): New variable.
---
gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 8ba72170c0..e2e51db25f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -111,6 +111,7 @@
;;; Copyright © 2021 Felix Gruber <felgru@posteo.net>
;;; Copyright © 2021 Sébastien Lerique <sl@eauchat.org>
;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
+;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo@hotmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -146,6 +147,7 @@
#:use-module (gnu packages docker)
#:use-module (gnu packages enchant)
#:use-module (gnu packages file)
+ #:use-module (gnu packages finance)
#:use-module (gnu packages fontutils)
#:use-module (gnu packages gcc)
#:use-module (gnu packages geo)
@@ -27684,3 +27686,29 @@ simple mock/record and a complete capture/replay framework.")
"Ijson is an iterative JSON parser with standard Python iterator
interfaces.")
(license license:bsd-3)))
+
+(define-public python-ta-lib
+ (package
+ (name "python-ta-lib")
+ (version "0.4.21")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "TA-Lib" version))
+ (sha256
+ (base32 "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl"))))
+ (build-system python-build-system)
+ (inputs
+ `(("ta-lib" ,ta-lib)))
+ (propagated-inputs
+ `(("python-numpy" ,python-numpy)))
+ (native-inputs
+ `(("python-nose" ,python-nose)
+ ("python-pandas" ,python-pandas)))
+ (home-page "https://github.com/mrjbq7/ta-lib")
+ (synopsis "Python wrapper for TA-Lib")
+ (description
+ "Python wrapper for TA-Lib based on Cython. TA-Lib is a library
+providing common functions for the technical analysis of financial market
+data.")
+ (license license:bsd-2)))
base-commit: c55a64cb7e82e88e26c26995f983fc9675b6276e
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#51623] [PATCH] gnu: Add python-ta-lib.
2021-11-06 4:30 [bug#51623] [PATCH] gnu: Add python-ta-lib Foo Chuan Wei
@ 2021-11-11 6:07 ` Vinicius Monego
2021-11-15 5:25 ` [bug#51623] [PATCH v2] " Foo Chuan Wei
0 siblings, 1 reply; 4+ messages in thread
From: Vinicius Monego @ 2021-11-11 6:07 UTC (permalink / raw)
To: Foo Chuan Wei, 51623
Hi,
Em sáb, 2021-11-06 às 04:30 +0000, Foo Chuan Wei escreveu:
> * gnu/packages/python-xyz.scm (python-ta-lib): New variable.
Thanks for your contribution. Patch looks good overall, I have only a
few nitpicks.
> ---
> gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
IMO this package would make more sense in finance.scm.
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> xyz.scm
> index 8ba72170c0..e2e51db25f 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -111,6 +111,7 @@
> ;;; Copyright © 2021 Felix Gruber <felgru@posteo.net>
> ;;; Copyright © 2021 Sébastien Lerique <sl@eauchat.org>
> ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
> +;;; Copyright © 2021 Foo Chuan Wei <chuanwei.foo@hotmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -146,6 +147,7 @@
> #:use-module (gnu packages docker)
> #:use-module (gnu packages enchant)
> #:use-module (gnu packages file)
> + #:use-module (gnu packages finance)
> #:use-module (gnu packages fontutils)
> #:use-module (gnu packages gcc)
> #:use-module (gnu packages geo)
> @@ -27684,3 +27686,29 @@ simple mock/record and a complete
> capture/replay framework.")
> "Ijson is an iterative JSON parser with standard Python
> iterator
> interfaces.")
> (license license:bsd-3)))
> +
> +(define-public python-ta-lib
> + (package
> + (name "python-ta-lib")
> + (version "0.4.21")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "TA-Lib" version))
> + (sha256
> + (base32
> "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl"))))
> + (build-system python-build-system)
> + (inputs
> + `(("ta-lib" ,ta-lib)))
> + (propagated-inputs
> + `(("python-numpy" ,python-numpy)))
Description says it's based on Cython, so python-cython should be a
native input.
> + (native-inputs
> + `(("python-nose" ,python-nose)
> + ("python-pandas" ,python-pandas)))
> + (home-page "https://github.com/mrjbq7/ta-lib")
> + (synopsis "Python wrapper for TA-Lib")
There's one extra space in the description. The double quote should be
aligned with the "d" in description.
The description must also be a full sentence. It can be "This package
provides a [...]" or something along these lines.
> + (description
> + "Python wrapper for TA-Lib based on Cython. TA-Lib is a
> library
> +providing common functions for the technical analysis of financial
> market
> +data.")
> + (license license:bsd-2)))
It is also recommended to declare packages somewhere in the middle, not
at the end of the file, to avoid merge conflicts.
>
> base-commit: c55a64cb7e82e88e26c26995f983fc9675b6276e
Vinicius
^ permalink raw reply [flat|nested] 4+ messages in thread* [bug#51623] [PATCH v2] gnu: Add python-ta-lib.
2021-11-11 6:07 ` Vinicius Monego
@ 2021-11-15 5:25 ` Foo Chuan Wei
2021-11-15 16:54 ` bug#51623: " Guillaume Le Vaillant
0 siblings, 1 reply; 4+ messages in thread
From: Foo Chuan Wei @ 2021-11-15 5:25 UTC (permalink / raw)
To: Vinicius Monego; +Cc: 51623
* gnu/packages/finance.scm (python-ta-lib): New variable.
---
gnu/packages/finance.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index c9732f936e..b35ef6be75 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -98,6 +98,7 @@
#:use-module (gnu packages python)
#:use-module (gnu packages python-build)
#:use-module (gnu packages python-crypto)
+ #:use-module (gnu packages python-science)
#:use-module (gnu packages python-web)
#:use-module (gnu packages python-xyz)
#:use-module (gnu packages qt)
@@ -1755,6 +1756,32 @@ local, single-user UI, or as a multi-user UI for viewing, adding, and
editing on the Web.")
(license license:gpl3)))
+(define-public python-ta-lib
+ (package
+ (name "python-ta-lib")
+ (version "0.4.21")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "TA-Lib" version))
+ (sha256
+ (base32 "17sf222mq2vx924f15qlz5czkkq5vsnsjy9ibwkrk8lalr6g5lkl"))))
+ (build-system python-build-system)
+ (inputs
+ `(("ta-lib" ,ta-lib)))
+ (propagated-inputs
+ `(("python-numpy" ,python-numpy)))
+ (native-inputs
+ `(("python-cython" ,python-cython)
+ ("python-nose" ,python-nose)
+ ("python-pandas" ,python-pandas)))
+ (home-page "https://github.com/mrjbq7/ta-lib")
+ (synopsis "Python wrapper for TA-Lib")
+ (description
+ "This is a Python wrapper for TA-Lib based on Cython. TA-Lib is a library
+providing common functions for the technical analysis of financial market data.")
+ (license license:bsd-2)))
+
(define-public ta-lib
(package
(name "ta-lib")
base-commit: 272e8f50511a551ce1c0a941c949c8ffafd849ff
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-15 16:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-06 4:30 [bug#51623] [PATCH] gnu: Add python-ta-lib Foo Chuan Wei
2021-11-11 6:07 ` Vinicius Monego
2021-11-15 5:25 ` [bug#51623] [PATCH v2] " Foo Chuan Wei
2021-11-15 16:54 ` bug#51623: " Guillaume Le Vaillant
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).