[bug#66747] [PATCH] gnu: font-google-noto: Update to 23.10.1.

[bug#66747] [PATCH] gnu: font-google-noto: Update to 23.10.1.

[Bruno Victal]

[1] indicates that [2] is the new _distribution_ upstream for Noto fonts.

[1]: <https://github.com/notofonts/noto-fonts>
[2]: <https://github.com/notofonts/notofonts.github.io>

* gnu/packages/fonts.scm (font-google-noto): Switch upstream url and
method. Update to 23.10.1, released at 2023-10-01T00:25:14Z.

Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
---
 gnu/packages/fonts.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 4254408e0f..eca84db7fe 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1015,15 +1015,16 @@ (define-public font-gnu-unifont
 (define-public font-google-noto
   (package
     (name "font-google-noto")
-    (version "20171025")
+    (version "23.10.1")
     (source
      (origin
-       (method url-fetch/zipbomb)
-       (uri (string-append "https://noto-website-2.storage.googleapis.com/"
-                           "pkgs/Noto-hinted.zip"))
-       (file-name (string-append name "-" version ".zip"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/notofonts/notofonts.github.io")
+             (commit (string-append "noto-monthly-release-" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "1bp42whyin7xcgmrbnfvz3rvd98xmxaz3ywqybbjmqzwaa9llyw3"))))
+        (base32 "1fab73hmr9gpmz6fmmxrb6m4g7lwhfzjx51g433pd1vp1srs8jgx"))))
     (build-system font-build-system)
     (home-page "https://www.google.com/get/noto/")
     (synopsis "Fonts to cover all languages")

base-commit: aabfddbe8bc16fa82067e88e7d79c8c1bc802414
-- 
2.41.0

[bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.

[Hilton Chain via Guix-patches via]

From: Bruno Victal <mirai@makinata.eu>

[1] indicates that [2] is the new _distribution_ upstream for Noto fonts.

[1]: <https://github.com/notofonts/noto-fonts>
[2]: <https://github.com/notofonts/notofonts.github.io>

* gnu/packages/fonts.scm (font-google-noto): Update to 23.11.1.
[source]<method>: Switch to git-fetch.

Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
---

Updated the patch since new version is out. :)

 gnu/packages/fonts.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 4254408e0f..22a42d227f 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1015,15 +1015,16 @@ (define-public font-gnu-unifont
 (define-public font-google-noto
   (package
     (name "font-google-noto")
-    (version "20171025")
+    (version "23.11.1")
     (source
      (origin
-       (method url-fetch/zipbomb)
-       (uri (string-append "https://noto-website-2.storage.googleapis.com/"
-                           "pkgs/Noto-hinted.zip"))
-       (file-name (string-append name "-" version ".zip"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/notofonts/notofonts.github.io")
+             (commit (string-append "noto-monthly-release-" version))))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "1bp42whyin7xcgmrbnfvz3rvd98xmxaz3ywqybbjmqzwaa9llyw3"))))
+        (base32 "0vvxhky35l4i0ha60yw0gj26f3v33hpf2zax17yyj16mww4cn4d8"))))
     (build-system font-build-system)
     (home-page "https://www.google.com/get/noto/")
     (synopsis "Fonts to cover all languages")

base-commit: f54f36b363a86bb033275e3a0594974d3d91bd53
-- 
2.41.0

bug#66747: [PATCH v2] gnu: font-google-noto: Update to 23.11.1.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]


Hilton Chain via Guix-patches via <guix-patches@gnu.org> writes:

> From: Bruno Victal <mirai@makinata.eu>
>
> [1] indicates that [2] is the new _distribution_ upstream for Noto fonts.
>
> [1]: <https://github.com/notofonts/noto-fonts>
> [2]: <https://github.com/notofonts/notofonts.github.io>
>
> * gnu/packages/fonts.scm (font-google-noto): Update to 23.11.1.
> [source]<method>: Switch to git-fetch.
>
> Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
> ---
>
> Updated the patch since new version is out. :)
>
>  gnu/packages/fonts.scm | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Thanks both, I've pushed this to master as
913d52952b0a893910657f88390f0d94a948edbc.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

[bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.

[Hugo Buddelmeijer]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Chris writes:

> Hilton Chain via Guix-patches via <guix-patches@gnu.org> writes:
>> From: Bruno Victal <mirai@makinata.eu>
>>
>> [1] indicates that [2] is the new _distribution_ upstream for Noto fonts.
>>
>> [1]: <https://github.com/notofonts/noto-fonts>
>> [2]: <https://github.com/notofonts/notofonts.github.io>
>>
>> * gnu/packages/fonts.scm (font-google-noto): Update to 23.11.1.
>> [source]<method>: Switch to git-fetch.
>>
>> Change-Id: I242710336ec81489f9800b68416f45c57d28b2bd
>> ---
>>
>> Updated the patch since new version is out. :)
>>
>>  gnu/packages/fonts.scm | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> Thanks both, I've pushed this to master as
> 913d52952b0a893910657f88390f0d94a948edbc.

This change seems to have broken the fonts in sway (wayland compositor).

This is my Sway status bar:

$ cat .config/sway/status.sh
DATE=$(date +'%Y-%m-%d %H:%M:%S')
BATTERY=$(cat /sys/class/power_supply/BAT0/capacity)
echo "🔋${BATTERY} 📅 ${DATE}"

Attached are screenshots of how it looks: goodtofu3.png with the old
font-google-noto, and badtofu3.png with the new font-google-noto.

Also looks wrong in foot, xterm, termite, uxterm, emacs, icecat, gimp;
only tested on sway.

I've not yet investigated the issue further. The next step for me
would be to install the old font-google-noto through an inferior
channel to to indeed verify that this change is indeed the culprit.

Hugo

[-- Attachment #2: badtofu3.png --]
[-- Type: image/png, Size: 16172 bytes --]

[-- Attachment #3: goodtofu3.png --]
[-- Type: image/png, Size: 16759 bytes --]

[bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.

[Bruno Victal]

[-- Attachment #1.1: Type: text/plain, Size: 864 bytes --]

Hi Hugo,

On 2023-11-29 14:01, Hugo Buddelmeijer wrote:
> This change seems to have broken the fonts in sway (wayland compositor).
> 
> This is my Sway status bar:
> 
> $ cat .config/sway/status.sh
> DATE=$(date +'%Y-%m-%d %H:%M:%S')
> BATTERY=$(cat /sys/class/power_supply/BAT0/capacity)
> echo "🔋${BATTERY} 📅 ${DATE}"

I didn't check with the old (and ancient, which had
U+2026 … HORIZONTAL ELLIPSIS broken) font-google-noto package though
I can confirm that I'm seeing TOFU when I lookup these characters
with 'gucharmap' command for 'Noto Sans Mono'.

Could you report this to upstream via [1] as indicated in the
README.md [2]?

[1]: <https://notofonts.github.io/reporter.html>
[2]: <https://github.com/notofonts/notofonts.github.io>

-- 
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[bug#66747] [PATCH v2] gnu: font-google-noto: Update to 23.11.1.

[Hugo Buddelmeijer]

It seems that the emoji are now in the font-google-noto-emoji package.
Installing that package worked for me: now the emoji are in color in
foot (wayland terminal), while earlier they only were in color in the
status bar.

So maybe everything works as intended. I was surprised to see tofu
because I expected that there would be 1 ultimate noto font, but maybe
that was naive.

On Wed, 29 Nov 2023 at 19:35, Bruno Victal <mirai@makinata.eu> wrote:
>
> Hi Hugo,
>
> On 2023-11-29 14:01, Hugo Buddelmeijer wrote:
> > This change seems to have broken the fonts in sway (wayland compositor).
> >
> > This is my Sway status bar:
> >
> > $ cat .config/sway/status.sh
> > DATE=$(date +'%Y-%m-%d %H:%M:%S')
> > BATTERY=$(cat /sys/class/power_supply/BAT0/capacity)
> > echo "🔋${BATTERY} 📅 ${DATE}"
>
> I didn't check with the old (and ancient, which had
> U+2026 … HORIZONTAL ELLIPSIS broken) font-google-noto package though
> I can confirm that I'm seeing TOFU when I lookup these characters
> with 'gucharmap' command for 'Noto Sans Mono'.
>
> Could you report this to upstream via [1] as indicated in the
> README.md [2]?
>
> [1]: <https://notofonts.github.io/reporter.html>
> [2]: <https://github.com/notofonts/notofonts.github.io>
>
> --
> Furthermore, I consider that nonfree software must be eradicated.
>
> Cheers,
> Bruno.
>