unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Zhu Zihao <all_but_last@163.com>
Cc: 55517@debbugs.gnu.org
Subject: [bug#55517] Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.)
Date: Fri, 20 May 2022 08:04:41 +0200	[thread overview]
Message-ID: <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> (raw)
In-Reply-To: <86leuw507n.fsf@163.com>

Am Freitag, dem 20.05.2022 um 11:52 +0800 schrieb Zhu Zihao:
> -     `(#:emacs ,emacs-no-x             ;module support is required

> +     (list
> +      #:emacs emacs-no-x
You do drop that argument in the second commit, but I think we ought to
still keep the comment in this one.  Do add a space between ';' and
"module", though.

> gnu: emacs-magit: Drop the libgit backend.
> 
> Drop the libgit backend for following reasons:
> 
> 1. The libgit backend of Magitis very incomplete. There's almost no
> benefits, but extra maintenance efforts.
> 
> 2. The libgit backend of Magit can be considered as an extra package.
> And it's still in Proof-Of-Concept status so its quaility doesn't
> satisfy the requirement of Guix package.
I'd rather write this as follows:

> gnu: emacs-magit: Drop the libgit backend.
> 
> The libgit backend currently provides next to no features, but
> demands extra maintenance overhead.  It is in fact not a usable
> backend; thus let's not use it.

The "extra package" thing is imho not so correct from observing the
Makefile (even if there's an extra -pkg.el), so let's wait until
upstream makes that clearer.

Other than that LGTM.





  reply	other threads:[~2022-05-20  6:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  5:08 [bug#55517] [PATCH]: gnu: emacs-magit: Drop the libgit backend Zhu Zihao
     [not found] ` <handler.55517.B.165293698432676.ack@debbugs.gnu.org>
2022-05-19  5:13   ` [bug#55517] Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Zhu Zihao
2022-05-19  6:01     ` Liliana Marie Prikler
2022-05-20  3:52       ` Zhu Zihao
2022-05-20  6:04         ` Liliana Marie Prikler [this message]
2022-05-22  9:46           ` Zhu Zihao
2022-05-23  6:46             ` Liliana Marie Prikler
2022-05-28  2:11               ` Zhu Zihao
2022-05-28  6:56                 ` bug#55517: " Liliana Marie Prikler
2022-05-21  2:13     ` [bug#55517] [PATCH]: gnu: emacs-magit: Drop the libgit backend Maxim Cournoyer
2022-05-21  3:45       ` Zhu Zihao
2022-05-22  0:46         ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at \
    --to=liliana.prikler@ist.tugraz.at \
    --cc=55517@debbugs.gnu.org \
    --cc=all_but_last@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).