From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KLa6EcUvh2LUwQAAbAwnHQ (envelope-from ) for ; Fri, 20 May 2022 08:05:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YG5/EcUvh2K3AAAAauVa8A (envelope-from ) for ; Fri, 20 May 2022 08:05:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC3281546E for ; Fri, 20 May 2022 08:05:56 +0200 (CEST) Received: from localhost ([::1]:47436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrvlr-00047j-F8 for larch@yhetil.org; Fri, 20 May 2022 02:05:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrvl2-00047S-2V for guix-patches@gnu.org; Fri, 20 May 2022 02:05:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrvl1-0001Pe-PH for guix-patches@gnu.org; Fri, 20 May 2022 02:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nrvl0-0004uM-KJ for guix-patches@gnu.org; Fri, 20 May 2022 02:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55517] Acknowledgement ([PATCH]: gnu: emacs-magit: Drop the libgit backend.) Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 May 2022 06:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55517 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zhu Zihao Cc: 55517@debbugs.gnu.org Received: via spool by 55517-submit@debbugs.gnu.org id=B55517.165302668618838 (code B ref 55517); Fri, 20 May 2022 06:05:02 +0000 Received: (at 55517) by debbugs.gnu.org; 20 May 2022 06:04:46 +0000 Received: from localhost ([127.0.0.1]:37311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrvkk-0004tm-5m for submit@debbugs.gnu.org; Fri, 20 May 2022 02:04:46 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:8926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrvki-0004td-6S for 55517@debbugs.gnu.org; Fri, 20 May 2022 02:04:45 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4L4GQc29Dxz3xqF; Fri, 20 May 2022 08:04:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1653026680; bh=qXWiS+3uD7WthKDWZMH032M28Q//Avd8lbFlcRwpnao=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=HFyGcUl8fhBCa7z7Pze75ZN+37x2wCvqMnmqxDjXi52F6EdMd6+CXyyUZWUXqrKg8 zUzyF/EOpDIBuJyo9CZjeK/cVq9MCv5tRXaUqNV3gQMZYx9PhP6f6gpYTVs0Fvhf0b oNQGE4mehleDXdAu3Wy0dXbgVNz/Wy8DBVq/LnaM= Message-ID: <07286c2df8ffb434e353bdde7bf8d427e9d7d9b2.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Fri, 20 May 2022 08:04:41 +0200 In-Reply-To: <86leuw507n.fsf@163.com> References: <868rqykt19.fsf@163.com> <86sfp6je99.fsf@163.com> <86leuw507n.fsf@163.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653026757; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qXWiS+3uD7WthKDWZMH032M28Q//Avd8lbFlcRwpnao=; b=BbNSgGkL3MrnEmcbKqAJmx8rg/ZC/czcTcOoDRAjKtDuJTjWLT6tM5KrEbHEq8OpxoY2hs 1RhbCpcEWpfaPW2kqVJyKsU3AoObfxt6fvvd6fC0BsJJch24ykBUGatao+E9dyq6BWQ/z1 Ayg2NW8B53PXPgnUehgWN628uOo02kJ6rZsVm4mKE2RfhmLvuPF9ygxF8F3cPWNO2WhdHG +az8TTQqU2W4mGEBJAQg0eHM4Idlv7KvtlH2z3Xi1AFFpKUWEkRLQ+uh+bOczukKqfIdJX ySzZB4LRsOz3ARmXe7V6xyYTICLkXetyIHWtiCsY8Y+IuL8QAcL+/WCS89QjSQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653026757; a=rsa-sha256; cv=none; b=nAveszawHO2sdyjYulFeLJnNj+U4ti63L4/WEjFQcp7uPp0WKv6d06Sfu/fUgNnW50l6QW 4m/ROn1TkgWU62WJZpUtfdPzVOhwXLSxeVXzamJfIlJruZn0pIXhs7+4sB3Yx+IAuR01ep 3UWR+y+fFgIUfS+dz1e+Xo4AuktLsjb/cO0nQmsq7sYG1lrQymDRj+/3i1wpt/x6m7HhZH KFldEwN9EHEr4L/lDShZcuIWiKQDwCe3xtw/qUdnApngbme2r5KPsVc6Xg+zBqoFqOnEU6 Xz+dkQgmHaAz474xId/ClY+2XOoJiaMuqdAA7TnvJKWcnlOwevDprclbsXEIHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=HFyGcUl8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.46 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=HFyGcUl8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CC3281546E X-Spam-Score: 6.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: YtvNZYR973rx Am Freitag, dem 20.05.2022 um 11:52 +0800 schrieb Zhu Zihao: > - `(#:emacs ,emacs-no-x ;module support is required > + (list > + #:emacs emacs-no-x You do drop that argument in the second commit, but I think we ought to still keep the comment in this one. Do add a space between ';' and "module", though. > gnu: emacs-magit: Drop the libgit backend. > > Drop the libgit backend for following reasons: > > 1. The libgit backend of Magitis very incomplete. There's almost no > benefits, but extra maintenance efforts. > > 2. The libgit backend of Magit can be considered as an extra package. > And it's still in Proof-Of-Concept status so its quaility doesn't > satisfy the requirement of Guix package. I'd rather write this as follows: > gnu: emacs-magit: Drop the libgit backend. > > The libgit backend currently provides next to no features, but > demands extra maintenance overhead. It is in fact not a usable > backend; thus let's not use it. The "extra package" thing is imho not so correct from observing the Makefile (even if there's an extra -pkg.el), so let's wait until upstream makes that clearer. Other than that LGTM.