[bug#54250] [PATCH] gnu: xdotool: Update to 3.20211022.1.

[bug#54250] [PATCH] gnu: xdotool: Update to 3.20211022.1.

[Jai Vetrivelan]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-xdotool-Update-to-3.20211022.1.patch --]
[-- Type: text/patch, Size: 1271 bytes --]

From 1040dbabc8cb5af1c88262492cf74cb74c859caa Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Sat, 5 Mar 2022 11:16:25 +0530
Subject: [PATCH] gnu: xdotool: Update to 3.20211022.1.

* gnu/packages/xdisorg.scm (xdotool): Update to 3.20211022.1.
---
 gnu/packages/xdisorg.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 42452d0721..82083cb572 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -492,7 +492,7 @@ (define-public libfakekey
 (define-public xdotool
   (package
     (name "xdotool")
-    (version "3.20160805.1")
+    (version "3.20211022.1")
     (source
       (origin
         (method url-fetch)
@@ -501,7 +501,7 @@ (define-public xdotool
               version "/xdotool-" version ".tar.gz"))
         (sha256
           (base32
-           "1a6c1zr86zb53352yxv104l76l8x21gfl2bgw6h21iphxpv5zgim"))))
+           "1nlsbwsdsgys607f00sc8xgb7l7cdzsb14avsg5fly3dvv7zmw4n"))))
     (build-system gnu-build-system)
     (arguments
      '(#:tests? #f ; Test suite requires a lot of black magic

base-commit: 97065f9fe3da74adab54b70e28bd2cd59c06ee07
prerequisite-patch-id: 112e00ce191deb18c3866dc5f17e4c761a3b19af
-- 
2.34.0

[bug#54250] [PATCH] gnu: xdotool: Update to 3.20211022.1.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Jai Vetrivelan schreef op za 05-03-2022 om 11:34 [+0530]:
> +    (version "3.20211022.1")
>      (source
>        (origin
>          (method url-fetch)
> @@ -501,7 +501,7 @@ (define-public xdotool
>                version "/xdotool-" version ".tar.gz"))
>          (sha256
>            (base32
> -          
> "1a6c1zr86zb53352yxv104l76l8x21gfl2bgw6h21iphxpv5zgim"))))
> +          
> "1nlsbwsdsgys607f00sc8xgb7l7cdzsb14avsg5fly3dvv7zmw4n"))))
>      (build-system gnu-build-system)

At least on the master branch, the return value of calloc does not
appear to be always checked, e.g. xdo_search.c line 38, xdo.c line 1334
and 1389.  Could this be fixed?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#54250: [PATCH] gnu: xdotool: Update to 3.20211022.1.

[Nicolas Goaziou]

Hello,

Jai Vetrivelan <jaivetrivelan@gmail.com> writes:

> From 1040dbabc8cb5af1c88262492cf74cb74c859caa Mon Sep 17 00:00:00 2001
> From: Jai Vetrivelan <jaivetrivelan@gmail.com>
> Date: Sat, 5 Mar 2022 11:16:25 +0530
> Subject: [PATCH] gnu: xdotool: Update to 3.20211022.1.

Applied. Thank

Regards,
-- 
Nicolas Goaziou

[bug#54250] [PATCH] gnu: xdotool: Update to 3.20211022.1.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Nicolas Goaziou schreef op vr 11-03-2022 om 01:46 [+0100]:
> Applied. Thank

I don't think the ignoring of the return value of calloc (xdo_search.c,
line 38, and some other locations) have been reported upstream or fixed
yet.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#54250] [PATCH] gnu: xdotool: Update to 3.20211022.1.

[Nicolas Goaziou]

Hello,

Maxime Devos <maximedevos@telenet.be> writes:

> Nicolas Goaziou schreef op vr 11-03-2022 om 01:46 [+0100]:
>> Applied. Thank
>
> I don't think the ignoring of the return value of calloc (xdo_search.c,
> line 38, and some other locations) have been reported upstream or fixed
> yet.

I don't see it as a deal breaker, as explained in another answer. Of
course, it would bring some bonus points to Jai Vetrivelan if they just
did one or another.

Regards,
-- 
Nicolas Goaziou