From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add vcflib.
Date: Wed, 20 Apr 2016 14:46:21 +0200 [thread overview]
Message-ID: <idjwpnsa1nm.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <878u1aa62m.fsf@gnu.org>
Roel Janssen <roel@gnu.org> writes:
> From dfc9b373bbce0f36882407cec47440a0a44c78d1 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 22 Mar 2016 14:59:05 +0100
> Subject: [PATCH 1/8] gnu: Add tabixpp.
> * gnu/packages/bioinformatics.scm (tabixpp): New variable.
> ---
> gnu/packages/bioinformatics.scm | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index 281bd1f..6792be9 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -4791,3 +4791,42 @@ negative binomial distribution to model the read counts among the samples in
> the same group, and look for consistent differences between ChIP and control
> group or two ChIP groups run under different conditions.")
> (license license:gpl3+)))
> +
> +(define-public tabixpp
> + (package
> + (name "tabixpp")
> + (version "1.0.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/ekg/tabixpp/archive/v"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32 "1s0lgks7qlvlhvcjhi2wm18nnza1bwcnic44ij7z8wfg88h4ivwn"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("htslib" ,htslib)
> + ("zlib" ,zlib)))
> + (arguments
> + `(#:tests? #f ; There are no tests to run.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; There is no configure phase.
> + ;; Modify the build phase to use the separately packaged htslib.
> + (replace 'build
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((htslib-ref (assoc-ref inputs "htslib")))
> + (zero?
> + (system* "make"
> + (string-append "HTS_LIB=" htslib-ref "/lib/libhts.a")
> + "HTS_HEADERS=" ; Do not check for local htslib headers.
> + (string-append "LIBPATH=-L. -L" htslib-ref
> "/include"))))))
Is this really necessary or could you use make-flags instead? That
would be the preferred way of doing this rather than replacing the build
phase.
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (install-file "tabix++" bin)))))))
> + (home-page "https://github.com/ekg/tabixpp")
> + (synopsis "C++ wrapper around tabix project")
“tabix” or “Tabix”?
> + (description "This is a C++ wrapper around the Tabix project which abstracts
> +some of the details of opening and jumping in tabix-indexed files.")
> + (license license:expat)))
“tabix” or “Tabix”?
Could you please send an updated patch?
~~ Ricardo
next prev parent reply other threads:[~2016-04-20 12:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 15:24 [PATCH] Add vcflib Roel Janssen
2016-03-23 13:49 ` Ricardo Wurmus
2016-04-20 12:39 ` Roel Janssen
2016-04-20 12:46 ` Ricardo Wurmus [this message]
2016-04-22 7:24 ` Roel Janssen
2016-04-26 14:47 ` Ricardo Wurmus
2016-04-26 17:31 ` Roel Janssen
2017-01-16 21:59 ` Ricardo Wurmus
2016-04-20 12:49 ` Ricardo Wurmus
2016-04-26 21:50 ` Roel Janssen
2017-01-16 22:04 ` Ricardo Wurmus
2016-04-20 12:53 ` Ricardo Wurmus
2016-04-22 7:40 ` Roel Janssen
2016-04-26 14:47 ` Ricardo Wurmus
2016-04-26 17:37 ` Roel Janssen
2017-01-16 21:56 ` Ricardo Wurmus
2016-04-20 12:56 ` Ricardo Wurmus
2016-04-20 12:58 ` Ricardo Wurmus
2016-04-22 8:04 ` Roel Janssen
2016-04-22 11:27 ` Ricardo Wurmus
2016-04-25 9:20 ` Roel Janssen
2016-04-26 14:42 ` Ricardo Wurmus
2016-04-20 13:06 ` Ricardo Wurmus
2016-04-20 13:08 ` Ricardo Wurmus
2016-04-26 17:50 ` Roel Janssen
2016-04-26 17:51 ` Roel Janssen
2017-01-16 21:54 ` Ricardo Wurmus
2017-01-17 21:57 ` Roel Janssen
2017-01-18 8:24 ` Ricardo Wurmus
2016-04-20 13:18 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjwpnsa1nm.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).