From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add vcflib.
Date: Wed, 20 Apr 2016 14:53:04 +0200 [thread overview]
Message-ID: <idjtwiwa1cf.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <878u1aa62m.fsf@gnu.org>
Roel Janssen <roel@gnu.org> writes:
> From edcf3132dca6c3e86439710892870285377adbb2 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 22 Mar 2016 15:07:47 +0100
> Subject: [PATCH 3/8] gnu: Add multichoose.
> * gnu/packages/bioinformatics.scm (multichoose): New variable.
> ---
> gnu/packages/bioinformatics.scm | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index fa7ba24..9465d56 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -4861,3 +4861,38 @@ algorithm.")
> ;; this program is a submodule, is licensed MIT, which is the same as
> ;; the Expat license.
> (license (list license:gpl2 license:expat)))))
> +
> +(define-public multichoose
> + (package
> + (name "multichoose")
> + (version "1.0.3")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/ekg/multichoose/archive/v"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32 "0xy86vvr3qrs4l81qis7ia1q2hnqv0xcb4a1n60smxbhqqis5w3l"))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("python" ,python-2)
> + ("node" ,node)))
> + (arguments
> + `(#:tests? #f ; There are no tests to run.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; There is no configure phase.
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (install-file "multichoose" bin)
> + (install-file "multipermute" bin)))))))
Nitpick: normally, we place the arguments right below the
“build-system”. The “native-inputs” then follow after “arguments”.
> + (home-page "https://github.com/ekg/multichoose")
> + (synopsis "Library for efficient loopless multiset combination generation
> +algorithm")
This synopsis is a bit long. Maybe drop “efficient”? (Most projects
include “efficient” or “fast” in their descriptions, so it isn’t very
useful in a synopsis.)
> + (description "A library implements an efficient loopless multiset
> +combination generation algorithm which is (approximately) described in
> +\"Loopless algorithms for generating permutations, combinations, and other
> +combinatorial configurations.\" G Ehrlich - Journal of the ACM (JACM),
> +1973. (Algorithm 7.)")
“A library”? How about “This package provides a library implementing...”
> + (license license:expat)))
~~ Ricardo
next prev parent reply other threads:[~2016-04-20 12:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 15:24 [PATCH] Add vcflib Roel Janssen
2016-03-23 13:49 ` Ricardo Wurmus
2016-04-20 12:39 ` Roel Janssen
2016-04-20 12:46 ` Ricardo Wurmus
2016-04-22 7:24 ` Roel Janssen
2016-04-26 14:47 ` Ricardo Wurmus
2016-04-26 17:31 ` Roel Janssen
2017-01-16 21:59 ` Ricardo Wurmus
2016-04-20 12:49 ` Ricardo Wurmus
2016-04-26 21:50 ` Roel Janssen
2017-01-16 22:04 ` Ricardo Wurmus
2016-04-20 12:53 ` Ricardo Wurmus [this message]
2016-04-22 7:40 ` Roel Janssen
2016-04-26 14:47 ` Ricardo Wurmus
2016-04-26 17:37 ` Roel Janssen
2017-01-16 21:56 ` Ricardo Wurmus
2016-04-20 12:56 ` Ricardo Wurmus
2016-04-20 12:58 ` Ricardo Wurmus
2016-04-22 8:04 ` Roel Janssen
2016-04-22 11:27 ` Ricardo Wurmus
2016-04-25 9:20 ` Roel Janssen
2016-04-26 14:42 ` Ricardo Wurmus
2016-04-20 13:06 ` Ricardo Wurmus
2016-04-20 13:08 ` Ricardo Wurmus
2016-04-26 17:50 ` Roel Janssen
2016-04-26 17:51 ` Roel Janssen
2017-01-16 21:54 ` Ricardo Wurmus
2017-01-17 21:57 ` Roel Janssen
2017-01-18 8:24 ` Ricardo Wurmus
2016-04-20 13:18 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjtwiwa1cf.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).