Re: [PATCH] Various samtools patches.

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

Ludovic Courtès writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> The third patch adds the most recent version of the 0.1 line of
>> samtools.  The input and output formats differ greatly from that used
>> and produced by samtools 1.x (which has already been packaged as
>> "samtools") and is still used in many bioinformatics pipelines.
>
> Could you write it as a comment just below (define samtools-0.1 ?
> That way people will know why it matters to keep both.

Done.

> Also, if both versions can be parallel-installed, it may be nice to give
> them a different ‘name’ field (say ‘sametools0’ for the older one.)  If
> they’re not, it’s fine this way.

Unfortunately, they cannot both be installed in parallel into the same
profile as they both provide ./bin/samtools and an unversioned libbam.a.

> Otherwise all 3 patches LGTM!

Thank you for the review!
I just pushed them with the above-mentioned change.

~~ Ricardo