From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Various samtools patches. Date: Mon, 4 May 2015 10:30:32 +0200 Message-ID: References: <87k2wp311k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpBrX-00033X-1m for guix-devel@gnu.org; Mon, 04 May 2015 04:36:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpBrT-0001m1-J1 for guix-devel@gnu.org; Mon, 04 May 2015 04:36:26 -0400 In-Reply-To: <87k2wp311k.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel Ludovic Court=C3=A8s writes: > Ricardo Wurmus skribis: > >> The third patch adds the most recent version of the 0.1 line of >> samtools. The input and output formats differ greatly from that used >> and produced by samtools 1.x (which has already been packaged as >> "samtools") and is still used in many bioinformatics pipelines. > > Could you write it as a comment just below (define samtools-0.1 ? > That way people will know why it matters to keep both. Done. > Also, if both versions can be parallel-installed, it may be nice to giv= e > them a different =E2=80=98name=E2=80=99 field (say =E2=80=98sametools0=E2= =80=99 for the older one.) If > they=E2=80=99re not, it=E2=80=99s fine this way. Unfortunately, they cannot both be installed in parallel into the same profile as they both provide ./bin/samtools and an unversioned libbam.a. > Otherwise all 3 patches LGTM! Thank you for the review! I just pushed them with the above-mentioned change. ~~ Ricardo