My first package

My first package

[Tobias Platen]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Hello,

I've created my first package for guix, the sekai speech synthesis
toolkit which I use mainly for producing singing voice with lilypond.
I'll also plan a talk at the gnu hackers meeting how I make Desktop
Music using the Guix System. Two more packages will follow next.

Tobias Alexandra

[-- Attachment #2: guix-sekai.diff --]
[-- Type: text/x-patch, Size: 2504 bytes --]

diff --git a/gnu/packages/speech.scm b/gnu/packages/speech.scm
index 042c157e43..cc0b03d110 100644
--- a/gnu/packages/speech.scm
+++ b/gnu/packages/speech.scm
@@ -31,11 +31,14 @@ (define-module (gnu packages speech)
   #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system cmake)
   #:use-module (gnu packages)
   #:use-module (gnu packages audio)
+  #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)            ;for 'which'
   #:use-module (gnu packages bison)
+  #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages emacs)
@@ -44,15 +47,18 @@ (define-module (gnu packages speech)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages serialization)
   #:use-module (gnu packages swig)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils))
 
+
 (define-public flite
   (package
     (name "flite")
@@ -318,6 +324,33 @@ (define-public sonic
     (home-page "https://github.com/waywardgeek/sonic")
     (license license:asl2.0)))
 
+(define-public sekai
+  (package
+    (name "sekai")
+    (version "0.6.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://notabug.org/isengaara/sekai")
+                    (commit "0.6rc0")))
+              (sha256
+               (base32
+                "0j55pipx3hcp0xl4v0d72fdwysnz9a9a40x65a9lxpl4k6wyp4nm"))))              
+    (build-system cmake-build-system)
+    (arguments '(#:tests? #f))
+    (inputs `(("fftw" ,fftw)
+              ("libsndfile",libsndfile)
+	      ("pkg-config",pkg-config)
+	      ("gsl",gsl)
+	      ("jsoncpp",jsoncpp)
+	      ("boost",boost)
+	      ("jack" ,jack-1)
+	    ))
+    (synopsis "The SEKAI speech toolkit")
+    (description "The future of Singing Voice Synthesis using the Excitation plus Resonances model.")
+    (home-page "https://qtau.de/sekai")
+    (license license:agpl3+)))
+
 (define-public festival
   (package
     (name "festival")

Re: My first package

[zimoun]

Hi Tobias,

Sorry for this late reply.

On Thu, 15 Sep 2022 at 09:35, Tobias Platen <guix@platen-software.de> wrote:

> I've created my first package for guix, the sekai speech synthesis
> toolkit which I use mainly for producing singing voice with lilypond.
> I'll also plan a talk at the gnu hackers meeting how I make Desktop
> Music using the Guix System. Two more packages will follow next.

Cool!  Thank you for your contribution.

For easing the merge, could you send to guix-patches@gnu.org this patch
using git-format-patch with a commit message.  Well, please give a look
at the section « Submitting Patches » [1] from the manual. :-)


1: <https://guix.gnu.org/manual/devel/en/guix.html#Submitting-Patches>


Two minor comment starting the review. :-)

>    #:use-module (gnu packages textutils))
>  
> +

Here, you introduced an extra line.

> +(define-public sekai
> +  (package
> +    (name "sekai")
> +    (version "0.6.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://notabug.org/isengaara/sekai")
> +                    (commit "0.6rc0")))
> +              (sha256
> +               (base32
> +                "0j55pipx3hcp0xl4v0d72fdwysnz9a9a40x65a9lxpl4k6wyp4nm"))))              
> +    (build-system cmake-build-system)
> +    (arguments '(#:tests? #f))

The tests are disallowed.  Any specific reason?  If yes, the usual
practise is to add a one line comment.  For example,

       (arguments '(#:tests? #f))    ; no tests


> +    (inputs `(("fftw" ,fftw)
> +              ("libsndfile",libsndfile)
> +	      ("pkg-config",pkg-config)
> +	      ("gsl",gsl)
> +	      ("jsoncpp",jsoncpp)
> +	      ("boost",boost)
> +	      ("jack" ,jack-1)
> +	    ))

Now, you can use directly,

    (inputs (list fftw
                  libsndfile
                  pkg-config
                  gsl
                  jsoncpp
                  boost
                  jack-1))

Cheers,
simon