Re: [PATCH] gnu: Add tvtime.

[Eric Bavier <bavier@member.fsf.org>]

On 2015-04-28 15:18, Alex Kost wrote:
> From dcc331e7ab3fd0687c5a4ef8f084bc0bf4ca1cef Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Tue, 28 Apr 2015 22:21:37 +0300
> Subject: [PATCH] gnu: Add tvtime.
> 
> * gnu/packages/tvtime.scm,
>   gnu/packages/patches/tvtime-gcc41.patch,
>   gnu/packages/patches/tvtime-pngoutput.patch,
>   gnu/packages/patches/tvtime-videodev2.patch,
>   gnu/packages/patches/tvtime-xmltv.patch: New files.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add package.
>   (dist_patch_DATA): Add patches.

Perhaps we could name the file "tv.scm", in anticipation of other 
TV-related code?

> +    (inputs
> +     `(("libx11"      ,libx11)
> +       ("libxt"       ,libxt)
> +       ("libxtst"     ,libxtst)
> +       ("libxinerama" ,libxinerama)
> +       ("libxv"       ,libxv)
> +       ("libxxf86vm"  ,libxxf86vm)
> +       ("libpng"      ,libpng)
> +       ("libxml2"     ,libxml2)
> +       ("freetype"    ,freetype)
> +       ("zlib"        ,zlib)))

I think we were lately trying to stay away from aligning inputs like 
this (ISTR Ludo requesting it not be done on some other patch reviews).  
Not sure where the consensus is yet.

> +    (synopsis "High quality television application")

How about "Television viewer"?

Otherwise the rest look good to me.