From: Alex Kost <alezost@gmail.com>
To: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add tvtime.
Date: Thu, 07 May 2015 18:51:03 +0300 [thread overview]
Message-ID: <87y4l0s7x4.fsf@gmail.com> (raw)
In-Reply-To: <87bni7e0vu.fsf@gmail.com> (Alex Kost's message of "Wed, 29 Apr 2015 12:31:49 +0300")
Alex Kost (2015-04-29 12:31 +0300) wrote:
> Eric Bavier (2015-04-29 01:14 +0300) wrote:
>
>> On 2015-04-28 15:18, Alex Kost wrote:
>>> From dcc331e7ab3fd0687c5a4ef8f084bc0bf4ca1cef Mon Sep 17 00:00:00 2001
>>> From: Alex Kost <alezost@gmail.com>
>>> Date: Tue, 28 Apr 2015 22:21:37 +0300
>>> Subject: [PATCH] gnu: Add tvtime.
>>>
>>> * gnu/packages/tvtime.scm,
>>> gnu/packages/patches/tvtime-gcc41.patch,
>>> gnu/packages/patches/tvtime-pngoutput.patch,
>>> gnu/packages/patches/tvtime-videodev2.patch,
>>> gnu/packages/patches/tvtime-xmltv.patch: New files.
>>> * gnu-system.am (GNU_SYSTEM_MODULES): Add package.
>>> (dist_patch_DATA): Add patches.
>>
>> Perhaps we could name the file "tv.scm", in anticipation of other
>> TV-related code?
>
> Indeed, I think it would be better, thanks!
>
>>> + (inputs
>>> + `(("libx11" ,libx11)
>>> + ("libxt" ,libxt)
>>> + ("libxtst" ,libxtst)
>>> + ("libxinerama" ,libxinerama)
>>> + ("libxv" ,libxv)
>>> + ("libxxf86vm" ,libxxf86vm)
>>> + ("libpng" ,libpng)
>>> + ("libxml2" ,libxml2)
>>> + ("freetype" ,freetype)
>>> + ("zlib" ,zlib)))
>>
>> I think we were lately trying to stay away from aligning inputs like
>> this (ISTR Ludo requesting it not be done on some other patch reviews).
>> Not sure where the consensus is yet.
>
> OK, I'm going to remove the aligning.
>
>>> + (synopsis "High quality television application")
>>
>> How about "Television viewer"?
>
> I don't mind. Synopsis/description is always the hardest part for me :-)
>
>> Otherwise the rest look good to me.
>
> Thanks for reviewing.
I'm going to commit it (taking into account Eric's notes), If no one
objects.
--
Alex
prev parent reply other threads:[~2015-05-07 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 20:18 [PATCH] gnu: Add tvtime Alex Kost
2015-04-28 22:14 ` Eric Bavier
2015-04-29 9:31 ` Alex Kost
2015-05-07 15:51 ` Alex Kost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4l0s7x4.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).