From: Jack Hill <jackhill@jackhill.us>
To: guix-devel@gnu.org
Subject: Go importer and packages with version flags
Date: Mon, 27 Sep 2021 17:51:35 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2109271729160.4243@marsh.hcoop.net> (raw)
Hi Guix,
While I was was working with the go importer today, it suggested I package
go-github-com-russross-blackfriday-v2. Fair enough, except we already have
a package for go-github-com-russross-blackfriday. The packages differ in
their version (2.1.0 verses 2.0.1), their imputs (the imported package
definition is missing the inputs and native-inputs that we have in the
Guix package), and the presense of the v2 versioning disambiguation tag.
I was puzzled by this last bit since both packages seem to compatible with
the v2 API. If I replace the exising package definition with the one
suggested by the importer (with one small tweak, I needed to add a /v2 to
the #:unpack-path) all the packages reported by `guix refresh -l
go-github-com-russross-blackfriday` build sucessfully.
What's the path forward here? I'm thinking I should update our blackfriday
backage to the 2.1.0 release, but leave the inputs and native inputs. I'm
less sure about what to do about the v2 tag. Should I switch over the
package and varialbe name? What do we usually do?
Best,
Jack
The package the importer suggested:
```
(define-public go-github-com-russross-blackfriday-v2
(package
(name "go-github-com-russross-blackfriday-v2")
(version "2.1.0")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/russross/blackfriday")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32 "0d1rg1drrfmabilqjjayklsz5d0n3hkf979sr3wsrw92bfbkivs7"))))
(build-system go-build-system)
(arguments
'(#:import-path
"github.com/russross/blackfriday/v2"
#:unpack-path
"github.com/russross/blackfriday"))
(home-page "https://github.com/russross/blackfriday")
(synopsis "Blackfriday")
(description "Package blackfriday is a markdown processor.
")
(license license:bsd-2)))
```
Our existing package:
```
(define-public go-github-com-russross-blackfriday
(package
(name "go-github-com-russross-blackfriday")
(version "2.0.1")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/russross/blackfriday")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"0nlz7isdd4rgnwzs68499hlwicxz34j2k2a0b8jy0y7ycd2bcr5j"))))
(build-system go-build-system)
(arguments
'(#:import-path "github.com/russross/blackfriday"))
(propagated-inputs
`(("go-github-com-shurcool-sanitized-anchor-name"
,go-github-com-shurcool-sanitized-anchor-name)))
(native-inputs
`(("go-github-com-pmezard-go-difflib" ,go-github-com-pmezard-go-difflib)))
(home-page "https://github.com/russross/blackfriday")
(synopsis "Markdown processor in Go")
(description "Blackfriday is a Markdown processor in Go.")
(license license:bsd-2)))
```
next reply other threads:[~2021-09-27 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 21:51 Jack Hill [this message]
2021-09-28 2:53 ` Go importer and packages with version flags Katherine Cox-Buday
2021-09-28 5:47 ` Sarah Morgensen
2021-09-28 17:08 ` Katherine Cox-Buday
2021-09-30 3:17 ` Sarah Morgensen
2021-09-30 15:31 ` Could the Go importer use the Go toolchain? (was Re: Go importer and packages with version flags) Katherine Cox-Buday
2021-10-02 20:09 ` raingloom
2022-10-06 15:01 ` François
2022-10-22 13:23 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2109271729160.4243@marsh.hcoop.net \
--to=jackhill@jackhill.us \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).