From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id l1+TH/Y8UmFAxwAAgWs5BA (envelope-from ) for ; Mon, 27 Sep 2021 23:51:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aPy8GvY8UmGTBQAA1q6Kng (envelope-from ) for ; Mon, 27 Sep 2021 21:51:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24BE62DABD for ; Mon, 27 Sep 2021 23:51:50 +0200 (CEST) Received: from localhost ([::1]:52766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUyXN-0000yp-8k for larch@yhetil.org; Mon, 27 Sep 2021 17:51:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUyXD-0000yf-9l for guix-devel@gnu.org; Mon, 27 Sep 2021 17:51:39 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:39404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUyXB-0008Ci-Eq for guix-devel@gnu.org; Mon, 27 Sep 2021 17:51:38 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUyX9-0002zI-Uv for guix-devel@gnu.org; Mon, 27 Sep 2021 17:51:35 -0400 Date: Mon, 27 Sep 2021 17:51:35 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: guix-devel@gnu.org Subject: Go importer and packages with version flags Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632779510; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=sFY25Ci9eOfVALrq5eK91fxhX/hTzILWh0acrNEG+9g=; b=irGGvgEfJYxERYP4xJkNjd10J/1INrejI3LTBcDINw8LKsFSh9F3akt8HNBpdbeWoKB7fX tO5lxYVQ+Jr/SdmJzvgJbd2soDF8/5ovKI/yU9lahPMvNN88mRytgIfmXrs8hDUe8XI+0Y SdvaaP9IsYcbAYk1Y8PiY2EPLYVPNI2GVadwTR5W/Z4jnHtgm994OW0rOUuzKN/cB6kfwP iGaZB9rKw8BB0RrYp73d8PhvD7P313Na2ojrr4mT5nh6MiJj19ANNgvPAj5gPXImfcUKcP x1GR5cNsrWD+9mL3d7SOKIj+8vGutWjlqM7cLBmtLPvfI+Dx+8CHFHX3B8NdnQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632779510; a=rsa-sha256; cv=none; b=b9fz0XmnYWJt8h2tFwZnvv+GYmp2UaY/dzpZZVzLDL6EpiCv2bHD09Vgl6TVm+xESj00cC vf2gXw94MZD70UjtTP06pXYLnh9gHWl/QsnjhpOuZeqc/WV0BKj07SNfjEBzXMZtjpNhGv VbOeXRU9NEXvEQZpFHS5XK00AC1WWj5dUNEwEpyDIVPTdzw0n907P51cLN6fmkiQ3yM43U CykX+vUtLITgX2plA7PKre+dLMCqJ9CRAB8u6PDPRhCZjNBVudrtv7j6rjmaVgEq6eM0ku 7F4tYB1zfs0RULi8FFCPpF7OGAjAglMxspkl8g2GgwL/7Y/uoHc3bItEWLO/9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.79 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 24BE62DABD X-Spam-Score: -2.79 X-Migadu-Scanner: scn1.migadu.com X-TUID: zCgeKtEn7nGb Hi Guix, While I was was working with the go importer today, it suggested I package go-github-com-russross-blackfriday-v2. Fair enough, except we already have a package for go-github-com-russross-blackfriday. The packages differ in their version (2.1.0 verses 2.0.1), their imputs (the imported package definition is missing the inputs and native-inputs that we have in the Guix package), and the presense of the v2 versioning disambiguation tag. I was puzzled by this last bit since both packages seem to compatible with the v2 API. If I replace the exising package definition with the one suggested by the importer (with one small tweak, I needed to add a /v2 to the #:unpack-path) all the packages reported by `guix refresh -l go-github-com-russross-blackfriday` build sucessfully. What's the path forward here? I'm thinking I should update our blackfriday backage to the 2.1.0 release, but leave the inputs and native inputs. I'm less sure about what to do about the v2 tag. Should I switch over the package and varialbe name? What do we usually do? Best, Jack The package the importer suggested: ``` (define-public go-github-com-russross-blackfriday-v2 (package (name "go-github-com-russross-blackfriday-v2") (version "2.1.0") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/russross/blackfriday") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "0d1rg1drrfmabilqjjayklsz5d0n3hkf979sr3wsrw92bfbkivs7")))) (build-system go-build-system) (arguments '(#:import-path "github.com/russross/blackfriday/v2" #:unpack-path "github.com/russross/blackfriday")) (home-page "https://github.com/russross/blackfriday") (synopsis "Blackfriday") (description "Package blackfriday is a markdown processor. ") (license license:bsd-2))) ``` Our existing package: ``` (define-public go-github-com-russross-blackfriday (package (name "go-github-com-russross-blackfriday") (version "2.0.1") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/russross/blackfriday") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "0nlz7isdd4rgnwzs68499hlwicxz34j2k2a0b8jy0y7ycd2bcr5j")))) (build-system go-build-system) (arguments '(#:import-path "github.com/russross/blackfriday")) (propagated-inputs `(("go-github-com-shurcool-sanitized-anchor-name" ,go-github-com-shurcool-sanitized-anchor-name))) (native-inputs `(("go-github-com-pmezard-go-difflib" ,go-github-com-pmezard-go-difflib))) (home-page "https://github.com/russross/blackfriday") (synopsis "Markdown processor in Go") (description "Blackfriday is a Markdown processor in Go.") (license license:bsd-2))) ```