From: Vicente Vera <vicentemvp@gmail.com>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 04/19] gnu: Add r-bh.
Date: Tue, 15 Sep 2015 14:34:31 -0300 [thread overview]
Message-ID: <CAMfbzvDoXGCnCMxQdmvcP1buHtHm86ivw+cv1UCP83G7=bs_Tg@mail.gmail.com> (raw)
In-Reply-To: <CAMfbzvByP8TsM6U6Sr5wC6N6dYmuaVpstVN860sZYvzx+YcRiQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]
Updated patch attached.
2015-09-14 16:43 GMT-03:00 Vicente Vera <vicentemvp@gmail.com>:
> Hello,
>
> I don't know if the boost package in the distribution could be used to
> comply with the requirements. IMO it is safer to incorporate r-bh as
> it is needed by dplyr.
>
> New patch with corrections attached.
>
> 2015-09-14 7:50 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>>
>>> * gnu/packages/statistics.scm (r-bh): New variable.
>>
>> [...]
>>
>>> + (synopsis "Boost C++ Header Files")
>>> + (description
>>> + "Boost provides free peer-reviewed portable C++ source libraries.
>>> +A large part of Boost is provided as C++ template code which is
>>> +resolved entirely at compile-time without linking. This package aims
>>> +to provide the most useful subset of Boost libraries for template use
>>> +among CRAN package. By placing these libraries in this package, we
>>> +offer a more efficient distribution system for CRAN as replication of
>>> +this code in the sources of other packages is avoided.")
>>> + (license license:boost1.0)))
>>
>> It seems ugly to duplicate the Boost headers in a separate package. We
>> already have a “boost” package, which provides the headers for this
>> version of Boost. Would it be possible to use the existing “boost”
>> package in place of “r-bh”?
>>
>> If not: please use two spaces in the description. I think the first two
>> sentences can be removed as they relate to the Boost library. Also,
>> please use lower case for the synopsis.
>>
>> ~~ Ricardo
[-- Attachment #2: 0004-gnu-Add-r-bh.patch --]
[-- Type: text/x-patch, Size: 1622 bytes --]
From 217d1823ee8108f8e66232ae6b47b2411b1d9a43 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Tue, 15 Sep 2015 14:15:16 -0300
Subject: [PATCH 04/19] gnu: Add r-bh.
* gnu/packages/statistics.scm (r-bh): New variable.
---
gnu/packages/statistics.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 525b7ed..5801ce6 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -566,3 +566,26 @@ communication between R and relational database management systems. All
classes in this package are virtual and need to be extended by the various
R/DBMS implementations.")
(license license:lgpl3+)))
+
+(define-public r-bh
+ (package
+ (name "r-bh")
+ (version "1.58.0-1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://cran/src/contrib/BH_"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "17rnwyw9ib2pvm60iixzkbz7ff4fslpifp1nlx4czp42hy67kqpf"))))
+ (build-system r-build-system)
+ (home-page
+ "https://github.com/eddelbuettel/bh")
+ (synopsis
+ "Boost C++ header files")
+ (description
+ "This package aims to provide the most useful subset of Boost libraries
+for template use among CRAN packages. By placing these libraries in this
+package, we offer a more efficient distribution system for CRAN as replication
+of this code in the sources of other packages is avoided.")
+ (license license:boost1.0)))
--
2.5.2
next prev parent reply other threads:[~2015-09-15 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:46 [PATCH 04/19] gnu: Add r-bh Vicente Vera
2015-09-14 10:50 ` Ricardo Wurmus
2015-09-14 19:43 ` Vicente Vera
2015-09-15 17:34 ` Vicente Vera [this message]
2015-09-17 12:02 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMfbzvDoXGCnCMxQdmvcP1buHtHm86ivw+cv1UCP83G7=bs_Tg@mail.gmail.com' \
--to=vicentemvp@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).