From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 04/19] gnu: Add r-bh. Date: Tue, 15 Sep 2015 14:34:31 -0300 Message-ID: References: <87fv2h8ecn.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e013d0b2439db03051fcc98aa Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbu7l-0005kL-8q for guix-devel@gnu.org; Tue, 15 Sep 2015 13:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbu7k-0003dk-2s for guix-devel@gnu.org; Tue, 15 Sep 2015 13:34:33 -0400 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:34660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbu7j-0003dL-OQ for guix-devel@gnu.org; Tue, 15 Sep 2015 13:34:32 -0400 Received: by obbda8 with SMTP id da8so141072266obb.1 for ; Tue, 15 Sep 2015 10:34:31 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --089e013d0b2439db03051fcc98aa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Updated patch attached. 2015-09-14 16:43 GMT-03:00 Vicente Vera : > Hello, > > I don't know if the boost package in the distribution could be used to > comply with the requirements. IMO it is safer to incorporate r-bh as > it is needed by dplyr. > > New patch with corrections attached. > > 2015-09-14 7:50 GMT-03:00 Ricardo Wurmus : >> >>> * gnu/packages/statistics.scm (r-bh): New variable. >> >> [...] >> >>> + (synopsis "Boost C++ Header Files") >>> + (description >>> + "Boost provides free peer-reviewed portable C++ source libraries. >>> +A large part of Boost is provided as C++ template code which is >>> +resolved entirely at compile-time without linking. This package aims >>> +to provide the most useful subset of Boost libraries for template use >>> +among CRAN package. By placing these libraries in this package, we >>> +offer a more efficient distribution system for CRAN as replication of >>> +this code in the sources of other packages is avoided.") >>> + (license license:boost1.0))) >> >> It seems ugly to duplicate the Boost headers in a separate package. We >> already have a =E2=80=9Cboost=E2=80=9D package, which provides the heade= rs for this >> version of Boost. Would it be possible to use the existing =E2=80=9Cboo= st=E2=80=9D >> package in place of =E2=80=9Cr-bh=E2=80=9D? >> >> If not: please use two spaces in the description. I think the first two >> sentences can be removed as they relate to the Boost library. Also, >> please use lower case for the synopsis. >> >> ~~ Ricardo --089e013d0b2439db03051fcc98aa Content-Type: text/x-patch; charset=US-ASCII; name="0004-gnu-Add-r-bh.patch" Content-Disposition: attachment; filename="0004-gnu-Add-r-bh.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ieln2gp81 RnJvbSAyMTdkMTgyM2VlODEwOGY4ZTY2MjMyYWU2YjQ3YjI0MTFiMWQ5YTQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBUdWUsIDE1IFNlcCAyMDE1IDE0OjE1OjE2IC0wMzAwClN1YmplY3Q6IFtQQVRD SCAwNC8xOV0gZ251OiBBZGQgci1iaC4KCiogZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtIChy LWJoKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbSB8IDIz ICsrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbSBiL2dudS9wYWNrYWdl cy9zdGF0aXN0aWNzLnNjbQppbmRleCA1MjViN2VkLi41ODAxY2U2IDEwMDY0NAotLS0gYS9nbnUv cGFja2FnZXMvc3RhdGlzdGljcy5zY20KKysrIGIvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2Nt CkBAIC01NjYsMyArNTY2LDI2IEBAIGNvbW11bmljYXRpb24gYmV0d2VlbiBSIGFuZCByZWxhdGlv bmFsIGRhdGFiYXNlIG1hbmFnZW1lbnQgc3lzdGVtcy4gIEFsbAogY2xhc3NlcyBpbiB0aGlzIHBh Y2thZ2UgYXJlIHZpcnR1YWwgYW5kIG5lZWQgdG8gYmUgZXh0ZW5kZWQgYnkgdGhlIHZhcmlvdXMK IFIvREJNUyBpbXBsZW1lbnRhdGlvbnMuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmxncGwzKykp KQorCisoZGVmaW5lLXB1YmxpYyByLWJoCisgIChwYWNrYWdlCisgICAgKG5hbWUgInItYmgiKQor ICAgICh2ZXJzaW9uICIxLjU4LjAtMSIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAg ICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5k ICJtaXJyb3I6Ly9jcmFuL3NyYy9jb250cmliL0JIXyIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB2ZXJzaW9uICIudGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAg ICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMTdybnd5dzlpYjJwdm02MGlp eHprYno3ZmY0ZnNscGlmcDFubHg0Y3pwNDJoeTY3a3FwZiIpKSkpCisgICAgKGJ1aWxkLXN5c3Rl bSByLWJ1aWxkLXN5c3RlbSkKKyAgICAoaG9tZS1wYWdlCisgICAgICJodHRwczovL2dpdGh1Yi5j b20vZWRkZWxidWV0dGVsL2JoIikKKyAgICAoc3lub3BzaXMKKyAgICAgIkJvb3N0IEMrKyBoZWFk ZXIgZmlsZXMiKQorICAgIChkZXNjcmlwdGlvbgorICAgICAiVGhpcyBwYWNrYWdlIGFpbXMgdG8g cHJvdmlkZSB0aGUgbW9zdCB1c2VmdWwgc3Vic2V0IG9mIEJvb3N0IGxpYnJhcmllcworZm9yIHRl bXBsYXRlIHVzZSBhbW9uZyBDUkFOIHBhY2thZ2VzLiAgQnkgcGxhY2luZyB0aGVzZSBsaWJyYXJp ZXMgaW4gdGhpcworcGFja2FnZSwgd2Ugb2ZmZXIgYSBtb3JlIGVmZmljaWVudCBkaXN0cmlidXRp b24gc3lzdGVtIGZvciBDUkFOIGFzIHJlcGxpY2F0aW9uCitvZiB0aGlzIGNvZGUgaW4gdGhlIHNv dXJjZXMgb2Ygb3RoZXIgcGFja2FnZXMgaXMgYXZvaWRlZC4iKQorICAgIChsaWNlbnNlIGxpY2Vu c2U6Ym9vc3QxLjApKSkKLS0gCjIuNS4yCgo= --089e013d0b2439db03051fcc98aa--