[PATCH 03/19] gnu: Add r-dbi.

[PATCH 03/19] gnu: Add r-dbi.

[Vicente Vera]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0003-gnu-Add-r-dbi.patch --]
[-- Type: text/x-patch, Size: 1445 bytes --]

From f6dfaeeedfb3f169e4a9aa1f67e98d45a2365a5f Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Sun, 13 Sep 2015 13:07:34 -0300
Subject: [PATCH 03/19] gnu: Add r-dbi.

* gnu/packages/statistics.scm (r-dbi): New variable.
---
 gnu/packages/statistics.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 004ecef..76cc031 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -535,3 +535,23 @@ what they've done wrong.")
     (description
      "A disciplined approach to non-standard evaluation.")
     (license license:gpl3+)))
+
+(define-public r-dbi
+  (package
+    (name "r-dbi")
+    (version "0.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/DBI_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "0xj5baxwnhl23rd5nskhjvranrwrc68f3xlyrklglipi41bm69hw"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/rstats-db/DBI")
+    (synopsis "R Database Interface")
+    (description
+     "A database interface (DBI) definition for communication between R
+and relational database management systems. All classes in this
+package are virtual and need to be extended by the various R/DBMS
+implementations.")
+    (license license:lgpl3+)))
-- 
2.5.1

Re: [PATCH 03/19] gnu: Add r-dbi.

[Ricardo Wurmus]

Vicente Vera <vicentemvp@gmail.com> writes:

> * gnu/packages/statistics.scm (r-dbi): New variable.

[...]

> +    (synopsis "R Database Interface")

Please use lower case here.

> +    (description
> +     "A database interface (DBI) definition for communication between R
> +and relational database management systems. All classes in this
> +package are virtual and need to be extended by the various R/DBMS
> +implementations.")

Please use two spaces after each sentence.  Also, please change the
beginning of the first sentence fragment so that it becomes a full
sentence.

E.g. s/A/The DBI package provides a/

~~ Ricardo

Re: [PATCH 03/19] gnu: Add r-dbi.

[Vicente Vera]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

New patch attached.

2015-09-14 7:46 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>
> Vicente Vera <vicentemvp@gmail.com> writes:
>
>> * gnu/packages/statistics.scm (r-dbi): New variable.
>
> [...]
>
>> +    (synopsis "R Database Interface")
>
> Please use lower case here.
>
>> +    (description
>> +     "A database interface (DBI) definition for communication between R
>> +and relational database management systems. All classes in this
>> +package are virtual and need to be extended by the various R/DBMS
>> +implementations.")
>
> Please use two spaces after each sentence.  Also, please change the
> beginning of the first sentence fragment so that it becomes a full
> sentence.
>
> E.g. s/A/The DBI package provides a/
>
> ~~ Ricardo

[-- Attachment #2: 0003-gnu-Add-r-dbi.patch --]
[-- Type: text/x-patch, Size: 1458 bytes --]

From 333486e0ce10160045174b9418f2fe168926a7a0 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Mon, 14 Sep 2015 13:36:13 -0300
Subject: [PATCH 03/12] gnu: Add r-dbi.

* gnu/packages/statistics.scm (r-dbi): New variable.
---
 gnu/packages/statistics.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 5137b1b..5b29f6f 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -536,3 +536,23 @@ wrong.")
     (description
      "A disciplined approach to non-standard evaluation in R.")
     (license license:gpl3+)))
+
+(define-public r-dbi
+  (package
+    (name "r-dbi")
+    (version "0.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/DBI_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "0xj5baxwnhl23rd5nskhjvranrwrc68f3xlyrklglipi41bm69hw"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/rstats-db/DBI")
+    (synopsis "R database interface")
+    (description
+     "The DBI package provides a database interface (DBI) definition for
+communication between R and relational database management systems.  All
+classes in this package are virtual and need to be extended by the various
+R/DBMS implementations.")
+    (license license:lgpl3+)))
-- 
2.5.2

Re: [PATCH 03/19] gnu: Add r-dbi.

[Vicente Vera]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Updated patch attached.

2015-09-14 16:35 GMT-03:00 Vicente Vera <vicentemvp@gmail.com>:
> New patch attached.
>
> 2015-09-14 7:46 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>>
>> Vicente Vera <vicentemvp@gmail.com> writes:
>>
>>> * gnu/packages/statistics.scm (r-dbi): New variable.
>>
>> [...]
>>
>>> +    (synopsis "R Database Interface")
>>
>> Please use lower case here.
>>
>>> +    (description
>>> +     "A database interface (DBI) definition for communication between R
>>> +and relational database management systems. All classes in this
>>> +package are virtual and need to be extended by the various R/DBMS
>>> +implementations.")
>>
>> Please use two spaces after each sentence.  Also, please change the
>> beginning of the first sentence fragment so that it becomes a full
>> sentence.
>>
>> E.g. s/A/The DBI package provides a/
>>
>> ~~ Ricardo

[-- Attachment #2: 0003-gnu-Add-r-dbi.patch --]
[-- Type: text/x-patch, Size: 1501 bytes --]

From 6a0bcb4f5358bff2e9d0e961a94a400923420b07 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Tue, 15 Sep 2015 14:14:11 -0300
Subject: [PATCH 03/19] gnu: Add r-dbi.

* gnu/packages/statistics.scm (r-dbi): New variable.
---
 gnu/packages/statistics.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 22d8290..525b7ed 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -543,3 +543,26 @@ wrong.")
      "This package provides the tools necessary to do non-standard
 evaluation (NSE) in R.")
     (license license:gpl3+)))
+
+(define-public r-dbi
+  (package
+    (name "r-dbi")
+    (version "0.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/DBI_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "0xj5baxwnhl23rd5nskhjvranrwrc68f3xlyrklglipi41bm69hw"))))
+    (build-system r-build-system)
+    (home-page
+     "https://github.com/rstats-db/DBI")
+    (synopsis
+     "R database interface")
+    (description
+     "The DBI package provides a database interface (DBI) definition for
+communication between R and relational database management systems.  All
+classes in this package are virtual and need to be extended by the various
+R/DBMS implementations.")
+    (license license:lgpl3+)))
-- 
2.5.2

Re: [PATCH 03/19] gnu: Add r-dbi.

[Ricardo Wurmus]

Hi Vicente,

> Updated patch attached.

Thank you.  I pushed this after minor fixes:

  * pulled home-page and synopsis each on one line; please only split
    these fields to multiple lines if the contents warrant it (and in
    that case the synopsis would have to be shortened anyway).
  * changed license to “lgpl2.0+” as the DESCRIPTION says “LGPL (>= 2)”

~~ Ricardo

Re: [PATCH 03/19] gnu: Add r-dbi.

[Vicente Vera]

Hello Ricardo,

I'm sorry for the home-page and synopsis in separate lines; truly bad
choice there since every patch has the same issue. If you don't mind I
could upload corrected versions.

Thank you for the observations and corrections.

2015-09-16 7:03 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
> Hi Vicente,
>
>> Updated patch attached.
>
> Thank you.  I pushed this after minor fixes:
>
>   * pulled home-page and synopsis each on one line; please only split
>     these fields to multiple lines if the contents warrant it (and in
>     that case the synopsis would have to be shortened anyway).
>   * changed license to “lgpl2.0+” as the DESCRIPTION says “LGPL (>= 2)”
>
> ~~ Ricardo

Re: [PATCH 03/19] gnu: Add r-dbi.

[Ricardo Wurmus]

Vicente Vera <vicentemvp@gmail.com> writes:
> I'm sorry for the home-page and synopsis in separate lines; truly bad
> choice there since every patch has the same issue. If you don't mind I
> could upload corrected versions.

That’s okay.  I’ll amend your patches before pushing, so you don’t need
to send them a third time.

Thank you!

~~ Ricardo