unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Beffa <beffa@ieee.org>
To: Guix-devel <guix-devel@gnu.org>
Subject: [PATCH] gnu: libpeas: Update to 1.12.1, add arguments and disable tests.
Date: Tue, 20 Jan 2015 18:52:57 +0100	[thread overview]
Message-ID: <CAKrPhPPfjJmCYTUJdMKq0xiGRJuD=V8NUThfjqFRdNBw5WXHtA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

Please find attached a patch for libpeas.

This package, up to now, is the only one experiencing some
side-effects from the gobject-introspection patch that we adopted from
nix and which installs the full path name of shared libraries in
.typelib and .gir files.

The side-effect here is that some tests fail because:

* they are executed before installation (solvable by swapping 'check
and 'install phases) and

* because it makes use of libtool convenience libraries (libraries
which are only intermediate steps and are not installed). This is
implemented by specifying a fake installation directory called
"/nowhere" which, of course, does not exists. This is the error
message:

/tmp/nix-build-libpeas-1.12.1.drv-0/libpeas-1.12.1/tests/libpeas/.libs/extension-c:11955):
libpeas-ERROR **: Unhandled warning: (null): Failed to load shared
library '/nowhere/libintrospection-1.0.so.0' referenced by the
typelib: /nowhere/libintrospection-1.0.so.0: cannot open shared object
file: No such file or directory

Unless someone knows how to solve this problem, I suggest to disable the tests.

Regards,
Fede

[-- Attachment #2: 0001-gnu-libpeas-Update-to-1.12.1-add-arguments-and-disab.patch --]
[-- Type: text/x-patch, Size: 2890 bytes --]

From f64aede7de3f2a8fdaf0db144ce0eb14fbc1a68c Mon Sep 17 00:00:00 2001
From: Federico Beffa <beffa@fbengineering.ch>
Date: Tue, 20 Jan 2015 18:43:55 +0100
Subject: [PATCH] gnu: libpeas: Update to 1.12.1, add arguments and disable
 tests.

* gnu/packages/gnome.scm (libpeas): Update to version 1.12.1, add 'pre-build
  and 'check-after-install phases and delete 'check phase.  Given that
  'check-after-install only solves part of the problem, disable the tests.
---
 gnu/packages/gnome.scm | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index acc964e..7622e0a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2014 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2014 Ian Denhardt <ian@zenhack.net>
 ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
+;;; Copyright © 2014, 2015 Federico Beffa <beffa@fbengineering.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -427,7 +428,7 @@ some form of information without getting in the user's way.")
 (define-public libpeas
   (package
     (name "libpeas")
-    (version "1.9.0")
+    (version "1.12.1")
     (source
      (origin
       (method url-fetch)
@@ -436,7 +437,7 @@ some form of information without getting in the user's way.")
                           name "-" version ".tar.xz"))
       (sha256
        (base32
-        "13fzyzv6c0cfdj83z1s16lv8k997wpnzyzr0wfwcfkcmvz64g1q0"))))
+        "1mjjjjwphc83bjznmbsm7x0jg7ql261nys6qnl7mi0nkr4qvw476"))))
     (build-system gnu-build-system)
     (inputs
      `(("atk" ,atk)
@@ -449,6 +450,21 @@ some form of information without getting in the user's way.")
        ("glib:bin" ,glib "bin")
        ("gobject-introspection" ,gobject-introspection)
        ("intltool" ,intltool)))
+    (arguments
+     ;; Some tests make use of libtool convenience libraries.  This, together
+     ;; with our patched 'gobject-introspection', results in temporary
+     ;; .gir/.typelib files referring to non-existent directories.  The
+     ;; installed files do not include those entries.
+     `(#:tests? #f
+       #:phases 
+       (alist-cons-before
+        'build 'pre-build
+        (lambda* _
+          (setenv "CC" "gcc"))
+        (alist-cons-after
+         'install 'check-after-install
+         (assq-ref %standard-phases 'check)
+         (alist-delete 'check %standard-phases)))))
     (home-page "https://wiki.gnome.org/Libpeas")
     (synopsis "GObject plugin system")
     (description
@@ -457,7 +473,6 @@ every application the chance to assume its own extensibility.  It also has a
 set of features including, but not limited to: multiple extension points; on
 demand (lazy) programming language support for C, Python and JS; simplicity of
 the API")
-
     (license license:lgpl2.0+)))
 
 (define-public gtkglext
-- 
1.8.4


             reply	other threads:[~2015-01-20 17:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 17:52 Federico Beffa [this message]
2015-01-21 13:01 ` [PATCH] gnu: libpeas: Update to 1.12.1, add arguments and disable tests Federico Beffa
2015-01-22 20:43   ` Ludovic Courtès
2015-01-22 20:39 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKrPhPPfjJmCYTUJdMKq0xiGRJuD=V8NUThfjqFRdNBw5WXHtA@mail.gmail.com' \
    --to=beffa@ieee.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).