[PATCH] gnu: atlas: Try to fix build on MIPS.

[PATCH] gnu: atlas: Try to fix build on MIPS.

[Federico Beffa]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

I would like to propose the attached patch to try to fix the MIPS
package.  I'm not sure if this really help, but I do not have a way to
test it locally.

Regards,
Fede

[-- Attachment #2: 0001-gnu-atlas-Try-to-fix-build-on-MIPS.patch --]
[-- Type: text/x-patch, Size: 1120 bytes --]

From 64235b3012ebf6ac337a8615dd91ae08beb95180 Mon Sep 17 00:00:00 2001
From: Federico Beffa <beffa@fbengineering.ch>
Date: Sat, 22 Nov 2014 16:42:41 +0100
Subject: [PATCH] gnu: atlas: Try to fix build on MIPS.

* gnu/packages/maths.scm (atlas): Add MIPS specific configure flags.
---
 gnu/packages/maths.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 1aa3757..6a8d56c 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -979,6 +979,11 @@ point numbers")
          ;; Disable parallel build as it gives errors: atlas_pthread.h is
          ;; needed to compile C files before it is generated.
          "-Ss" "pmake" "make -j 1"
+         ;; Probe is failing for MIPS.  We therefore define the system
+         ;; architecture explicitly by setting (-A) MACHINETYPE = 49
+         ;; 'MIPSR1xK' and (-V) ISA = 1 'none'.
+         ,,@(when (string-prefix? "mips" (%current-system))
+              (list "-A" "49" "-V" "1"))
          ;; Generate shared libraries.
          "--shared"
          ;; Build a full LAPACK library.
-- 
1.8.4

Re: [PATCH] gnu: atlas: Try to fix build on MIPS.

[Ludovic Courtès]

Federico Beffa <beffa@ieee.org> skribis:

> I would like to propose the attached patch to try to fix the MIPS
> package.  I'm not sure if this really help, but I do not have a way to
> test it locally.

The change makes sense, so I think it’s OK to commit it and see what
happens.  Mark or some other MIPS user can always chime in anytime.

> From 64235b3012ebf6ac337a8615dd91ae08beb95180 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sat, 22 Nov 2014 16:42:41 +0100
> Subject: [PATCH] gnu: atlas: Try to fix build on MIPS.
>
> * gnu/packages/maths.scm (atlas): Add MIPS specific configure flags.

[...]

> +         ;; Probe is failing for MIPS.  We therefore define the system
> +         ;; architecture explicitly by setting (-A) MACHINETYPE = 49
> +         ;; 'MIPSR1xK' and (-V) ISA = 1 'none'.
> +         ,,@(when (string-prefix? "mips" (%current-system))
> +              (list "-A" "49" "-V" "1"))

This should be an ‘if’:

  (if (string-prefix? ...)
      ...
      '())

You can check on Intel that this modification doesn’t change the result
of the ‘guix build atlas’.

OK to push afterwards.

Thank you,
Ludo’.

Re: [PATCH] gnu: atlas: Try to fix build on MIPS.

[Ludovic Courtès]

Apparently the patch didn’t really help:

  http://hydra.gnu.org/build/167383

Seems like it insists on compiling x86 assembly, which fails:

--8<---------------cut here---------------start------------->8---
probe_arch.o: In function `ATL_tmpnam':
/tmp/nix-build-atlas-3.10.2.drv-0/build/../ATLAS//CONFIG/include/atlas_sys.h:224: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
/tmp/nix-build-atlas-3.10.2.drv-0/build/../ATLAS//CONFIG/src/backend/cpuid.S: Assembler messages:
/tmp/nix-build-atlas-3.10.2.drv-0/build/../ATLAS//CONFIG/src/backend/cpuid.S:32: Error: unrecognized opcode `subl $8,%esp'
/tmp/nix-build-atlas-3.10.2.drv-0/build/../ATLAS//CONFIG/src/backend/cpuid.S:33: Error: unrecognized opcode `movl %ebx,(%esp)'

[...]

make[2]: *** [xarchinfo_x86] Error 1
--8<---------------cut here---------------end--------------->8---

At this point I think it’s OK to remove MIPS from ‘supported-systems’
for this package, with a comment pointing to these discussions in case
someone wants to investigate.

WDYT?

Thanks,
Ludo’.

Re: [PATCH] gnu: atlas: Try to fix build on MIPS.

[Federico Beffa]

On Sun, Dec 7, 2014 at 12:46 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> At this point I think it’s OK to remove MIPS from ‘supported-systems’
> for this package, with a comment pointing to these discussions in case
> someone wants to investigate.
>

OK. Is this the correct method?

(supported-systems (delete "mips64el-linux" %supported-systems))

Regards,
Fede

Re: [PATCH] gnu: atlas: Try to fix build on MIPS.

[Ludovic Courtès]

Federico Beffa <beffa@ieee.org> skribis:

> On Sun, Dec 7, 2014 at 12:46 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> At this point I think it’s OK to remove MIPS from ‘supported-systems’
>> for this package, with a comment pointing to these discussions in case
>> someone wants to investigate.
>>
>
> OK. Is this the correct method?
>
> (supported-systems (delete "mips64el-linux" %supported-systems))

Yes, exactly.

Ludo’.