unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Beffa <beffa@ieee.org>
To: Eric Bavier <ericbavier@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add pyparsing.
Date: Tue, 25 Nov 2014 18:51:15 +0100	[thread overview]
Message-ID: <CAKrPhPOEKgnUKgq8xgjiefFaASDZBM+k8SfqhbQFt1eo3Zd=hQ@mail.gmail.com> (raw)
In-Reply-To: <87a93ftcv2.fsf@gmail.com>

Cyril Roelandt <tipecaml@gmail.com> writes:

>
> Maybe you could add the PyPI mirror here.
>

I'm not sure I understand. Do you mean replace or really add? A second
uri field? Could you give an example? The sourceforge download site is
the one mentioned on the homepage.

>
> There is a "unitTests.py" that can be run manually, if I'm not mistaken.
> Maybe you could replace the check phase ?
>

I do not think so.  I do not see any reference to tests in the README
and other source files and I can't find a file called "unitTests.py".

>
> I trust you on the doc thing :) Is it something that could somehow be
> part of the python build system?
>

I'm not a python expert :-) From the few packages that I prepared
lately, I have the impression that each python library does something
different with the documentation.

>
> Do not start the synopsis by "a". You may want to run "guix lint" on
> your package to find such issues.
>

Ooops, forgot to run that.

Thanks for the review,
Fede

  reply	other threads:[~2014-11-25 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 16:55 [PATCH] gnu: Add pyparsing Federico Beffa
2014-11-25 17:11 ` Ludovic Courtès
2014-11-25 17:17 ` Cyril Roelandt
2014-11-25 17:21 ` Eric Bavier
2014-11-25 17:51   ` Federico Beffa [this message]
2014-11-26 16:40     ` Cyril Roelandt
2014-11-25 19:47   ` Federico Beffa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKrPhPOEKgnUKgq8xgjiefFaASDZBM+k8SfqhbQFt1eo3Zd=hQ@mail.gmail.com' \
    --to=beffa@ieee.org \
    --cc=ericbavier@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).