Re: [PATCH] gnu: Add matplotlib.

[Federico Beffa <beffa@ieee.org>]

On Sat, Nov 29, 2014 at 10:05 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> What happens is that ‘package-with-python2’ automatically generates
> python2 variants of the dependencies of the package you give it.  So
> (package-with-python2 python-matplotlib) generates a package with an
> input that is exactly (package-with-python2 python-numpydoc), hence with
> #:tests? #t.

Oh, I see.  Wouldn't it be better if, for each input,
'pyckage-with-python2' would check if in (gnu packages python) a
variable with prefix 'python2-' is defined and, in case it is, use
that variable instead of constructing new package?

>
> The fix is to explicitly use the right python2-numpydoc, along the lines
> of:
>
>   (define-public python2-matplotlib
>     (let ((matplotlib (package-with-python2 python-matplotlib)))
>       (package (inherit matplotlib)
>         ;; Make sure we use exactly PYTHON2-NUMPYDOC, which is
>         ;; customized for Python 2.
>         (inputs `(("numpydoc" ,python2-numpydoc)
>                   ,@(alist-delete "numpydoc" (package-inputs matplotlib)))))))
>
>
>> +       ;; FIX-ME: Add backends when available.
>
> Please write “FIXME” for easier grepping and highlighting.
>
> Otherwise the patch looks good to me, thanks for working on it!

I've corrected these two items and pushed the patch.

Thanks for the clarification!
Fede