From mboxrd@z Thu Jan  1 00:00:00 1970
From: Federico Beffa <beffa@ieee.org>
Subject: Re: [PATCH] gnu: Add matplotlib.
Date: Sun, 30 Nov 2014 17:01:02 +0100
Message-ID: <CAKrPhPNt0QS7rnQs=ExHJoqa=V+Ko9HKpFMYM3nPXDZnBHuXMQ@mail.gmail.com>
References: <CAKrPhPNmR4t_D4C+2LWfAjZDM7Wzvr19XNr=ZC9k+bzKV0CEgg@mail.gmail.com>
	<877fydvhs8.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1Xv6vp-0002y7-13
	for guix-devel@gnu.org; Sun, 30 Nov 2014 11:01:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <federico.beffa@gmail.com>) id 1Xv6vo-0007yT-87
	for guix-devel@gnu.org; Sun, 30 Nov 2014 11:01:04 -0500
In-Reply-To: <877fydvhs8.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>

On Sat, Nov 29, 2014 at 10:05 PM, Ludovic Court=C3=A8s <ludo@gnu.org> wrote=
:
> What happens is that =E2=80=98package-with-python2=E2=80=99 automatically=
 generates
> python2 variants of the dependencies of the package you give it.  So
> (package-with-python2 python-matplotlib) generates a package with an
> input that is exactly (package-with-python2 python-numpydoc), hence with
> #:tests? #t.

Oh, I see.  Wouldn't it be better if, for each input,
'pyckage-with-python2' would check if in (gnu packages python) a
variable with prefix 'python2-' is defined and, in case it is, use
that variable instead of constructing new package?

>
> The fix is to explicitly use the right python2-numpydoc, along the lines
> of:
>
>   (define-public python2-matplotlib
>     (let ((matplotlib (package-with-python2 python-matplotlib)))
>       (package (inherit matplotlib)
>         ;; Make sure we use exactly PYTHON2-NUMPYDOC, which is
>         ;; customized for Python 2.
>         (inputs `(("numpydoc" ,python2-numpydoc)
>                   ,@(alist-delete "numpydoc" (package-inputs matplotlib))=
)))))
>
>
>> +       ;; FIX-ME: Add backends when available.
>
> Please write =E2=80=9CFIXME=E2=80=9D for easier grepping and highlighting=
.
>
> Otherwise the patch looks good to me, thanks for working on it!

I've corrected these two items and pushed the patch.

Thanks for the clarification!
Fede