From: "Thompson, David" <dthompson2@worcester.edu>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add ruby-bio-locus.
Date: Mon, 14 Sep 2015 10:01:40 -0400 [thread overview]
Message-ID: <CAJ=RwfZbHARFyGYpoqKQH77WnqN0V17bysHZfgQC2LPrPqjN-w@mail.gmail.com> (raw)
In-Reply-To: <20150914132433.GA29632@thebird.nl>
On Mon, Sep 14, 2015 at 9:24 AM, Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> * gnu/packages/ruby.scm (ruby-bio-locus): New variable.
Awesome! Just a couple of minor comments below.
> ---
> gnu/packages/ruby.scm | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index ee0acc8..0a0fc1a 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -1124,3 +1124,23 @@ it unifies the API for web servers, web frameworks, and software in between
> into a single method call.")
> (home-page "http://rack.github.io/")
> (license license:expat)))
> +
> +(define-public ruby-bio-locus
> + (package
> + (name "ruby-bio-locus")
This is an application, not a library, correct? If so, I think it
would be best to name it just "bio-locus" and put it in the (gnu
packages bioinformatics) module. WDYT?
> + (version "0.0.7")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "bio-locus" version))
> + (sha256
> + (base32
> + "02vmrxyimkj9sahsp4zhfhnmbvz6dbbqz1y01vglf8cbwvkajfl0"))))
> + (build-system ruby-build-system)
> + (native-inputs
> + `(("ruby-rspec" ,ruby-rspec)))
> + (synopsis "Tool for fast querying of genome locations")
> + (description "This tabix-like tool essentially allows your to
> +store this chr+pos or chr+pos+alt information in a fast database.")
How about something more descriptive? Here's a modified snippet from
your README:
Bio-locus is a tool for fast querying of genome locations.
Many file formats in bioinformatics contain records that start with a
chromosome name and a position for a SNP, or a start-end position
for indels.
Bio-locus allows users to store this chr+pos or chr+pos+alt information in a
fast database.
> + (home-page "https://github.com/pjotrp/bio-locus")
> + (license license:expat)))
> --
> 2.4.3
>
Thanks! Keep 'em coming!
- Dave
next prev parent reply other threads:[~2015-09-14 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 13:24 [PATCH] gnu: Add ruby-bio-locus Pjotr Prins
2015-09-14 14:01 ` Thompson, David [this message]
2015-09-14 14:18 ` Pjotr Prins
2015-09-14 14:30 ` Thompson, David
2015-09-14 14:32 ` Pjotr Prins
2015-09-14 19:19 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfZbHARFyGYpoqKQH77WnqN0V17bysHZfgQC2LPrPqjN-w@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=pjotr.public12@thebird.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).