From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] gnu: Add ruby-bio-locus. Date: Mon, 14 Sep 2015 10:01:40 -0400 Message-ID: References: <20150914132433.GA29632@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbUKI-0001zl-3v for guix-devel@gnu.org; Mon, 14 Sep 2015 10:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbUKD-0006TM-Qk for guix-devel@gnu.org; Mon, 14 Sep 2015 10:01:46 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:36009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbUKD-0006SI-Nk for guix-devel@gnu.org; Mon, 14 Sep 2015 10:01:41 -0400 Received: by ykdt18 with SMTP id t18so132994088ykd.3 for ; Mon, 14 Sep 2015 07:01:41 -0700 (PDT) In-Reply-To: <20150914132433.GA29632@thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Pjotr Prins Cc: guix-devel On Mon, Sep 14, 2015 at 9:24 AM, Pjotr Prins wrote: > * gnu/packages/ruby.scm (ruby-bio-locus): New variable. Awesome! Just a couple of minor comments below. > --- > gnu/packages/ruby.scm | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index ee0acc8..0a0fc1a 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -1124,3 +1124,23 @@ it unifies the API for web servers, web frameworks, and software in between > into a single method call.") > (home-page "http://rack.github.io/") > (license license:expat))) > + > +(define-public ruby-bio-locus > + (package > + (name "ruby-bio-locus") This is an application, not a library, correct? If so, I think it would be best to name it just "bio-locus" and put it in the (gnu packages bioinformatics) module. WDYT? > + (version "0.0.7") > + (source > + (origin > + (method url-fetch) > + (uri (rubygems-uri "bio-locus" version)) > + (sha256 > + (base32 > + "02vmrxyimkj9sahsp4zhfhnmbvz6dbbqz1y01vglf8cbwvkajfl0")))) > + (build-system ruby-build-system) > + (native-inputs > + `(("ruby-rspec" ,ruby-rspec))) > + (synopsis "Tool for fast querying of genome locations") > + (description "This tabix-like tool essentially allows your to > +store this chr+pos or chr+pos+alt information in a fast database.") How about something more descriptive? Here's a modified snippet from your README: Bio-locus is a tool for fast querying of genome locations. Many file formats in bioinformatics contain records that start with a chromosome name and a position for a SNP, or a start-end position for indels. Bio-locus allows users to store this chr+pos or chr+pos+alt information in a fast database. > + (home-page "https://github.com/pjotrp/bio-locus") > + (license license:expat))) > -- > 2.4.3 > Thanks! Keep 'em coming! - Dave