Packaging leiningen (feedback desired)

Packaging leiningen (feedback desired)

[alex.ter.weele]

If anyone's around, I would appreciate some feedback. I'm trying to
package leiningen, a build tool for clojure projects. The recommended
way to manually install leiningen is to use a script that will download
a .jar
(https://github.com/technomancy/leiningen/blob/stable/bin/lein#L65). This
is also the recommended way to bootstrap: use an older version of
leiningen to build the newer version
(https://github.com/technomancy/leiningen/blob/stable/CONTRIBUTING.md#bootstrapping).

Other distributions, even Nix, use this approach for their leiningen
package. Download the .jar and the "lein" script and put them in the
appropriate places
(https://github.com/technomancy/leiningen/wiki/Packaging).
  * https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/build-managers/leiningen/default.nix
  * https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-java/leiningen-bin/leiningen-bin-2.7.1.ebuild

Anyway, I'm trying to do this right, so my plan is to make a
leiningen-bootstrap package (based on an old version of leiningen) that
will be built "manually", then using that to build a modern
leiningen. Is this the right idea?

I'm also running into some problems with either the clojure or the
icedtea packages, manifesting as "Could not find or load main class":

bash-4.4$ guix environment --ad-hoc clojure
bash-4.4$ java -cp $GUIX_ENVIRONMENT/share/java/ clojure.main
bash: java: command not found
bash-4.4$ exit
bash-4.4$ guix environment clojure
bash-4.4$ java -cp clojure-1.8.0.jar clojure.main
Error: Could not find or load main class clojure.main
bash-4.4$ file clojure-1.8.0.jar 
clojure-1.8.0.jar: Zip archive data, at least v1.0 to extract
bash-4.4$ clojure
bash: clojure: command not found

(I'm trying to emulate https://clojure.org/guides/getting_started here.)

It is unclear to me how the current clojure package is meant to be
used. Could someone clarify that? Ricardo, I believe you reviewed the
patch to add the package...any ideas?

Thanks,
Alex

Re: Packaging leiningen (feedback desired)

[Danny Milosavljevic]

Hmmm... works for me with:

$ java -cp "${HOME}/.guix-profile/share/java/clojure-1.8.0.jar" clojure.main

(Note: java -> /gnu/store/4lnjmsr4szhqyixy238xjl83k8h5f0ck-icedtea-3.2.0/bin/java)

Also works within guix environment --ad-hoc clojure.

Re: Packaging leiningen (feedback desired)

[Ben Woodcroft]

Hi Danny, Alex,

On 07/02/17 18:19, Danny Milosavljevic wrote:
> Hmmm... works for me with:
>
> $ java -cp "${HOME}/.guix-profile/share/java/clojure-1.8.0.jar" clojure.main
>
> (Note: java -> /gnu/store/4lnjmsr4szhqyixy238xjl83k8h5f0ck-icedtea-3.2.0/bin/java)
>
> Also works within guix environment --ad-hoc clojure.
I was unable to use that command with that exact environment (clojure 
doesn't propagate any java), but it does work when icedtea is added i.e.

guix environment --container --ad-hoc clojure icedtea

I'm not expert enough to comment on whether the clojure package itself 
needs to be changed, but this is a workaround at least.
ben

Re: Packaging leiningen (feedback desired)

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

2017-02-08 0:00 GMT+01:00 Ben Woodcroft <b.woodcroft@uq.edu.au>:

> Hi Danny, Alex,
>
>
> On 07/02/17 18:19, Danny Milosavljevic wrote:
>
>> Hmmm... works for me with:
>>
>> $ java -cp "${HOME}/.guix-profile/share/java/clojure-1.8.0.jar"
>> clojure.main
>>
>> (Note: java -> /gnu/store/4lnjmsr4szhqyixy238xjl83k8h5f0ck-icedtea-3.2.0/
>> bin/java)
>>
>> Also works within guix environment --ad-hoc clojure.
>>
> I was unable to use that command with that exact environment (clojure
> doesn't propagate any java), but it does work when icedtea is added i.e.
>
> guix environment --container --ad-hoc clojure icedtea
>
> I'm not expert enough to comment on whether the clojure package itself
> needs to be changed, but this is a workaround at least.
> ben
>
>
>
>
>
The Clojure compilation target is the Jvm. Any Clojure based software needs
a Jvm in order to run

And the Clojure REPL is a Clojure based program. Without a Jvm it won' t
run.

I don' t remember now if the compiler is written in Java or in Clojure.
Anyway, the compiler too needs a Jvm in order to run.

That is to say that as far as I understand both Clojure and Guix, a Java
runtime should be a propagated input of any Clojure package.

[-- Attachment #2: Type: text/html, Size: 1985 bytes --]

Re: Packaging leiningen (feedback desired)

[Ricardo Wurmus]

Catonano <catonano@gmail.com> writes:

> The Clojure compilation target is the Jvm. Any Clojure based software needs
> a Jvm in order to run
>
> And the Clojure REPL is a Clojure based program. Without a Jvm it won' t
> run.
>
> I don' t remember now if the compiler is written in Java or in Clojure.
> Anyway, the compiler too needs a Jvm in order to run.
>
> That is to say that as far as I understand both Clojure and Guix, a Java
> runtime should be a propagated input of any Clojure package.

I’d like to avoid propagating inputs.  Could we add a wrapper instead?
The wrapper would set the appropriate environment variables and retain a
reference to the JVM.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: Packaging leiningen (feedback desired)

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

2017-02-08 16:53 GMT+01:00 Ricardo Wurmus <rekado@elephly.net>:

I’d like to avoid propagating inputs.  Could we add a wrapper instead?
> The wrapper would set the appropriate environment variables and retain a
> reference to the JVM.
>

Good. So I can see how a wrapper is arranged

[-- Attachment #2: Type: text/html, Size: 655 bytes --]