From: zimoun <zimon.toutoune@gmail.com>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Licensing issue with Gmsh?
Date: Sat, 3 Oct 2020 01:49:30 +0200 [thread overview]
Message-ID: <CAJ3okZ20HpQBZZyDTOWtJPM3NA=+rS5xGNHjSLw6rUf3fhe=Rg@mail.gmail.com> (raw)
In-Reply-To: <a83b25bd90196f28fd38a1b254c51a867c3dd194.camel@tourbillion-technology.com>
Hi Paul,
Thank you for the review.
On Fri, 2 Oct 2020 at 23:59, Paul Garlick
<pgarlick@tourbillion-technology.com> wrote:
> The file is part of METIS and thereby covered by the Apache license.
> It only provides entry points for ParMETIS, so ignoring it in the build
> stage, in the way that Gmsh does, seems to be appropriate.
Fine.
> However, I notice from the patch that the Guix package metis is
> included as an input. This means that the whole of the bundled
> 'contrib/metis' directory could be deleted after all. If I remember
> correctly CMake gives preference to the 'system' packages ahead of the
> bundled packages.
Sorry, today was a bad day and I failed in multi-tasking.
Well, I have tried to use the Guix package 'metis' instead of the
bundled one -- without success about the test suite. Then when
sending the patch, I missed the remove (my personal unsafe-threading
;-)). So the package v2 fixes that. But the '(modules ...)' is not
necessary anymore.
All in all, the patch v3 is the good one. Sorry for the mess.
<http://issues.guix.gnu.org/43761#3>
All the best,
simon
next prev parent reply other threads:[~2020-10-02 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 16:26 Licensing issue with Gmsh? Paul Garlick
2020-10-02 17:35 ` zimoun
2020-10-02 21:59 ` Paul Garlick
2020-10-02 23:49 ` zimoun [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-02 8:07 zimoun
2020-10-02 12:28 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ20HpQBZZyDTOWtJPM3NA=+rS5xGNHjSLw6rUf3fhe=Rg@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=pgarlick@tourbillion-technology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).