From: Vincent Legoll <vincent.legoll@gmail.com>
To: yasu <yasu@yasuaki.com>
Cc: Guix Development <guix-devel@gnu.org>
Subject: Re: Add Microsoft Cascadia Code font?
Date: Sun, 10 Jan 2021 09:46:29 +0100 [thread overview]
Message-ID: <CAEwRq=rS16U2Eop8sbKt6bn6jptpwmPNyw2mmU0kLB9FTK0oog@mail.gmail.com> (raw)
In-Reply-To: <064a4b4d6fbd6b4f7521d4f258a9397b361e41d8.camel@yasuaki.com>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
Hello,
On Sun, Jan 10, 2021 at 9:04 AM yasu <yasu@yasuaki.com> wrote:
> Attached is my Guix package submission of Microsoft Cascadia Code
> fonts.
>
> This is my very first attempt to make a Guix package contribution and I
> did this in less than 30 minutes, copying the package descriptions of
> IBM Plex fonts and modifying a few things. I dont' know what
> protocols I may have missed 😅
>
> Would you please let me know how to proceed from here?
>
LGTM
small nitpicks:
* 80 columns (you can auto-format the code with etc/indent-code.el, this
is documented here:
https://guix.gnu.org/manual/en/html_node/Formatting-Code.html)
* I've not checked the difference size (nor that it matters) between zip
and tar.gz, you may want to use the smallest one to minimize download.
Thanks
--
Vincent Legoll
[-- Attachment #2: Type: text/html, Size: 1458 bytes --]
next prev parent reply other threads:[~2021-01-10 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 8:04 Add Microsoft Cascadia Code font? yasu
2021-01-10 8:46 ` Vincent Legoll [this message]
2021-01-10 8:51 ` Vincent Legoll
-- strict thread matches above, loose matches on Subject: below --
2021-01-10 9:16 Leo Prikler
2021-01-10 9:39 ` Vincent Legoll
2021-01-10 10:11 ` Yasuaki Kudo
2021-01-10 10:38 ` Leo Prikler
2021-01-10 10:56 ` Yasuaki Kudo
2021-01-10 12:28 ` yasu
2021-01-10 12:28 ` Julien Lepiller
2021-01-10 12:55 ` yasu
2021-01-10 13:09 ` Leo Prikler
2021-01-10 14:28 ` Julien Lepiller
2021-01-10 23:37 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwRq=rS16U2Eop8sbKt6bn6jptpwmPNyw2mmU0kLB9FTK0oog@mail.gmail.com' \
--to=vincent.legoll@gmail.com \
--cc=guix-devel@gnu.org \
--cc=yasu@yasuaki.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).