From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eC22DQq/+l9PFAAA0tVLHw (envelope-from ) for ; Sun, 10 Jan 2021 08:47:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QBqwCQq/+l8xfgAA1q6Kng (envelope-from ) for ; Sun, 10 Jan 2021 08:47:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 86E80940414 for ; Sun, 10 Jan 2021 08:47:05 +0000 (UTC) Received: from localhost ([::1]:39634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyWNM-0005kX-Ch for larch@yhetil.org; Sun, 10 Jan 2021 03:47:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyWN2-0005jh-Il for guix-devel@gnu.org; Sun, 10 Jan 2021 03:46:44 -0500 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:40228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyWN0-0003bP-QZ for guix-devel@gnu.org; Sun, 10 Jan 2021 03:46:44 -0500 Received: by mail-lf1-x132.google.com with SMTP id m12so33461020lfo.7 for ; Sun, 10 Jan 2021 00:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3cnZKjqxPFG7kaD9uZAwf47iC17tzB3MsQrg3WkhqO4=; b=fzRufURTwN2BL1nnC8Nn59Bxp/Kv7ssro71rTu1rfiDpaLVXXeLzj4/oJUx2tslQUj lP0XXoVtMQpevLKq2cTljn8Pw+HMUTAkLzbb/4HfmVcAvLnhUKYEhUWoySDwWr2Z/BcO xYhupOu7YutzzaYO7x7lNtB/67smQd9tSIw9dWC+gIitt3PCzIEvNzTHaDfIcnrlo+OH Bb8xXc1yDK9E4nCvjMzXgPx8BuQh9sQQNzB3Pazm/3Wd70O/G4p35TY0Wtv5HBrwPSLm IesVRP94+J/h8WrFKFArBcm6irf4yMEOXcX9lhzLHUyiRG+VbROm+0UftJZlrj691I/l nr3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3cnZKjqxPFG7kaD9uZAwf47iC17tzB3MsQrg3WkhqO4=; b=Ektko8+xLgsgJ6Zzwbgd8wIiYuZiS3WTxU9HrQrHV7cOOROip1Jv7mFcHyXqt1hhN7 k4XZHosgSPUAS02ggAihHNIXKKdCaLlLzOeGlRFh5K6iliku4t4BwlH0hGMcVmUAHZ1L SjVjndbzzvP/k+aAeD4C1/quwE/pEQtkWusL/a8A1Rt4sQ2ceXQIftrZKJzRv9DsuM4m fRvGo1QsoXTRQ4RbuUucJ/p0yaFl3hMELdxeLNwfiSqZ0LlRv7a+a9R7u5gdGchLoq9o 06ZOAGVR1XBvBR40FlElIWVLPReazs4b0uoL0B0W0j7ivS8vRffbvTXF4kv6CdEM0nan ruAg== X-Gm-Message-State: AOAM533TqNefLQRUR4wtqsO8qG6x7MO/DDVVL/cKvoZe6a85dq32j8nX OKfR7nRePAQsOYmxBfNLXaquLxoWypvElZv1iz0tgxb7JQo= X-Google-Smtp-Source: ABdhPJxdjayZHGtBUMOmmQEq39SaxSlDP/fbif/m1FVkvDLzGcCmPkmEJefpuNRItEOLMtKBrZc52HTweKio3BS/ZVo= X-Received: by 2002:a19:f11e:: with SMTP id p30mr4678308lfh.395.1610268400316; Sun, 10 Jan 2021 00:46:40 -0800 (PST) MIME-Version: 1.0 References: <064a4b4d6fbd6b4f7521d4f258a9397b361e41d8.camel@yasuaki.com> In-Reply-To: <064a4b4d6fbd6b4f7521d4f258a9397b361e41d8.camel@yasuaki.com> From: Vincent Legoll Date: Sun, 10 Jan 2021 09:46:29 +0100 Message-ID: Subject: Re: Add Microsoft Cascadia Code font? To: yasu Content-Type: multipart/alternative; boundary="000000000000fe730e05b887d3f7" Received-SPF: pass client-ip=2a00:1450:4864:20::132; envelope-from=vincent.legoll@gmail.com; helo=mail-lf1-x132.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Development Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.05 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fzRufURT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 86E80940414 X-Spam-Score: -2.05 X-Migadu-Scanner: scn0.migadu.com X-TUID: PU6iXbFSchHe --000000000000fe730e05b887d3f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, On Sun, Jan 10, 2021 at 9:04 AM yasu wrote: > Attached is my Guix package submission of Microsoft Cascadia Code > fonts. > > This is my very first attempt to make a Guix package contribution and I > did this in less than 30 minutes, copying the package descriptions of > IBM Plex fonts and modifying a few things. I dont' know what > protocols I may have missed =F0=9F=98=85 > > Would you please let me know how to proceed from here? > LGTM small nitpicks: * 80 columns (you can auto-format the code with etc/indent-code.el, this is documented here: https://guix.gnu.org/manual/en/html_node/Formatting-Code.html) * I've not checked the difference size (nor that it matters) between zip and tar.gz, you may want to use the smallest one to minimize download. Thanks --=20 Vincent Legoll --000000000000fe730e05b887d3f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

On Sun, Jan 10, 2021 at = 9:04 AM yasu <yasu@yasuaki.com&g= t; wrote:
Attached is my Guix package submission of Microsoft Cascadia Code
fonts.

This is my very first attempt to make a Guix package contribution and I
did this in less than 30 minutes, copying the package descriptions of
IBM Plex fonts and modifying a few things.=C2=A0 =C2=A0I dont' know wha= t
protocols I may have missed =F0=9F=98=85

Would you please let me know how to proceed from here?

LGTM

sm= all nitpicks:

* 80 columns (you can auto-format th= e code with etc/indent-code.el, this
is documented here:
https://guix.gnu.org/manual/en/html_node/Formatting-Code.html)

* I've not checked the difference size (nor that it m= atters) between zip
and tar.gz, you may want to use the smallest = one to minimize download.

Thanks

--
Vincent Legoll=
--000000000000fe730e05b887d3f7--