From: David Hashe <david.hashe@dhashe.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: webkitgtk: Fix compilation on x86_64.
Date: Tue, 5 May 2015 23:54:29 -0500 [thread overview]
Message-ID: <CAAn-YqHgprUdDPz=ax5spid8OJ6zrDumGd2CpQrShm96AVEt6w@mail.gmail.com> (raw)
In-Reply-To: <87zj5ix01j.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 1128 bytes --]
Oops! I tried it with just LIB_INSTALL_DIR, and you are correct. I've
attached a patch fixing that.
David
On Tue, May 5, 2015 at 3:05 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Hashe <david.hashe@dhashe.com> skribis:
>
> > From 65ea73868e3374d56793cde163172ad9749fe3af Mon Sep 17 00:00:00 2001
> > From: David Hashe <david.hashe@dhashe.com>
> > Date: Tue, 5 May 2015 01:48:28 -0500
> > Subject: [PATCH] gnu: webkitgtk: Fix compilation on x86_64.
> >
> > * gnu/packages/webkit.scm (webkitgtk): Move library install path from
> lib64 to
> > lib.
>
> Applied.
>
> [...]
>
> > - #:configure-flags '("-DPORT=GTK")))
> > + #:configure-flags (list
> > + "-DPORT=GTK"
> > + (string-append ; uses lib64 by default
> > + "-DLIB_INSTALL_DIR="
> > + (assoc-ref %outputs "out") "/lib"))
> > + #:make-flags '("lib=lib"))) ; uses lib64 by default
>
> Do you know if both are actually needed? I would expect LIB_INSTALL_DIR
> to be sufficient.
>
> Thank you!
>
> Ludo’.
>
[-- Attachment #1.2: Type: text/html, Size: 1768 bytes --]
[-- Attachment #2: 0001-gnu-webkitgtk-Remove-unnecessary-make-flag.patch --]
[-- Type: text/x-patch, Size: 1242 bytes --]
From 3caa6372614cbbf39d06a8d1741958e1bb92be9a Mon Sep 17 00:00:00 2001
From: David Hashe <david.hashe@dhashe.com>
Date: Tue, 5 May 2015 23:49:55 -0500
Subject: [PATCH] gnu: webkitgtk: Remove unnecessary make flag.
* gnu/packages/webkit.scm (webkitgtk): Remove make-flags.
---
gnu/packages/webkit.scm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index 873428c..9692ab0 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -55,7 +55,6 @@
(base32
"1zv030ryfwwp57yzlpr9bgpxcmc64izsxk2vsyd4kjhns9cl88bx"))))
(build-system cmake-build-system)
(arguments
'(#:tests? #f ; no tests
#:build-type "Release" ; turn off debugging symbols to save space
@@ -63,8 +62,7 @@
"-DPORT=GTK"
(string-append ; uses lib64 by default
"-DLIB_INSTALL_DIR="
- (assoc-ref %outputs "out") "/lib"))
- #:make-flags '("lib=lib"))) ; uses lib64 by default
+ (assoc-ref %outputs "out") "/lib"))))
(native-inputs
`(("bison" ,bison)
("gettext" ,gnu-gettext)
--
1.9.1
next prev parent reply other threads:[~2015-05-06 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 17:53 [PATCH] gnu: webkitgtk: Fix compilation on x86_64 David Hashe
2015-05-05 20:05 ` Ludovic Courtès
2015-05-06 4:54 ` David Hashe [this message]
2015-05-06 7:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAn-YqHgprUdDPz=ax5spid8OJ6zrDumGd2CpQrShm96AVEt6w@mail.gmail.com' \
--to=david.hashe@dhashe.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).