From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hashe Subject: Re: [PATCH] gnu: webkitgtk: Fix compilation on x86_64. Date: Tue, 5 May 2015 23:54:29 -0500 Message-ID: References: <87zj5ix01j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113ccfa62193820515629750 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YprLs-0003zL-Es for guix-devel@gnu.org; Wed, 06 May 2015 00:54:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YprLr-0004sU-6P for guix-devel@gnu.org; Wed, 06 May 2015 00:54:32 -0400 In-Reply-To: <87zj5ix01j.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel@gnu.org --001a113ccfa62193820515629750 Content-Type: multipart/alternative; boundary=001a113ccfa621937d051562974e --001a113ccfa621937d051562974e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Oops! I tried it with just LIB_INSTALL_DIR, and you are correct. I've attached a patch fixing that. David On Tue, May 5, 2015 at 3:05 PM, Ludovic Court=C3=A8s wrote: > David Hashe skribis: > > > From 65ea73868e3374d56793cde163172ad9749fe3af Mon Sep 17 00:00:00 2001 > > From: David Hashe > > Date: Tue, 5 May 2015 01:48:28 -0500 > > Subject: [PATCH] gnu: webkitgtk: Fix compilation on x86_64. > > > > * gnu/packages/webkit.scm (webkitgtk): Move library install path from > lib64 to > > lib. > > Applied. > > [...] > > > - #:configure-flags '("-DPORT=3DGTK"))) > > + #:configure-flags (list > > + "-DPORT=3DGTK" > > + (string-append ; uses lib64 by default > > + "-DLIB_INSTALL_DIR=3D" > > + (assoc-ref %outputs "out") "/lib")) > > + #:make-flags '("lib=3Dlib"))) ; uses lib64 by default > > Do you know if both are actually needed? I would expect LIB_INSTALL_DIR > to be sufficient. > > Thank you! > > Ludo=E2=80=99. > --001a113ccfa621937d051562974e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Oops! I tried it with just LIB_INSTALL_DIR, and you a= re correct. I've attached a patch fixing that.

David

On Tue, May 5= , 2015 at 3:05 PM, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
=
David Hashe <david.hashe@dhashe.com> skribis:

> From 65ea73868e3374d56793cde163172ad9749fe3af Mon Sep 17 00:00:00 2001=
> From: David Hashe <david.= hashe@dhashe.com>
> Date: Tue, 5 May 2015 01:48:28 -0500
> Subject: [PATCH] gnu: webkitgtk: Fix compilation on x86_64.
>
> * gnu/packages/webkit.scm (webkitgtk): Move library install path from = lib64 to
>=C2=A0 lib.

Applied.

[...]

> -=C2=A0 =C2=A0 =C2=A0 =C2=A0#:configure-flags '("-DPORT=3DGTK= ")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:configure-flags (list
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 "-DPORT=3DGTK"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 (string-append ; uses lib64 by default
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0"-DLIB_INSTALL_DIR=3D"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0(assoc-ref %outputs "out") "/lib= "))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:make-flags '("lib=3Dlib"))= ) ; uses lib64 by default

Do you know if both are actually needed?=C2=A0 I would expect LIB_INSTALL_D= IR
to be sufficient.

Thank you!

Ludo=E2=80=99.

--001a113ccfa621937d051562974e-- --001a113ccfa62193820515629750 Content-Type: text/x-patch; charset=US-ASCII; name="0001-gnu-webkitgtk-Remove-unnecessary-make-flag.patch" Content-Disposition: attachment; filename="0001-gnu-webkitgtk-Remove-unnecessary-make-flag.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i9c9rmt60 RnJvbSAzY2FhNjM3MjYxNGNiYmYzOWQwNmE4ZDE3NDE5NThlMWJiOTJiZTlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4K RGF0ZTogVHVlLCA1IE1heSAyMDE1IDIzOjQ5OjU1IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gZ251 OiB3ZWJraXRndGs6IFJlbW92ZSB1bm5lY2Vzc2FyeSBtYWtlIGZsYWcuCgoqIGdudS9wYWNrYWdl cy93ZWJraXQuc2NtICh3ZWJraXRndGspOiBSZW1vdmUgbWFrZS1mbGFncy4KLS0tCiBnbnUvcGFj a2FnZXMvd2Via2l0LnNjbSB8IDMgKy0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3dlYmtpdC5zY20gYi9n bnUvcGFja2FnZXMvd2Via2l0LnNjbQppbmRleCA4NzM0MjhjLi45NjkyYWIwIDEwMDY0NAotLS0g YS9nbnUvcGFja2FnZXMvd2Via2l0LnNjbQorKysgYi9nbnUvcGFja2FnZXMvd2Via2l0LnNjbQpA QCAtNTUsNyArNTUsNiBAQAogICAgICAgICAgICAgICAgKGJhc2UzMgogICAgICAgICAgICAgICAg ICIxenYwMzByeWZ3d3A1N3l6bHByOWJncHhjbWM2NGl6c3hrMnZzeWQ0a2pobnM5Y2w4OGJ4Iikp KSkKICAgICAoYnVpbGQtc3lzdGVtIGNtYWtlLWJ1aWxkLXN5c3RlbSkKICAgICAoYXJndW1lbnRz CiAgICAgICcoIzp0ZXN0cz8gI2YgOyBubyB0ZXN0cwogICAgICAgICM6YnVpbGQtdHlwZSAiUmVs ZWFzZSIgOyB0dXJuIG9mZiBkZWJ1Z2dpbmcgc3ltYm9scyB0byBzYXZlIHNwYWNlCkBAIC02Myw4 ICs2Miw3IEBACiAgICAgICAgICAgICAgICAgICAgICAgICAgICItRFBPUlQ9R1RLIgogICAgICAg ICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCA7IHVzZXMgbGliNjQgYnkgZGVmYXVs dAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIi1ETElCX0lOU1RBTExfRElSPSIKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgIChhc3NvYy1yZWYgJW91dHB1dHMgIm91dCIpICIvbGliIikp Ci0gICAgICAgIzptYWtlLWZsYWdzICcoImxpYj1saWIiKSkpIDsgdXNlcyBsaWI2NCBieSBkZWZh dWx0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXNzb2MtcmVmICVvdXRwdXRzICJvdXQi KSAiL2xpYiIpKSkpCiAgICAgKG5hdGl2ZS1pbnB1dHMKICAgICAgYCgoImJpc29uIiAsYmlzb24p CiAgICAgICAgKCJnZXR0ZXh0IiAsZ251LWdldHRleHQpCi0tIAoxLjkuMQoK --001a113ccfa62193820515629750--