From: Greg Hogan <code@greghogan.com>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: cmake-build-system: build tests only if #:tests? is true?
Date: Wed, 27 Mar 2024 11:01:33 -0400 [thread overview]
Message-ID: <CA+3U0Z=CBkYExgA=2woRjCub1bu-gkyMHqo8Sh7NV5ZdhEracg@mail.gmail.com> (raw)
In-Reply-To: <114a15c8-cdfa-3ca4-315a-45aef9b674b4@crazy-compilers.com>
On Mon, Mar 4, 2024 at 6:01 PM Hartmut Goebel
<h.goebel@crazy-compilers.com> wrote:
>
> Hi Greg,
> > I will submit a patchset shortly for review and if accepted we can
> > look to combine all the cmake patches for the large rebuild.
>
> Yes, of course we should combine them. May I ask you to take care of it
> and include mine, which I just posted:
>
> https://issues.guix.gnu.org/issue/69554
>
> Many thanks in advance.
I submitted #70031 without including this patch due to the time to
rebuild and test cmake dependencies, but will include in a v2 with any
additional post-review updates.
These patches will need to wait until core-updates is merged to
master, hopefully soon.
Greg
prev parent reply other threads:[~2024-03-27 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 21:16 cmake-build-system: build tests only if #:tests? is true? Hartmut Goebel
2024-03-02 21:23 ` Ekaitz Zarraga
2024-03-02 22:22 ` Hartmut Goebel
2024-03-04 14:10 ` Jean-Pierre De Jesus Diaz
2024-03-04 3:07 ` Maxim Cournoyer
2024-03-04 16:00 ` Greg Hogan
2024-03-04 23:01 ` Hartmut Goebel
2024-03-17 17:35 ` Ludovic Courtès
2024-03-18 8:55 ` Hartmut Goebel
2024-03-27 15:01 ` Greg Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+3U0Z=CBkYExgA=2woRjCub1bu-gkyMHqo8Sh7NV5ZdhEracg@mail.gmail.com' \
--to=code@greghogan.com \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).