Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> I have confirmed that this is the problem by replacing “while
>> (VMFile.exists(file.path))” with “while (false)”.  The build doesn’t
>> fully complete then either, but it gets past the compilation of the Ant
>> source files.  This clears JamVM and Jikes.
>
> It doesn’t.
>
> VMFile.exists always returns “true”, no matter what.  The C part is
> fine, but the Java part is not, so I suspected the JVM to be at fault.
>
> I managed to build ant-bootstrap successfully with this patch: […]

Here’s a shorter patch:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 403c446a82..bd98784232 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -152,6 +152,13 @@ and binary format defined in The Java Virtual Machine Specification.")
              "--disable-gjdoc")
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'foo
+           (lambda _
+             (substitute* "native/jni/java-io/java_io_VMFile.c"
+               (("result = cpio_isFileExists.*" m)
+                (string-append m "
+//Without a long comment the Java side will return \"true\" on x86_64 all the time.")))
+             #t))
          (add-after 'install 'install-data
            (lambda _ (invoke "make" "install-data"))))))
     (native-inputs
--8<---------------cut here---------------end--------------->8---

This only adds a comment.  If the comment is too short it won’t work.

I suspected some misguided optimizations, so I built jamvm-1-bootstrap
and classpath-bootstrap with -O0, -O1, and I disabled stripping of
binaries, but to no avail.

Any ideas?

--
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On Thu, Jul 18, 2019 at 12:51:23PM +0200, Ricardo Wurmus wrote:
> 
> This only adds a comment.  If the comment is too short it won’t work.
> 
> I suspected some misguided optimizations, so I built jamvm-1-bootstrap
> and classpath-bootstrap with -O0, -O1, and I disabled stripping of
> binaries, but to no avail.
> 
> Any ideas?
> 
> --
> Ricardo
> 

currently on bayfront on core-updates ant-bootstrap builds just fine on
i686-linux, where it fails on master. Another option could be to
bootstrap 32 bit -> 64 bit

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> currently on bayfront on core-updates ant-bootstrap builds just fine on
> i686-linux, where it fails on master. Another option could be to
> bootstrap 32 bit -> 64 bit

This would be possible, but I consider it a last resort and would very
much like to avoid having to cross-build things.

--
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:
> Here’s a shorter patch:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 403c446a82..bd98784232 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -152,6 +152,13 @@ and binary format defined in The Java Virtual Machine Specification.")
>               "--disable-gjdoc")
>         #:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'foo
> +           (lambda _
> +             (substitute* "native/jni/java-io/java_io_VMFile.c"
> +               (("result = cpio_isFileExists.*" m)
> +                (string-append m "
> +//Without a long comment the Java side will return \"true\" on x86_64 all the time.")))
> +             #t))
>           (add-after 'install 'install-data
>             (lambda _ (invoke "make" "install-data"))))))
>      (native-inputs
> --8<---------------cut here---------------end--------------->8---
>
> This only adds a comment.  If the comment is too short it won’t work.

No, that’s wrong.

To my eternal embarrassement but also great relief this substitution has
the effect of commenting the *following* line which frees up previously
claimed resources (a bunch of characters making up the file name).  The
other comments I tested must have ended on \n, so they did not have this
effect.

Thanks to Julien for pointing this out!

So!  Creating a memory leak lets us successfully build ant-bootstrap.
It does not, however, get us all the way through the Java bootstrap.
When configuring the first icedtea I get this error:

--8<---------------cut here---------------start------------->8---
checking if the VM and compiler work together... ./configure: line 9614:   697 Illegal instruction     $JAVA -classpath . $BYTECODE 1>&5 2>&1
configure: error: VM failed to run compiled class.
command "/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash" "./configure" "CONFIG_SHELL=/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash" "SHELL=/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash" "--prefix=/gnu/store/802356lxpjkqk66kv35mdzxhvaw6rghp-icedtea-1.13.13" "--enable-fast-install" "--docdir=/gnu/store/d4c4w9bka2bnnrwrmph1ilgjss5i37h9-icedtea-1.13.13-doc/share/doc/icedtea" "--build=x86_64-unknown-linux-gnu" "--enable-bootstrap" "--enable-nss" "--without-rhino" "--with-parallel-jobs" "--disable-downloading" "--disable-tests" "--with-ecj=/gnu/store/6dijv9ynn5j2bya86dgjn8v0qfd1nv3j-ecj-bootstrap-3.2.2/share/java/ecj-bootstrap.jar" "--with-jar=/gnu/store/hw67b3w83cc2abbgrf0wqzra07iiz3a1-fastjar-0.98/bin/fastjar" "--with-jdk-home=/gnu/store/1agbz95p2ljcvbb88w7p7jn2hnd6z3gv-classpath-0.99-1.e7c13ee0c" "--with-java=/gnu/store/ril2kk63p1grib14vl88z3aladfs33gf-jamvm-2.0.0/bin/jamvm" failed with status 1
--8<---------------cut here---------------end--------------->8---

Illegal instruction?  This uses JamVM 2.0.0 as the JVM.  I’ll try to
figure out what instruction this is and where it comes from.

--
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 3799 bytes --]

Hello,

Ricardo Wurmus <rekado@elephly.net> ezt írta (időpont: 2019. júl. 19., P,
8:09):

>
> Ricardo Wurmus <rekado@elephly.net> writes:
> > Here’s a shorter patch:
> >
> > --8<---------------cut here---------------start------------->8---
> > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> > index 403c446a82..bd98784232 100644
> > --- a/gnu/packages/java.scm
> > +++ b/gnu/packages/java.scm
> > @@ -152,6 +152,13 @@ and binary format defined in The Java Virtual
> Machine Specification.")
> >               "--disable-gjdoc")
> >         #:phases
> >         (modify-phases %standard-phases
> > +         (add-after 'unpack 'foo
> > +           (lambda _
> > +             (substitute* "native/jni/java-io/java_io_VMFile.c"
> > +               (("result = cpio_isFileExists.*" m)
> > +                (string-append m "
> > +//Without a long comment the Java side will return \"true\" on x86_64
> all the time.")))
> > +             #t))
> >           (add-after 'install 'install-data
> >             (lambda _ (invoke "make" "install-data"))))))
> >      (native-inputs
> > --8<---------------cut here---------------end--------------->8---
> >
> > This only adds a comment.  If the comment is too short it won’t work.
>
>
I confirm this path works.
I tested a modified version, where I took out the comment text. It also
works that way.
We might contact the classpath devs to get a proper fix, and maybe a new
release, they
were super responsive the last time.


> No, that’s wrong.
>
> To my eternal embarrassement but also great relief this substitution has
> the effect of commenting the *following* line which frees up previously
> claimed resources (a bunch of characters making up the file name).  The
> other comments I tested must have ended on \n, so they did not have this
> effect.
>
> Thanks to Julien for pointing this out!
>
> So!  Creating a memory leak lets us successfully build ant-bootstrap.
> It does not, however, get us all the way through the Java bootstrap.
> When configuring the first icedtea I get this error:
>
> --8<---------------cut here---------------start------------->8---
> checking if the VM and compiler work together... ./configure: line 9614:
>  697 Illegal instruction     $JAVA -classpath . $BYTECODE 1>&5 2>&1
> configure: error: VM failed to run compiled class.
> command
> "/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash"
> "./configure"
> "CONFIG_SHELL=/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash"
> "SHELL=/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash"
> "--prefix=/gnu/store/802356lxpjkqk66kv35mdzxhvaw6rghp-icedtea-1.13.13"
> "--enable-fast-install"
> "--docdir=/gnu/store/d4c4w9bka2bnnrwrmph1ilgjss5i37h9-icedtea-1.13.13-doc/share/doc/icedtea"
> "--build=x86_64-unknown-linux-gnu" "--enable-bootstrap" "--enable-nss"
> "--without-rhino" "--with-parallel-jobs" "--disable-downloading"
> "--disable-tests"
> "--with-ecj=/gnu/store/6dijv9ynn5j2bya86dgjn8v0qfd1nv3j-ecj-bootstrap-3.2.2/share/java/ecj-bootstrap.jar"
> "--with-jar=/gnu/store/hw67b3w83cc2abbgrf0wqzra07iiz3a1-fastjar-0.98/bin/fastjar"
> "--with-jdk-home=/gnu/store/1agbz95p2ljcvbb88w7p7jn2hnd6z3gv-classpath-0.99-1.e7c13ee0c"
> "--with-java=/gnu/store/ril2kk63p1grib14vl88z3aladfs33gf-jamvm-2.0.0/bin/jamvm"
> failed with status 1
> --8<---------------cut here---------------end--------------->8---
>
> Illegal instruction?  This uses JamVM 2.0.0 as the JVM.  I’ll try to
> figure out what instruction this is and where it comes from.
>

I hit the same bug now.


> --
> Ricardo
>
>
>
Best regards,
g_bor

-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

[-- Attachment #2: Type: text/html, Size: 5147 bytes --]

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Hi Gábor,

> Ricardo Wurmus <rekado@elephly.net> ezt írta (időpont: 2019. júl. 19., P,
> 8:09):
>
>>
>> Ricardo Wurmus <rekado@elephly.net> writes:
>> > Here’s a shorter patch:
>> >
>> > --8<---------------cut here---------------start------------->8---
>> > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> > index 403c446a82..bd98784232 100644
>> > --- a/gnu/packages/java.scm
>> > +++ b/gnu/packages/java.scm
>> > @@ -152,6 +152,13 @@ and binary format defined in The Java Virtual
>> Machine Specification.")
>> >               "--disable-gjdoc")
>> >         #:phases
>> >         (modify-phases %standard-phases
>> > +         (add-after 'unpack 'foo
>> > +           (lambda _
>> > +             (substitute* "native/jni/java-io/java_io_VMFile.c"
>> > +               (("result = cpio_isFileExists.*" m)
>> > +                (string-append m "
>> > +//Without a long comment the Java side will return \"true\" on x86_64
>> all the time.")))
>> > +             #t))
>> >           (add-after 'install 'install-data
>> >             (lambda _ (invoke "make" "install-data"))))))
>> >      (native-inputs
>> > --8<---------------cut here---------------end--------------->8---
>> >
>> > This only adds a comment.  If the comment is too short it won’t work.
>>
>>
> I confirm this path works.
> I tested a modified version, where I took out the comment text. It also
> works that way.

Yes.  It’s just commenting the *following* line (i.e. removal of the
call to “free”) that fixes it.

> We might contact the classpath devs to get a proper fix, and maybe a new
> release, they
> were super responsive the last time.

I don’t think the problem is with GNU Classpath.  Classpath devs are
welcome to look at this, of course, but we are not even using the latest
version at this point in the bootstrap.

I wonder what could have caused this problem in the first place.  The
bootstrap hasn’t changed.  Using the same compiler as before doesn’t fix
it, so it’s probably not the compiler either.  So what is it?

>> Illegal instruction?  This uses JamVM 2.0.0 as the JVM.  I’ll try to
>> figure out what instruction this is and where it comes from.
>
> I hit the same bug now.

Good.  We need to figure out why – is it miscompilation?  Tuning to a
different CPU type…?

--
Ricardo

bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

>>> Illegal instruction?  This uses JamVM 2.0.0 as the JVM.  I’ll try to
>>> figure out what instruction this is and where it comes from.
>>
>> I hit the same bug now.
>
> Good.  We need to figure out why – is it miscompilation?  Tuning to a
> different CPU type…?

With this patch I can get past the configure phase in icedtea:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 403c446a82..14179f85e9 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -116,6 +116,9 @@
                (base32
                 "1qqldrp74pzpy5ly421srqn30qppmm9cvjiqdngk8hf47dv2rc0c"))))
     (build-system gnu-build-system)
+    (native-inputs
+     `(("libc" ,glibc-2.28)
+       ("gcc" ,gcc-5)))
     (home-page "http://jikes.sourceforge.net/")
     (synopsis "Compiler for the Java language")
     (description "Jikes is a compiler that translates Java source files as
@@ -152,12 +155,20 @@ and binary format defined in The Java Virtual Machine Specification.")
              "--disable-gjdoc")
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'foo
+           (lambda _
+             (substitute* "native/jni/java-io/java_io_VMFile.c"
+               (("result = cpio_isFileExists.*" m)
+                (string-append m "\n//")))
+             #t))
          (add-after 'install 'install-data
            (lambda _ (invoke "make" "install-data"))))))
     (native-inputs
      `(("jikes" ,jikes)
        ("fastjar" ,fastjar)
        ("libltdl" ,libltdl)
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)
        ("pkg-config" ,pkg-config)))
     (home-page "https://www.gnu.org/software/classpath/")
     (synopsis "Essential libraries for Java")
@@ -191,6 +202,9 @@ language.")
      `(("classpath" ,classpath-bootstrap)
        ("jikes" ,jikes)
        ("zlib" ,zlib)))
+    (native-inputs
+     `(("libc" ,glibc-2.28)
+       ("gcc" ,gcc-5)))
     (home-page "http://jamvm.sourceforge.net/")
     (synopsis "Small Java Virtual Machine")
     (description "JamVM is a Java Virtual Machine conforming to the JVM
@@ -302,7 +316,9 @@ JNI.")
      `(("jikes" ,jikes)
        ("jamvm" ,jamvm-1-bootstrap)
        ("unzip" ,unzip)
-       ("zip" ,zip)))
+       ("zip" ,zip)
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)))
     (home-page "http://ant.apache.org")
     (synopsis "Build tool for Java")
     (description
@@ -627,7 +643,9 @@ machine.")))
          ("fastjar" ,fastjar)
          ("jamvm" ,jamvm-1-bootstrap)
          ("libltdl" ,libltdl)
-         ("pkg-config" ,pkg-config))))))
+         ("pkg-config" ,pkg-config)
+         ("gcc" ,gcc-5)
+         ("libc" ,glibc-2.28))))))

 (define jamvm
   (package (inherit jamvm-1-bootstrap)
@@ -656,7 +674,9 @@ machine.")))
      `(("guile" ,guile-2.2)
        ("ecj-bootstrap" ,ecj-bootstrap)
        ("jamvm" ,jamvm)
-       ("classpath" ,classpath-devel)))))
+       ("classpath" ,classpath-devel)
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)))))

 ;; The bootstrap JDK consisting of jamvm, classpath-devel,
 ;; ecj-javac-wrapper-final cannot build Icedtea 2.x directly, because it's
@@ -907,7 +927,10 @@ machine.")))
        ("fastjar" ,fastjar)
        ("fontconfig" ,fontconfig)
        ("freetype" ,freetype)
-       ("gcc" ,gcc-4.9) ; there's a segmentation fault when compiling with gcc-5 or gcc-7
+       ;;("gcc" ,gcc-4.9) ; there's a segmentation fault when compiling with gcc-5 or gcc-7
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)
+
        ("gtk" ,gtk+-2)
        ("gawk" ,gawk)
        ("giflib" ,giflib)
--8<---------------cut here---------------end--------------->8---

The build aborts early with “ERROR: FreeType version 2.2.1 or higher is
required.”  So I added this:

  (substitute* "patches/freetypeversion.patch"
   (("REQUIRED_FREETYPE_VERSION = 2.2.1")
    "REQUIRED_FREETYPE_VERSION = 2.10.1"))

and icedtea is being built now.

We may want to check where the use of glibc-2.28 and gcc-5 is really
needed and where we can do without.

--
Ricardo

bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

> The build aborts early with “ERROR: FreeType version 2.2.1 or higher is
> required.”  So I added this:
>
>   (substitute* "patches/freetypeversion.patch"
>    (("REQUIRED_FREETYPE_VERSION = 2.2.1")
>     "REQUIRED_FREETYPE_VERSION = 2.10.1"))
>
> and icedtea is being built now.

Next problem: icedtea 2 fails its configure phase:

--8<---------------cut here---------------start------------->8---
checking attr/xattr.h usability... no
checking attr/xattr.h presence... no
checking for attr/xattr.h... no
configure: error: Could not find required system headers; install the appropriate files from glibc-headers, libc6-dev and/or libattr-devel, libattr1-dev or use --disable-compile-against-syscalls if necessary.
command "/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash" "./configure" "CONFIG_SHELL=/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash" "SHELL=/gnu/store/h9c5g3inn5zmkixk08m27zzpj58zbfgy-bash-minimal-5.0.7/bin/bash" "--prefix=/gnu/store/wg3ywf88n2qd1hpc8fk39svm9ksah1l4-icedtea-2.6.13" "--enable-fast-install" "--docdir=/gnu/store/4l3xf1dmbx9494ica8cgllm6dvs3py2n-icedtea-2.6.13-doc/share/doc/icedtea" "--build=x86_64-unknown-linux-gnu" "--disable-system-pcsc" "--disable-system-sctp" "--enable-bootstrap" "--enable-nss" "--without-rhino" "--disable-downloading" "--disable-tests" "--with-openjdk-src-dir=./openjdk.src" "--with-jdk-home=/gnu/store/r4jz94v5xjxw95s0msxdxm36hlv07x64-icedtea-1.13.13-jdk" failed with status 1
builder for `/gnu/store/cda07il6lpg0j9l8blx5z8ah8d7wmjlz-icedtea-2.6.13.drv' failed with exit code 1
build of /gnu/store/cda07il6lpg0j9l8blx5z8ah8d7wmjlz-icedtea-2.6.13.drv failed
--8<---------------cut here---------------end--------------->8---

Of course the inputs include the attr package.  Any ideas?

--
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Julien Lepiller]

Le Sat, 20 Jul 2019 10:42:25 +0200,
Ricardo Wurmus <rekado@elephly.net> a écrit :

> configure: error: Could not find required system headers; install the
> appropriate files from glibc-headers, libc6-dev and/or libattr-devel,
> libattr1-dev or use --disable-compile-against-syscalls if necessary.

Can you check the content of config.log? It should tell you what test
it runs to determine whether attr is present or not.

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Julien Lepiller <julien@lepiller.eu> writes:

> Le Sat, 20 Jul 2019 10:42:25 +0200,
> Ricardo Wurmus <rekado@elephly.net> a écrit :
>
>> configure: error: Could not find required system headers; install the
>> appropriate files from glibc-headers, libc6-dev and/or libattr-devel,
>> libattr1-dev or use --disable-compile-against-syscalls if necessary.
>
> Can you check the content of config.log? It should tell you what test
> it runs to determine whether attr is present or not.

It’s pretty straight-forward: xattr.h is no longer provided by the attr
package.  sys/xattr.h from glibc should be used instead, so I’ve patched
it.

I fixed another problem in the icedtea 2 build and moved on.  Let’s see
how far I’ll get this time.  In the meantime it would be great to reach
consensus on whether we should shrug off the patch that introduces a
memory leak in GNU Classpath 0.93 as part of the bootstrap or if we
should spend more time trying to figure out how we can avoid it.

--
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

So, with the following change I was able to build all the way up to the
latest openjdk.  Should we use it despite the introduction of a memory
leak in a bootstrap JVM?  Can we make the patch smaller (fewer uses of
glibc 2.28 or gcc-5)?

What do you think?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: java.diff --]
[-- Type: text/x-patch, Size: 5143 bytes --]

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 403c446a82..60363d60c3 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -116,6 +116,9 @@
                (base32
                 "1qqldrp74pzpy5ly421srqn30qppmm9cvjiqdngk8hf47dv2rc0c"))))
     (build-system gnu-build-system)
+    (native-inputs
+     `(("libc" ,glibc-2.28)
+       ("gcc" ,gcc-5)))
     (home-page "http://jikes.sourceforge.net/")
     (synopsis "Compiler for the Java language")
     (description "Jikes is a compiler that translates Java source files as
@@ -152,12 +155,20 @@ and binary format defined in The Java Virtual Machine Specification.")
              "--disable-gjdoc")
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'foo
+           (lambda _
+             (substitute* "native/jni/java-io/java_io_VMFile.c"
+               (("result = cpio_isFileExists.*" m)
+                (string-append m "\n//")))
+             #t))
          (add-after 'install 'install-data
            (lambda _ (invoke "make" "install-data"))))))
     (native-inputs
      `(("jikes" ,jikes)
        ("fastjar" ,fastjar)
        ("libltdl" ,libltdl)
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)
        ("pkg-config" ,pkg-config)))
     (home-page "https://www.gnu.org/software/classpath/")
     (synopsis "Essential libraries for Java")
@@ -191,6 +202,9 @@ language.")
      `(("classpath" ,classpath-bootstrap)
        ("jikes" ,jikes)
        ("zlib" ,zlib)))
+    (native-inputs
+     `(("libc" ,glibc-2.28)
+       ("gcc" ,gcc-5)))
     (home-page "http://jamvm.sourceforge.net/")
     (synopsis "Small Java Virtual Machine")
     (description "JamVM is a Java Virtual Machine conforming to the JVM
@@ -302,7 +316,9 @@ JNI.")
      `(("jikes" ,jikes)
        ("jamvm" ,jamvm-1-bootstrap)
        ("unzip" ,unzip)
-       ("zip" ,zip)))
+       ("zip" ,zip)
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)))
     (home-page "http://ant.apache.org")
     (synopsis "Build tool for Java")
     (description
@@ -627,7 +643,9 @@ machine.")))
          ("fastjar" ,fastjar)
          ("jamvm" ,jamvm-1-bootstrap)
          ("libltdl" ,libltdl)
-         ("pkg-config" ,pkg-config))))))
+         ("pkg-config" ,pkg-config)
+         ("gcc" ,gcc-5)
+         ("libc" ,glibc-2.28))))))
 
 (define jamvm
   (package (inherit jamvm-1-bootstrap)
@@ -656,7 +674,9 @@ machine.")))
      `(("guile" ,guile-2.2)
        ("ecj-bootstrap" ,ecj-bootstrap)
        ("jamvm" ,jamvm)
-       ("classpath" ,classpath-devel)))))
+       ("classpath" ,classpath-devel)
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)))))
 
 ;; The bootstrap JDK consisting of jamvm, classpath-devel,
 ;; ecj-javac-wrapper-final cannot build Icedtea 2.x directly, because it's
@@ -740,6 +760,9 @@ machine.")))
              (with-directory-excursion "openjdk"
                (invoke "tar" "xvf" (assoc-ref inputs "hotspot-src"))
                (rename-file "hg-checkout" "hotspot"))
+             (substitute* "patches/freetypeversion.patch"
+               (("REQUIRED_FREETYPE_VERSION = 2.2.1")
+                "REQUIRED_FREETYPE_VERSION = 2.10.1"))
              (substitute* "Makefile.in"
                (("echo \"ERROR: No up-to-date OpenJDK zip available\"; exit -1;")
                 "echo \"trust me\";")
@@ -907,7 +930,8 @@ machine.")))
        ("fastjar" ,fastjar)
        ("fontconfig" ,fontconfig)
        ("freetype" ,freetype)
-       ("gcc" ,gcc-4.9) ; there's a segmentation fault when compiling with gcc-5 or gcc-7
+       ("gcc" ,gcc-5)
+       ("libc" ,glibc-2.28)
        ("gtk" ,gtk+-2)
        ("gawk" ,gawk)
        ("giflib" ,giflib)
@@ -1107,6 +1131,18 @@ bootstrapping purposes.")
                                             ((name . _) name))
                                           inputs))))
                  #t)))
+           (add-after 'unpack 'patch-bitrot
+             (lambda _
+               (substitute* '("patches/boot/revert-6973616.patch"
+                              "openjdk.src/jdk/make/common/shared/Defs-versions.gmk")
+                 (("REQUIRED_FREETYPE_VERSION = 2.2.1")
+                  "REQUIRED_FREETYPE_VERSION = 2.10.1"))
+               ;; As of attr 2.4.48 this header is no longer
+               ;; included.  It is provided by the libc instead.
+               (substitute* '("configure"
+                              "openjdk.src/jdk/src/solaris/native/sun/nio/fs/LinuxNativeDispatcher.c")
+                 (("attr/xattr.h") "sys/xattr.h"))
+               #t))
            (add-after 'unpack 'fix-x11-extension-include-path
              (lambda* (#:key inputs #:allow-other-keys)
                (substitute* "openjdk.src/jdk/make/sun/awt/mawt.gmk"
@@ -1586,6 +1622,7 @@ IcedTea build harness.")
                  (delete 'patch-paths)
                  (delete 'set-additional-paths)
                  (delete 'patch-patches)
+                 (delete 'patch-bitrot)
                  ;; Prevent the keytool from recording the current time when
                  ;; adding certificates at build time.
                  (add-after 'unpack 'patch-keystore

[-- Attachment #3: Type: text/plain, Size: 12 bytes --]


--
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hello,

Ricardo Wurmus <rekado@elephly.net> ezt írta (időpont: 2019. júl. 21., Vas
13:29):

> So, with the following change I was able to build all the way up to the
> latest openjdk.  Should we use it despite the introduction of a memory
> leak in a bootstrap JVM?  Can we make the patch smaller (fewer uses of
> glibc 2.28 or gcc-5)?
>
> What do you think?
>

I will have a look at reducing the patch later today. I will report back
tomorrow morning with the results.


>
> --
> Ricardo
>

[-- Attachment #2: Type: text/html, Size: 1040 bytes --]

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Hi Gábor,

>> So, with the following change I was able to build all the way up to the
>> latest openjdk.  Should we use it despite the introduction of a memory
>> leak in a bootstrap JVM?  Can we make the patch smaller (fewer uses of
>> glibc 2.28 or gcc-5)?
>>
>> What do you think?
>>
>
> I will have a look at reducing the patch later today. I will report back
> tomorrow morning with the results.

Did you have any luck with this?

-- 
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

>>> So, with the following change I was able to build all the way up to the
>>> latest openjdk.  Should we use it despite the introduction of a memory
>>> leak in a bootstrap JVM?  Can we make the patch smaller (fewer uses of
>>> glibc 2.28 or gcc-5)?
>>>
>>> What do you think?
>>>
>>
>> I will have a look at reducing the patch later today. I will report back
>> tomorrow morning with the results.
>
> Did you have any luck with this?

We should decide soon, because core-updates is about to be merged
(finally!) – any objections to my earlier patch?

-- 
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Ricardo Wurmus <rekado@elephly.net> ezt írta (időpont: 2019. szept. 6., Pén
15:40):

>
> Ricardo Wurmus <rekado@elephly.net> writes:
>
> >>> So, with the following change I was able to build all the way up to the
> >>> latest openjdk.  Should we use it despite the introduction of a memory
> >>> leak in a bootstrap JVM?  Can we make the patch smaller (fewer uses of
> >>> glibc 2.28 or gcc-5)?
> >>>
> >>> What do you think?
> >>>
> >>
> >> I will have a look at reducing the patch later today. I will report back
> >> tomorrow morning with the results.
> >
> > Did you have any luck with this?
>
> We should decide soon, because core-updates is about to be merged
> (finally!) – any objections to my earlier patch?
>

No objection from here.

>
> --
> Ricardo
>
g_bor

>

[-- Attachment #2: Type: text/html, Size: 1684 bytes --]

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Ricardo Wurmus]

I reduced the patch and built openjdk once more to test that it all
works.  I pushed the changes in a series of commits ending with
6b7e09ae6b to core-updates.

--
Ricardo

Re: bug#36685: ant-bootstrap fails on core-updates (409 dependents)

[Julien Lepiller]

Le 7 septembre 2019 16:28:37 GMT+02:00, Ricardo Wurmus <rekado@elephly.net> a écrit :
>
>I reduced the patch and built openjdk once more to test that it all
>works.  I pushed the changes in a series of commits ending with
>6b7e09ae6b to core-updates.
>
>--
>Ricardo

Chank you for all that work!