From: ludo@gnu.org (Ludovic Courtès)
To: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add cmatrix.
Date: Tue, 01 Jul 2014 14:11:09 +0200 [thread overview]
Message-ID: <87zjgtqnxe.fsf@gnu.org> (raw)
In-Reply-To: <87fvilqqwb.fsf@gmail.com> (Cyrill Schenkel's message of "Tue, 01 Jul 2014 13:07:00 +0200")
Cyrill Schenkel <cyrill.schenkel@gmail.com> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Also, what about putting it in games.scm instead?
>
> Done.
>
>>> + (build-system gnu-build-system)
>>> + (arguments
>>> + '(#:phases
>>> + (alist-cons-before
>>> + 'patch-source-shebangs 'autoreconf
>>> + (lambda args
>>> + (system* "autoreconf" "-fi"))
>>> + %standard-phases)))
>>
>> This shouldn’t be needed because the tarballs includes ./configure,
>> Makefile.in, etc.
>
> Actually it is needed because the configure which comes with the tarball
> was generated with a very old version of autotools and doesn't support
> the passing of variables (like SHELL).
Ah sorry. Still, in that case, it’s easier to just override the
‘configure’ phase as done in time.scm:
(alist-replace 'configure
(lambda* (#:key outputs #:allow-other-keys)
;; This old `configure' script doesn't support
;; variables passed as arguments.
(let ((out (assoc-ref outputs "out")))
(setenv "CONFIG_SHELL" (which "bash"))
(zero?
(system* "./configure"
(string-append "--prefix=" out)))))
%standard-phases)
Could you do that?
Thanks, and sorry for the round trips.
Ludo’.
prev parent reply other threads:[~2014-07-01 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 10:05 [PATCH] gnu: Add cmatrix Cyrill Schenkel
2014-07-01 10:28 ` Ludovic Courtès
2014-07-01 11:07 ` Cyrill Schenkel
2014-07-01 12:11 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjgtqnxe.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=cyrill.schenkel@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).