From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add cmatrix.
Date: Tue, 01 Jul 2014 14:11:09 +0200
Message-ID: <87zjgtqnxe.fsf@gnu.org>
References: <87k37xqtr3.fsf@gmail.com> <87egy5z83r.fsf@gnu.org>
	<87fvilqqwb.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1wu5-0001Bh-Lk
	for guix-devel@gnu.org; Tue, 01 Jul 2014 08:11:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1wu0-0001MO-8N
	for guix-devel@gnu.org; Tue, 01 Jul 2014 08:11:17 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:55632)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1X1wu0-0001ME-0z
	for guix-devel@gnu.org; Tue, 01 Jul 2014 08:11:12 -0400
In-Reply-To: <87fvilqqwb.fsf@gmail.com> (Cyrill Schenkel's message of "Tue, 01
	Jul 2014 13:07:00 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Cyrill Schenkel <cyrill.schenkel@gmail.com> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> Also, what about putting it in games.scm instead?
>
> Done.
>
>>> +    (build-system gnu-build-system)
>>> +    (arguments
>>> +     '(#:phases
>>> +       (alist-cons-before
>>> +        'patch-source-shebangs 'autoreconf
>>> +        (lambda args
>>> +          (system* "autoreconf" "-fi"))
>>> +        %standard-phases)))
>>
>> This shouldn=E2=80=99t be needed because the tarballs includes ./configu=
re,
>> Makefile.in, etc.
>
> Actually it is needed because the configure which comes with the tarball
> was generated with a very old version of autotools and doesn't support
> the passing of variables (like SHELL).=20

Ah sorry.  Still, in that case, it=E2=80=99s easier to just override the
=E2=80=98configure=E2=80=99 phase as done in time.scm:

       (alist-replace 'configure
                      (lambda* (#:key outputs #:allow-other-keys)
                        ;; This old `configure' script doesn't support
                        ;; variables passed as arguments.
                        (let ((out (assoc-ref outputs "out")))
                          (setenv "CONFIG_SHELL" (which "bash"))
                          (zero?
                           (system* "./configure"
                                    (string-append "--prefix=3D" out)))))
                      %standard-phases)

Could you do that?

Thanks, and sorry for the round trips.

Ludo=E2=80=99.