Re: [PATCH] gnu: Do not skip generation of documentation

[ludo@gnu.org (Ludovic Courtès)]

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/docbook.scm (docbook-xml): Substitute remote uris by local ones
> * gnu/packages/docbook.scm (docbook-xml-4.4, docbook-xml-4.3): New variables.
> * gnu/packages/docbook.scm (docbook-xsl): Update to version 1.78.1, and substitute
> 	remote uris with local ones.

Please don’t repeat the file name, and don’t introduce extra spaces
(info "(standard) Style of Change Logs").

> * gnu/packages/gnome.scm (gnome-doc-utils): Do not skip tests.

Could you make this one a separate patch?

> * gnu/packages/web.scm (tinyproxy): Cleanup XML_CATALOG_FILES workaround.

And this one too?

> +          (setenv "XML_CATALOG_FILES" 
> +                  (string-append
> +                   (assoc-ref inputs "docbook-xsl") "/xml/xsl/docbook-xsl-1.78.1/catalog.xml"
> +                   " "  ; This must be a space, not a : (contrary to the documentation)
> +                   (assoc-ref inputs "docbook-xml") "/xml/dtd/docbook/catalog.xml"
> +                   )))

Move the closing parents at the end of the previous line.

Otherwise looks OK.

Thanks,
Ludo’.