From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Do not skip generation of documentation
Date: Sun, 13 Jul 2014 15:33:05 +0200
Message-ID: <87zjgdcrji.fsf@gnu.org>
References: <1405179023-5601-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42827)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X6Jtw-0006HO-TS
	for guix-devel@gnu.org; Sun, 13 Jul 2014 09:33:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X6Jtr-0003P1-EP
	for guix-devel@gnu.org; Sun, 13 Jul 2014 09:33:12 -0400
In-Reply-To: <1405179023-5601-1-git-send-email-jmd@gnu.org> (John Darrington's
	message of "Sat, 12 Jul 2014 17:30:23 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/docbook.scm (docbook-xml): Substitute remote uris by local=
 ones
> * gnu/packages/docbook.scm (docbook-xml-4.4, docbook-xml-4.3): New variab=
les.
> * gnu/packages/docbook.scm (docbook-xsl): Update to version 1.78.1, and s=
ubstitute
> 	remote uris with local ones.

Please don=E2=80=99t repeat the file name, and don=E2=80=99t introduce extr=
a spaces
(info "(standard) Style of Change Logs").

> * gnu/packages/gnome.scm (gnome-doc-utils): Do not skip tests.

Could you make this one a separate patch?

> * gnu/packages/web.scm (tinyproxy): Cleanup XML_CATALOG_FILES workaround.

And this one too?

> +          (setenv "XML_CATALOG_FILES"=20
> +                  (string-append
> +                   (assoc-ref inputs "docbook-xsl") "/xml/xsl/docbook-xs=
l-1.78.1/catalog.xml"
> +                   " "  ; This must be a space, not a : (contrary to the=
 documentation)
> +                   (assoc-ref inputs "docbook-xml") "/xml/dtd/docbook/ca=
talog.xml"
> +                   )))

Move the closing parents at the end of the previous line.

Otherwise looks OK.

Thanks,
Ludo=E2=80=99.