From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: python-pycairo: Fix build with with python-3.4.3.
Date: Fri, 24 Apr 2015 10:29:54 +0200 [thread overview]
Message-ID: <87zj5yylml.fsf@mango.localdomain> (raw)
In-Reply-To: <87d22ud5kk.fsf@gnu.org>
Ludovic Courtès writes:
> 宋文武 <iyzsong@gmail.com> skribis:
>
>> From 9a83f762e5f5479a9efedefc6fea9c37a49bb87e Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
>> Date: Mon, 20 Apr 2015 13:45:43 +0800
>> Subject: [PATCH] gnu: python-pycairo: Fix build with with python-3.4.3.
>>
>> * gnu/packages/patches/pycairo-wscript.patch: New file.
>> * gnu-system.am (dist_patch_DATA): Add it.
>> * gnu/packages/gtk.scm (python-pycairo)[source]: Use it.
>> [build-system]: Use waf-build-system.
>> [native-inputs]: Add python-waf.
>> [arguments]<#:phases>: Use 'modify-phases'. Add 'patch-waf phase.
>> * gnu/packages/gtk.scm (python2-pycairo): Adjust accordingly.
>
> Ricardo certainly knows this better, but it LGTM.
Also looks good to me.
Thanks!
~~ Ricardo
prev parent reply other threads:[~2015-04-24 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 5:52 [PATCH 1/2] gnu: Add python-waf 宋文武
2015-04-20 5:52 ` [PATCH 2/2] gnu: python-pycairo: Fix build with with python-3.4.3 宋文武
2015-04-20 6:32 ` Ricardo Wurmus
2015-04-20 6:51 ` 宋文武
2015-04-23 19:10 ` Ludovic Courtès
2015-04-24 8:29 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj5yylml.fsf@mango.localdomain \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).