From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 2/2] gnu: python-pycairo: Fix build with with python-3.4.3.
Date: Fri, 24 Apr 2015 10:29:54 +0200
Message-ID: <87zj5yylml.fsf@mango.localdomain>
References: <1429509136-11290-1-git-send-email-iyzsong@gmail.com>
	<1429509136-11290-2-git-send-email-iyzsong@gmail.com>
	<871tjf2u1p.fsf@mango.localdomain> <87r3rf70n2.fsf@gmail.com>
	<87d22ud5kk.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1YlYzu-0006Hj-1a
	for guix-devel@gnu.org; Fri, 24 Apr 2015 04:30:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1YlYzt-0001tj-C9
	for guix-devel@gnu.org; Fri, 24 Apr 2015 04:30:06 -0400
In-reply-to: <87d22ud5kk.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org


Ludovic Courtès writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> From 9a83f762e5f5479a9efedefc6fea9c37a49bb87e Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
>> Date: Mon, 20 Apr 2015 13:45:43 +0800
>> Subject: [PATCH] gnu: python-pycairo: Fix build with with python-3.4.3.
>>
>> * gnu/packages/patches/pycairo-wscript.patch: New file.
>> * gnu-system.am (dist_patch_DATA): Add it.
>> * gnu/packages/gtk.scm (python-pycairo)[source]: Use it.
>>   [build-system]: Use waf-build-system.
>>   [native-inputs]: Add python-waf.
>>   [arguments]<#:phases>: Use 'modify-phases'.  Add 'patch-waf phase.
>> * gnu/packages/gtk.scm (python2-pycairo): Adjust accordingly.
>
> Ricardo certainly knows this better, but it LGTM.

Also looks good to me.
Thanks!

~~ Ricardo