From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add GnuCash.
Date: Wed, 06 May 2015 10:58:03 +0200 [thread overview]
Message-ID: <87zj5it750.fsf@gnu.org> (raw)
In-Reply-To: <871tiuw6df.fsf@mango.localdomain> (Ricardo Wurmus's message of "Wed, 06 May 2015 08:46:20 +0200")
Ricardo Wurmus <rekado@elephly.net> skribis:
> From a2ea83cfe3fab5101388870626c323191200c066 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 6 May 2015 08:38:06 +0200
> Subject: [PATCH 1/2] gnu: Add WebkitGTK 2.4.8.
>
> * gnu/packages/webkit.scm (webkitgtk-2.4): New variable.
> * gnu/packages/patches/webkitgtk-2.4.8-gmutexlocker.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
[...]
> +++ b/gnu/packages/patches/webkitgtk-2.4.8-gmutexlocker.patch
> @@ -0,0 +1,284 @@
> +Webkit's own WebCore::GMutexLocker conflicts with the GMutexLocker in
> +glib-2.44.0.
[...]
> + ;; Patch taken from <http://pkgs.fedoraproject.org/cgit/
> + ;; webkitgtk3.git/plain/webkitgtk-2.4.8-gmutexlocker.patch
> + ;; ?id=7433f334cc84866af5ef0b2c25ead931e6e603ea>
> + (patches (list (search-patch "webkitgtk-2.4.8-gmutexlocker.patch")))))
Please move this comment to the beginning of the .patch file.
Otherwise OK.
> From 23ff763f1492f0e5694ed514b888410df7620c2c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 6 May 2015 08:41:40 +0200
> Subject: [PATCH 2/2] gnu: Add GnuCash.
>
> * gnu/packages/gnucash.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> + (inputs
> + `(("guile" ,guile-2.0)
> + ("intltool" ,intltool)
> + ("icu4c" ,icu4c)
> + ("glib" ,glib)
> + ("glib" ,glib "bin") ; glib-compile-schemas, etc.
intltool and glib:bin should be native inputs.
OK to push with this change!
Ludo’.
prev parent reply other threads:[~2015-05-06 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 6:46 [PATCH] Add GnuCash Ricardo Wurmus
2015-05-06 7:05 ` Ricardo Wurmus
2015-05-06 8:58 ` Ludovic Courtès
2015-05-06 8:58 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj5it750.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).