From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add GnuCash.
Date: Wed, 06 May 2015 10:58:03 +0200
Message-ID: <87zj5it750.fsf@gnu.org>
References: <871tiuw6df.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40027)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Ypv9f-0000Hy-C3
	for guix-devel@gnu.org; Wed, 06 May 2015 04:58:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Ypv9a-0004Wa-VH
	for guix-devel@gnu.org; Wed, 06 May 2015 04:58:11 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60105)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Ypv9a-0004WW-SY
	for guix-devel@gnu.org; Wed, 06 May 2015 04:58:06 -0400
In-Reply-To: <871tiuw6df.fsf@mango.localdomain> (Ricardo Wurmus's message of
	"Wed, 06 May 2015 08:46:20 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <rekado@elephly.net> skribis:

> From a2ea83cfe3fab5101388870626c323191200c066 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 6 May 2015 08:38:06 +0200
> Subject: [PATCH 1/2] gnu: Add WebkitGTK 2.4.8.
>
> * gnu/packages/webkit.scm (webkitgtk-2.4): New variable.
> * gnu/packages/patches/webkitgtk-2.4.8-gmutexlocker.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

[...]

> +++ b/gnu/packages/patches/webkitgtk-2.4.8-gmutexlocker.patch
> @@ -0,0 +1,284 @@
> +Webkit's own WebCore::GMutexLocker conflicts with the GMutexLocker in
> +glib-2.44.0.

[...]

> +              ;; Patch taken from <http://pkgs.fedoraproject.org/cgit/
> +              ;; webkitgtk3.git/plain/webkitgtk-2.4.8-gmutexlocker.patch
> +              ;; ?id=3D7433f334cc84866af5ef0b2c25ead931e6e603ea>
> +              (patches (list (search-patch "webkitgtk-2.4.8-gmutexlocker=
.patch")))))

Please move this comment to the beginning of the .patch file.

Otherwise OK.

> From 23ff763f1492f0e5694ed514b888410df7620c2c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 6 May 2015 08:41:40 +0200
> Subject: [PATCH 2/2] gnu: Add GnuCash.
>
> * gnu/packages/gnucash.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +    (inputs
> +     `(("guile" ,guile-2.0)
> +       ("intltool" ,intltool)
> +       ("icu4c" ,icu4c)
> +       ("glib" ,glib)
> +       ("glib" ,glib "bin") ; glib-compile-schemas, etc.

intltool and glib:bin should be native inputs.

OK to push with this change!

Ludo=E2=80=99.