* Scheme test driver should use ‘write’
@ 2016-05-22 20:36 Ludovic Courtès
2016-05-24 13:46 ` Mathieu Lirzin
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2016-05-22 20:36 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: Guix-devel
Hi!
I just noticed that our fancy ‘build-aux/test-driver.scm’ uses ‘display’
instead of ‘write’ to write test values.
So for instance, in tests/gremlin.log, we have:
--8<---------------cut here---------------start------------->8---
test-name: expand-origin
[...]
expected-value: (OOO/../lib OOO ../OOO/bar/OOO/baz ORIGIN/foo)
--8<---------------cut here---------------end--------------->8---
… where we’d instead prefer to see:
--8<---------------cut here---------------start------------->8---
expected-value: ("OOO/../lib" "OOO" "../OOO/bar/OOO/baz" "ORIGIN/foo")
--8<---------------cut here---------------end--------------->8---
I figured I’d let you look into it. :-)
No rush though.
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Scheme test driver should use ‘write’
2016-05-22 20:36 Scheme test driver should use ‘write’ Ludovic Courtès
@ 2016-05-24 13:46 ` Mathieu Lirzin
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Lirzin @ 2016-05-24 13:46 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: Guix-devel
Hi,
ludo@gnu.org (Ludovic Courtès) writes:
> I just noticed that our fancy ‘build-aux/test-driver.scm’ uses ‘display’
> instead of ‘write’ to write test values.
>
> So for instance, in tests/gremlin.log, we have:
>
> test-name: expand-origin
>
> [...]
>
> expected-value: (OOO/../lib OOO ../OOO/bar/OOO/baz ORIGIN/foo)
>
> … where we’d instead prefer to see:
>
> expected-value: ("OOO/../lib" "OOO" "../OOO/bar/OOO/baz" "ORIGIN/foo")
Indeed. I will fix this.
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-24 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-22 20:36 Scheme test driver should use ‘write’ Ludovic Courtès
2016-05-24 13:46 ` Mathieu Lirzin
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).