[PATCH 1/2] gnu: Add gsound.

[PATCH 1/2] gnu: Add gsound.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 110 bytes --]

Hello,
this patch is gsound library required for gnome-clocks application.

Built and linted.

Thank you

[-- Attachment #2: 0001-gnu-Add-gsound.patch --]
[-- Type: text/x-patch, Size: 2640 bytes --]

From 1d8368a12295c223626a3638d45e50a2043b980c Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Sat, 1 Oct 2016 07:17:34 -0500
Subject: [PATCH 1/2] gnu: Add gsound.

	* gnu/packages/gsound.scm (gsound): New variable.
	
---
 gnu/packages/gsound.scm | 53 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 gnu/packages/gsound.scm

diff --git a/gnu/packages/gsound.scm b/gnu/packages/gsound.scm
new file mode 100644
index 0000000..6894bbe
--- /dev/null
+++ b/gnu/packages/gsound.scm
@@ -0,0 +1,53 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages gsound)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages libcanberra)
+  #:use-module (gnu packages pkg-config))
+
+(define-public gsound
+  (package
+    (name "gsound")
+    (version "1.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0lwfwx2c99qrp08pfaj59pks5dphsnxjgrxyadz065d8xqqgza5v"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib" ,glib) ; for gio-2.0.
+       ("libcanberra" ,libcanberra)))
+    (home-page "https://wiki.gnome.org/Projects/GSound")
+    (synopsis "Small library for playing system sounds")
+    (description
+     "Designed to be used via GObject Introspection,
+and is a thin wrapper around the libcanberra C library.")
+    (license license:lgpl2.1)))
-- 
2.10.0

Re: [PATCH 1/2] gnu: Add gsound.

[Ludovic Courtès]

Hello,

rennes <rennes@openmailbox.org> skribis:

> From 1d8368a12295c223626a3638d45e50a2043b980c Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <rennes@openmailbox.org>
> Date: Sat, 1 Oct 2016 07:17:34 -0500
> Subject: [PATCH 1/2] gnu: Add gsound.
>
> 	* gnu/packages/gsound.scm (gsound): New variable.
  ^^^^^^

Extra space here.  :-)

I think this should go to libcanberra.scm rather than its own module.
WDYT?

> +    (description
> +     "Designed to be used via GObject Introspection,
> +and is a thin wrapper around the libcanberra C library.")

Could you improve this description, as per
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>?

> +    (license license:lgpl2.1)))

It should be ‘lgpl2.1+’ (meaning “or any later version”), unless the “or
any later version” wording has been explicitly removed from the
copyright headers or the license file says so (unlikely in this case).

Could you send an updated patch?

Thanks!

Ludo’.