unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Tanguy Le Carrour <tanguy@bioneland.org>,
	Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: gnu: python: Update to 3.8.0.
Date: Fri, 01 Nov 2019 00:08:27 +0100	[thread overview]
Message-ID: <87zhhgo6ms.fsf@devup.no> (raw)
In-Reply-To: <20191030180150.k2txz37uffgu777k@melmoth>

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Tanguy Le Carrour <tanguy@bioneland.org> writes:

> Le 10/30, Tanguy Le Carrour a écrit :
>>  2- To make it work I had to deactivate 4 tests. There was already a
>>     patch doing something similar ("This fails for unknown reasons on Guix"),
>>     but I'm pretty sure it would be better to work on fixing the problems, right?

Most of them seemed to use KeyboardInterrups, which do not work in the
build container (I suppose because /dev/stdin is not a TTY?).

> Oh, oh… what I forgot to mention is that… it's a shameless copy/paste of
> the python-3.7 package and it would deserve a rewrite! Something like
> `(inherit python-3.7)` and a modification of [source](patches) and
> [source](snippet). But I'm not sure how to do that!

Origins can also be inherited:

(source (origin
         (inherit (package-source python-3.7))
         (uri ...)
         (sha256 ...)
         (patches (append (origin-patches (package-source python-3.7))
                          (search-patches "python-3.8-adjust-tests.patch")))))

That would inherit the snippet and any other properties that are not
explicitly overridden.

HTH,
Marius

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-10-31 23:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23  9:11 gnu: python: Update to 3.8.0 Tanguy Le Carrour
2019-10-23 11:42 ` Hartmut Goebel
2019-10-23 12:51   ` Tanguy Le Carrour
2019-10-23 13:16     ` Hartmut Goebel
2019-10-30 16:04       ` Tanguy Le Carrour
2019-10-30 18:01         ` Tanguy Le Carrour
2019-10-31 23:08           ` Marius Bakke [this message]
2019-11-04  9:15             ` Tanguy Le Carrour
2019-11-04  9:19               ` Gábor Boskovits
2019-11-04 10:50                 ` Tanguy Le Carrour
2019-11-04 12:31                   ` Gábor Boskovits
2019-11-13  8:03                     ` Tanguy Le Carrour
2019-11-13 11:29                       ` Tobias Geerinckx-Rice
2019-11-13 13:25                         ` Tanguy Le Carrour
2019-11-13 11:34                       ` Gábor Boskovits
2019-11-13 13:23                         ` Tanguy Le Carrour
2019-11-13 13:27                           ` Gábor Boskovits
2019-11-14  8:48                             ` Tanguy Le Carrour
2019-11-10 23:02               ` Marius Bakke
2019-10-23 17:48   ` Marius Bakke
2019-10-24  8:03     ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhhgo6ms.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=guix-devel@gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).